All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx
@ 2016-04-25 16:08 ` J.D. Schroeder
  0 siblings, 0 replies; 5+ messages in thread
From: J.D. Schroeder @ 2016-04-25 16:08 UTC (permalink / raw)
  To: linux-kernel, peter.ujfalusi, lgirdwood, broonie, perex, tiwai,
	jsarha, alsa-devel
  Cc: Jim Lodes, J.D. Schroeder

From: Jim Lodes <jim.lodes@garmin.com>

The mcasp davinci_mcasp_set_dai_fmt function was overriding ahclkx
input/output status that had already been set by the
davinci_mcasp_set_sysclk function. This commit removes clearing
of the ahclkx input/output status from davinci_mcasp_set_dai_fmt.

Signed-off-by: Jim Lodes <jim.lodes@garmin.com>
Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
---
 sound/soc/davinci/davinci-mcasp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
index e132498..a1197ad 100644
--- a/sound/soc/davinci/davinci-mcasp.c
+++ b/sound/soc/davinci/davinci-mcasp.c
@@ -489,7 +489,7 @@ static int davinci_mcasp_set_dai_fmt(struct snd_soc_dai *cpu_dai,
 		mcasp_clr_bits(mcasp, DAVINCI_MCASP_RXFMCTL_REG, AFSRE);
 
 		mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDIR_REG,
-			       ACLKX | AHCLKX | AFSX | ACLKR | AHCLKR | AFSR);
+			       ACLKX | AFSX | ACLKR | AHCLKR | AFSR);
 		mcasp->bclk_master = 0;
 		break;
 	default:
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx
@ 2016-04-25 16:08 ` J.D. Schroeder
  0 siblings, 0 replies; 5+ messages in thread
From: J.D. Schroeder @ 2016-04-25 16:08 UTC (permalink / raw)
  To: linux-kernel, peter.ujfalusi, lgirdwood, broonie, perex, tiwai,
	jsarha, alsa-devel
  Cc: Jim Lodes, J.D. Schroeder

From: Jim Lodes <jim.lodes@garmin.com>

The mcasp davinci_mcasp_set_dai_fmt function was overriding ahclkx
input/output status that had already been set by the
davinci_mcasp_set_sysclk function. This commit removes clearing
of the ahclkx input/output status from davinci_mcasp_set_dai_fmt.

Signed-off-by: Jim Lodes <jim.lodes@garmin.com>
Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
---
 sound/soc/davinci/davinci-mcasp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
index e132498..a1197ad 100644
--- a/sound/soc/davinci/davinci-mcasp.c
+++ b/sound/soc/davinci/davinci-mcasp.c
@@ -489,7 +489,7 @@ static int davinci_mcasp_set_dai_fmt(struct snd_soc_dai *cpu_dai,
 		mcasp_clr_bits(mcasp, DAVINCI_MCASP_RXFMCTL_REG, AFSRE);
 
 		mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDIR_REG,
-			       ACLKX | AHCLKX | AFSX | ACLKR | AHCLKR | AFSR);
+			       ACLKX | AFSX | ACLKR | AHCLKR | AFSR);
 		mcasp->bclk_master = 0;
 		break;
 	default:
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx
  2016-04-25 16:08 ` J.D. Schroeder
@ 2016-04-29 13:19   ` Peter Ujfalusi
  -1 siblings, 0 replies; 5+ messages in thread
From: Peter Ujfalusi @ 2016-04-29 13:19 UTC (permalink / raw)
  To: J.D. Schroeder, linux-kernel, lgirdwood, broonie, perex, tiwai,
	jsarha, alsa-devel
  Cc: Jim Lodes, J.D. Schroeder

On 04/25/2016 07:08 PM, J.D. Schroeder wrote:
> From: Jim Lodes <jim.lodes@garmin.com>
> 
> The mcasp davinci_mcasp_set_dai_fmt function was overriding ahclkx
> input/output status that had already been set by the
> davinci_mcasp_set_sysclk function. This commit removes clearing
> of the ahclkx input/output status from davinci_mcasp_set_dai_fmt.

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> 
> Signed-off-by: Jim Lodes <jim.lodes@garmin.com>
> Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
> ---
>  sound/soc/davinci/davinci-mcasp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index e132498..a1197ad 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -489,7 +489,7 @@ static int davinci_mcasp_set_dai_fmt(struct snd_soc_dai *cpu_dai,
>  		mcasp_clr_bits(mcasp, DAVINCI_MCASP_RXFMCTL_REG, AFSRE);
>  
>  		mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDIR_REG,
> -			       ACLKX | AHCLKX | AFSX | ACLKR | AHCLKR | AFSR);
> +			       ACLKX | AFSX | ACLKR | AHCLKR | AFSR);
>  		mcasp->bclk_master = 0;
>  		break;
>  	default:
> 


-- 
Péter

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx
@ 2016-04-29 13:19   ` Peter Ujfalusi
  0 siblings, 0 replies; 5+ messages in thread
From: Peter Ujfalusi @ 2016-04-29 13:19 UTC (permalink / raw)
  To: J.D. Schroeder, linux-kernel, lgirdwood, broonie, perex, tiwai,
	jsarha, alsa-devel
  Cc: Jim Lodes, J.D. Schroeder

On 04/25/2016 07:08 PM, J.D. Schroeder wrote:
> From: Jim Lodes <jim.lodes@garmin.com>
> 
> The mcasp davinci_mcasp_set_dai_fmt function was overriding ahclkx
> input/output status that had already been set by the
> davinci_mcasp_set_sysclk function. This commit removes clearing
> of the ahclkx input/output status from davinci_mcasp_set_dai_fmt.

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> 
> Signed-off-by: Jim Lodes <jim.lodes@garmin.com>
> Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
> ---
>  sound/soc/davinci/davinci-mcasp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index e132498..a1197ad 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -489,7 +489,7 @@ static int davinci_mcasp_set_dai_fmt(struct snd_soc_dai *cpu_dai,
>  		mcasp_clr_bits(mcasp, DAVINCI_MCASP_RXFMCTL_REG, AFSRE);
>  
>  		mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDIR_REG,
> -			       ACLKX | AHCLKX | AFSX | ACLKR | AHCLKR | AFSR);
> +			       ACLKX | AFSX | ACLKR | AHCLKR | AFSR);
>  		mcasp->bclk_master = 0;
>  		break;
>  	default:
> 


-- 
Péter

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Applied "ASoC: davinci-mcasp: Fix overwriting of ahclkx" to the asoc tree
  2016-04-25 16:08 ` J.D. Schroeder
  (?)
  (?)
@ 2016-05-02 11:03 ` Mark Brown
  -1 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2016-05-02 11:03 UTC (permalink / raw)
  To: Jim Lodes
  Cc: J.D. Schroeder, alsa-devel, lgirdwood, tiwai, linux-kernel,
	jsarha, peter.ujfalusi, broonie

The patch

   ASoC: davinci-mcasp: Fix overwriting of ahclkx

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 823ecdd684e28d4e71686fc8787b6d31b1223382 Mon Sep 17 00:00:00 2001
From: Jim Lodes <jim.lodes@garmin.com>
Date: Mon, 25 Apr 2016 11:08:10 -0500
Subject: [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx

The mcasp davinci_mcasp_set_dai_fmt function was overriding ahclkx
input/output status that had already been set by the
davinci_mcasp_set_sysclk function. This commit removes clearing
of the ahclkx input/output status from davinci_mcasp_set_dai_fmt.

Signed-off-by: Jim Lodes <jim.lodes@garmin.com>
Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/davinci/davinci-mcasp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
index e1324989bd6b..a1197ad023f6 100644
--- a/sound/soc/davinci/davinci-mcasp.c
+++ b/sound/soc/davinci/davinci-mcasp.c
@@ -489,7 +489,7 @@ static int davinci_mcasp_set_dai_fmt(struct snd_soc_dai *cpu_dai,
 		mcasp_clr_bits(mcasp, DAVINCI_MCASP_RXFMCTL_REG, AFSRE);
 
 		mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDIR_REG,
-			       ACLKX | AHCLKX | AFSX | ACLKR | AHCLKR | AFSR);
+			       ACLKX | AFSX | ACLKR | AHCLKR | AFSR);
 		mcasp->bclk_master = 0;
 		break;
 	default:
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-02 11:03 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-25 16:08 [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx J.D. Schroeder
2016-04-25 16:08 ` J.D. Schroeder
2016-04-29 13:19 ` Peter Ujfalusi
2016-04-29 13:19   ` Peter Ujfalusi
2016-05-02 11:03 ` Applied "ASoC: davinci-mcasp: Fix overwriting of ahclkx" to the asoc tree Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.