* [PATCH net 0/2] bnxt_en: 2 bug fixes.
@ 2016-05-04 20:56 Michael Chan
2016-05-04 20:56 ` [PATCH net 1/2] bnxt_en: Need memory barrier when processing the completion ring Michael Chan
` (2 more replies)
0 siblings, 3 replies; 18+ messages in thread
From: Michael Chan @ 2016-05-04 20:56 UTC (permalink / raw)
To: davem; +Cc: netdev
Fix crash on ppc64 due to missing memory barrier and restore multicast
after reset.
Michael Chan (2):
bnxt_en: Need memory barrier when processing the completion ring.
bnxt_en: Setup multicast properly after resetting device.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 18+ messages in thread* [PATCH net 1/2] bnxt_en: Need memory barrier when processing the completion ring.
2016-05-04 20:56 [PATCH net 0/2] bnxt_en: 2 bug fixes Michael Chan
@ 2016-05-04 20:56 ` Michael Chan
2016-05-04 20:56 ` [PATCH net 2/2] bnxt_en: Setup multicast properly after resetting device Michael Chan
2016-05-04 21:12 ` [PATCH net 0/2] bnxt_en: 2 bug fixes David Miller
2 siblings, 0 replies; 18+ messages in thread
From: Michael Chan @ 2016-05-04 20:56 UTC (permalink / raw)
To: davem; +Cc: netdev
The code determines if the next ring entry is valid before proceeding
further to read the rest of the entry. The CPU can re-order and read
the rest of the entry first, possibly reading a stale entry, if DMA
of a new entry happens right after reading it. This issue can be
readily seen on a ppc64 system, causing it to crash.
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 72eb29e..f33ff20 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -1388,6 +1388,10 @@ static int bnxt_poll_work(struct bnxt *bp, struct bnxt_napi *bnapi, int budget)
if (!TX_CMP_VALID(txcmp, raw_cons))
break;
+ /* The valid test of the entry must be done first before
+ * reading any further.
+ */
+ rmb();
if (TX_CMP_TYPE(txcmp) == CMP_TYPE_TX_L2_CMP) {
tx_pkts++;
/* return full budget so NAPI will complete. */
--
1.8.3.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH net 2/2] bnxt_en: Setup multicast properly after resetting device.
2016-05-04 20:56 [PATCH net 0/2] bnxt_en: 2 bug fixes Michael Chan
2016-05-04 20:56 ` [PATCH net 1/2] bnxt_en: Need memory barrier when processing the completion ring Michael Chan
@ 2016-05-04 20:56 ` Michael Chan
2016-05-04 21:12 ` [PATCH net 0/2] bnxt_en: 2 bug fixes David Miller
2 siblings, 0 replies; 18+ messages in thread
From: Michael Chan @ 2016-05-04 20:56 UTC (permalink / raw)
To: davem; +Cc: netdev
The multicast/all-multicast internal flags are not properly restored
after device reset. This could lead to unreliable multicast operations
after an ethtool configuration change for example.
Call bnxt_mc_list_updated() and setup the vnic->mask in bnxt_init_chip()
to fix the issue.
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index f33ff20..9d4e8e1 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -4042,9 +4042,11 @@ static int bnxt_alloc_rfs_vnics(struct bnxt *bp)
}
static int bnxt_cfg_rx_mode(struct bnxt *);
+static bool bnxt_mc_list_updated(struct bnxt *, u32 *);
static int bnxt_init_chip(struct bnxt *bp, bool irq_re_init)
{
+ struct bnxt_vnic_info *vnic = &bp->vnic_info[0];
int rc = 0;
if (irq_re_init) {
@@ -4100,13 +4102,22 @@ static int bnxt_init_chip(struct bnxt *bp, bool irq_re_init)
netdev_err(bp->dev, "HWRM vnic filter failure rc: %x\n", rc);
goto err_out;
}
- bp->vnic_info[0].uc_filter_count = 1;
+ vnic->uc_filter_count = 1;
- bp->vnic_info[0].rx_mask = CFA_L2_SET_RX_MASK_REQ_MASK_BCAST;
+ vnic->rx_mask = CFA_L2_SET_RX_MASK_REQ_MASK_BCAST;
if ((bp->dev->flags & IFF_PROMISC) && BNXT_PF(bp))
- bp->vnic_info[0].rx_mask |=
- CFA_L2_SET_RX_MASK_REQ_MASK_PROMISCUOUS;
+ vnic->rx_mask |= CFA_L2_SET_RX_MASK_REQ_MASK_PROMISCUOUS;
+
+ if (bp->dev->flags & IFF_ALLMULTI) {
+ vnic->rx_mask |= CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST;
+ vnic->mc_list_count = 0;
+ } else {
+ u32 mask = 0;
+
+ bnxt_mc_list_updated(bp, &mask);
+ vnic->rx_mask |= mask;
+ }
rc = bnxt_cfg_rx_mode(bp);
if (rc)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH net 0/2] bnxt_en: 2 bug fixes.
2016-05-04 20:56 [PATCH net 0/2] bnxt_en: 2 bug fixes Michael Chan
2016-05-04 20:56 ` [PATCH net 1/2] bnxt_en: Need memory barrier when processing the completion ring Michael Chan
2016-05-04 20:56 ` [PATCH net 2/2] bnxt_en: Setup multicast properly after resetting device Michael Chan
@ 2016-05-04 21:12 ` David Miller
2 siblings, 0 replies; 18+ messages in thread
From: David Miller @ 2016-05-04 21:12 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Wed, 4 May 2016 16:56:42 -0400
> Fix crash on ppc64 due to missing memory barrier and restore multicast
> after reset.
Looks good, series applied, thanks.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH net 0/2] bnxt_en: 2 bug fixes.
@ 2016-11-11 5:11 Michael Chan
2016-11-13 17:37 ` David Miller
0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2016-11-11 5:11 UTC (permalink / raw)
To: davem; +Cc: netdev
Bug fixes in bnxt_setup_tc() and VF vitual link state.
Michael Chan (2):
bnxt_en: Fix ring arithmetic in bnxt_setup_tc().
bnxt_en: Fix VF virtual link state.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 11 ++++++-----
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 4 ++--
2 files changed, 8 insertions(+), 7 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH net 0/2] bnxt_en: 2 bug fixes.
@ 2019-04-08 21:39 Michael Chan
2019-04-08 23:39 ` David Miller
0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2019-04-08 21:39 UTC (permalink / raw)
To: davem; +Cc: netdev
The first patch prevents possible driver crash if we get a bad RX index
from the hardware. The second patch resets the device when the hardware
reports buffer error to recover from the error.
Please queue these for -stable also. Thanks.
Michael Chan (2):
bnxt_en: Improve RX consumer index validity check.
bnxt_en: Reset device on RX buffer errors.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net 0/2] bnxt_en: 2 bug fixes.
2019-04-08 21:39 Michael Chan
@ 2019-04-08 23:39 ` David Miller
0 siblings, 0 replies; 18+ messages in thread
From: David Miller @ 2019-04-08 23:39 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Mon, 8 Apr 2019 17:39:53 -0400
> The first patch prevents possible driver crash if we get a bad RX index
> from the hardware. The second patch resets the device when the hardware
> reports buffer error to recover from the error.
>
> Please queue these for -stable also. Thanks.
Series applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH net 0/2] bnxt_en: 2 bug fixes.
@ 2020-03-02 3:07 Michael Chan
2020-03-02 3:17 ` David Miller
0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2020-03-02 3:07 UTC (permalink / raw)
To: davem; +Cc: netdev
This first patch fixes a rare but possible crash in pci_disable_msix()
when the MTU is changed. The 2nd patch fixes a regression in error
code handling when flashing a file to NVRAM.
Please also queue these for -stable. Thanks.
Edwin Peer (1):
bnxt_en: fix error handling when flashing from file
Vasundhara Volam (1):
bnxt_en: reinitialize IRQs when MTU is modified
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 ++--
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 24 +++++++++++------------
2 files changed, 13 insertions(+), 15 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net 0/2] bnxt_en: 2 bug fixes.
2020-03-02 3:07 Michael Chan
@ 2020-03-02 3:17 ` David Miller
0 siblings, 0 replies; 18+ messages in thread
From: David Miller @ 2020-03-02 3:17 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Sun, 1 Mar 2020 22:07:16 -0500
> This first patch fixes a rare but possible crash in pci_disable_msix()
> when the MTU is changed. The 2nd patch fixes a regression in error
> code handling when flashing a file to NVRAM.
Applied.
> Please also queue these for -stable. Thanks.
Queued up, thanks Michael.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH net 0/2] bnxt_en: 2 bug fixes.
@ 2021-02-11 7:24 Michael Chan
2021-02-11 22:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2021-02-11 7:24 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, gospo
Two unrelated fixes. The first one fixes intermittent false TX timeouts
during ring reconfigurations. The second one fixes a formatting
discrepancy between the stored and the running FW versions.
Please also queue these for -stable. Thanks.
Edwin Peer (1):
bnxt_en: reverse order of TX disable and carrier off
Vasundhara Volam (1):
bnxt_en: Fix devlink info's stored fw.psid version format.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++-
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
--
2.18.1
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH net 0/2] bnxt_en: 2 bug fixes.
@ 2021-05-15 7:25 Michael Chan
2021-05-17 21:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2021-05-15 7:25 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, gospo
The first one fixes a bug to properly identify some recently added HyperV
device IDs. The second one fixes device context memory set up on systems
with 64K page size.
Please queue these for -stable as well. Thanks.
Andy Gospodarek (1):
bnxt_en: Include new P5 HV definition in VF check.
Michael Chan (1):
bnxt_en: Fix context memory setup for 64K page size.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 12 +++---------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 10 ++++++++++
2 files changed, 13 insertions(+), 9 deletions(-)
--
2.18.1
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH net 0/2] bnxt_en: 2 bug fixes
@ 2021-08-15 20:15 Michael Chan
2021-08-16 10:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2021-08-15 20:15 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, gospo
[-- Attachment #1: Type: text/plain, Size: 378 bytes --]
The first one disables aRFS/NTUPLE on an older broken firmware version.
The second one adds missing memory barriers related to completion ring
handling.
Michael Chan (2):
bnxt_en: Disable aRFS if running on 212 firmware
bnxt_en: Add missing DMA memory barriers
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH net 0/2] bnxt_en: 2 bug fixes
@ 2023-03-04 2:43 Michael Chan
2023-03-06 21:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2023-03-04 2:43 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, edumazet, pabeni, gospo
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
This series fixes 2 issues:
1. A potential order-5 memory allocation failure during open.
2. Double memory free bug during shutdown.
Michael Chan (1):
bnxt_en: Avoid order-5 memory allocation for TPA data
Selvin Xavier (1):
bnxt_en: Fix the double free during device removal
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 25 +++++++++----------
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 2 ++
2 files changed, 14 insertions(+), 13 deletions(-)
--
2.32.0
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net 0/2] bnxt_en: 2 bug fixes
2023-03-04 2:43 Michael Chan
@ 2023-03-06 21:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 18+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-06 21:30 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, kuba, edumazet, pabeni, gospo
Hello:
This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Fri, 3 Mar 2023 18:43:56 -0800 you wrote:
> This series fixes 2 issues:
>
> 1. A potential order-5 memory allocation failure during open.
> 2. Double memory free bug during shutdown.
>
> Michael Chan (1):
> bnxt_en: Avoid order-5 memory allocation for TPA data
>
> [...]
Here is the summary with links:
- [net,1/2] bnxt_en: Avoid order-5 memory allocation for TPA data
https://git.kernel.org/netdev/net/c/accd7e23693a
- [net,2/2] bnxt_en: Fix the double free during device removal
https://git.kernel.org/netdev/net/c/89b59a84cb16
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2023-03-06 21:31 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-04 20:56 [PATCH net 0/2] bnxt_en: 2 bug fixes Michael Chan
2016-05-04 20:56 ` [PATCH net 1/2] bnxt_en: Need memory barrier when processing the completion ring Michael Chan
2016-05-04 20:56 ` [PATCH net 2/2] bnxt_en: Setup multicast properly after resetting device Michael Chan
2016-05-04 21:12 ` [PATCH net 0/2] bnxt_en: 2 bug fixes David Miller
2016-11-11 5:11 Michael Chan
2016-11-13 17:37 ` David Miller
2019-04-08 21:39 Michael Chan
2019-04-08 23:39 ` David Miller
2020-03-02 3:07 Michael Chan
2020-03-02 3:17 ` David Miller
2021-02-11 7:24 Michael Chan
2021-02-11 22:50 ` patchwork-bot+netdevbpf
2021-05-15 7:25 Michael Chan
2021-05-17 21:10 ` patchwork-bot+netdevbpf
2021-08-15 20:15 Michael Chan
2021-08-16 10:40 ` patchwork-bot+netdevbpf
2023-03-04 2:43 Michael Chan
2023-03-06 21:30 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.