All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-kernel@lists.codethink.co.uk
Cc: Ben Dooks <ben.dooks@codethink.co.uk>,
	Eric Anholt <eric@anholt.net>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Alexander Aring <alex.aring@gmail.com>,
	Kevin Hilman <khilman@linaro.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: bcm2835: remove unused __packet
Date: Tue,  7 Jun 2016 18:49:33 +0100	[thread overview]
Message-ID: <1465321773-21519-1-git-send-email-ben.dooks@codethink.co.uk> (raw)

The driver defines a variable called __packet but then never
uses it, and does not export it for others to use either. Fix
the warning about undeclared variable by removing it.

drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Eric Anholt <eric@anholt.net>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Alexander Aring <alex.aring@gmail.com>
Cc: Kevin Hilman <khilman@linaro.org>
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
 drivers/soc/bcm/raspberrypi-power.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c
index fe96a8b..f7ed118 100644
--- a/drivers/soc/bcm/raspberrypi-power.c
+++ b/drivers/soc/bcm/raspberrypi-power.c
@@ -45,7 +45,7 @@ struct rpi_power_domains {
 struct rpi_power_domain_packet {
 	u32 domain;
 	u32 on;
-} __packet;
+};
 
 /*
  * Asks the firmware to enable or disable power on a specific power
-- 
2.8.1

WARNING: multiple messages have this Message-ID (diff)
From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: bcm2835: remove unused __packet
Date: Tue,  7 Jun 2016 18:49:33 +0100	[thread overview]
Message-ID: <1465321773-21519-1-git-send-email-ben.dooks@codethink.co.uk> (raw)

The driver defines a variable called __packet but then never
uses it, and does not export it for others to use either. Fix
the warning about undeclared variable by removing it.

drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Eric Anholt <eric@anholt.net>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Alexander Aring <alex.aring@gmail.com>
Cc: Kevin Hilman <khilman@linaro.org>
Cc: linux-kernel at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
---
 drivers/soc/bcm/raspberrypi-power.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c
index fe96a8b..f7ed118 100644
--- a/drivers/soc/bcm/raspberrypi-power.c
+++ b/drivers/soc/bcm/raspberrypi-power.c
@@ -45,7 +45,7 @@ struct rpi_power_domains {
 struct rpi_power_domain_packet {
 	u32 domain;
 	u32 on;
-} __packet;
+};
 
 /*
  * Asks the firmware to enable or disable power on a specific power
-- 
2.8.1

             reply	other threads:[~2016-06-07 17:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07 17:49 Ben Dooks [this message]
2016-06-07 17:49 ` [PATCH] ARM: bcm2835: remove unused __packet Ben Dooks
2016-06-07 20:30 ` Eric Anholt
2016-06-07 20:30   ` Eric Anholt
2016-06-10 22:11   ` Kevin Hilman
2016-06-10 22:11     ` Kevin Hilman
2016-06-13 15:55 ` Arnd Bergmann
2016-06-13 15:55   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465321773-21519-1-git-send-email-ben.dooks@codethink.co.uk \
    --to=ben.dooks@codethink.co.uk \
    --cc=alex.aring@gmail.com \
    --cc=eric@anholt.net \
    --cc=khilman@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@lists.codethink.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.