* [PATCH net-next 1/1] Remove the redundant initialization statement.
@ 2016-06-13 9:01 Sudarsana Reddy Kalluru
2016-06-15 5:28 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Sudarsana Reddy Kalluru @ 2016-06-13 9:01 UTC (permalink / raw)
To: davem; +Cc: netdev, Yuval.Mintz, sudarsana.kalluru
The callback ".getcbx" is being initialized twice. This was introduced by
the commit 0fdeb72aa6c9 ("qede: Add dcbnl support."). The patch removes the
redundant initialization statement.
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: Sudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com>
---
drivers/net/ethernet/qlogic/qede/qede_dcbnl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede_dcbnl.c b/drivers/net/ethernet/qlogic/qede/qede_dcbnl.c
index 03e8c02..318f0cb 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_dcbnl.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_dcbnl.c
@@ -308,7 +308,6 @@ static const struct dcbnl_rtnl_ops qede_dcbnl_ops = {
.ieee_setets = qede_dcbnl_ieee_setets,
.ieee_getapp = qede_dcbnl_ieee_getapp,
.ieee_setapp = qede_dcbnl_ieee_setapp,
- .getdcbx = qede_dcbnl_getdcbx,
.ieee_peer_getpfc = qede_dcbnl_ieee_peer_getpfc,
.ieee_peer_getets = qede_dcbnl_ieee_peer_getets,
.getstate = qede_dcbnl_getstate,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next 1/1] Remove the redundant initialization statement.
2016-06-13 9:01 [PATCH net-next 1/1] Remove the redundant initialization statement Sudarsana Reddy Kalluru
@ 2016-06-15 5:28 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-06-15 5:28 UTC (permalink / raw)
To: sudarsana.kalluru; +Cc: netdev, Yuval.Mintz
From: Sudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com>
Date: Mon, 13 Jun 2016 05:01:10 -0400
> The callback ".getcbx" is being initialized twice. This was introduced by
> the commit 0fdeb72aa6c9 ("qede: Add dcbnl support."). The patch removes the
> redundant initialization statement.
>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
> Signed-off-by: Sudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com>
This subject line is not properly formed.
After "[PATCH ...] " you must provide a proper subsystem prefix specifier
followed by a colon character, and a SPACE.
Otherwise nobody reading the GIT shortlog has any idea where in the kernel
your change is taking place.
An appropriate subsystem prefix for this patch woult be "qede: ".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-15 5:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-13 9:01 [PATCH net-next 1/1] Remove the redundant initialization statement Sudarsana Reddy Kalluru
2016-06-15 5:28 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.