[PATCH iproute2] Enable use of extra debugging information

[PATCH iproute2] Enable use of extra debugging information

[David Ahern]

Add -g flag to builds if DEBUG parameter is set. Improves
debugging with gdb.

Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
---
 Makefile | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Makefile b/Makefile
index 15c81ecfdca3..8e006759079d 100644
--- a/Makefile
+++ b/Makefile
@@ -39,7 +39,11 @@ HOSTCC = gcc
 DEFINES += -D_GNU_SOURCE
 # Turn on transparent support for LFS
 DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
+ifdef DEBUG
+CCOPTS = -g
+else
 CCOPTS = -O2
+endif
 WFLAGS := -Wall -Wstrict-prototypes  -Wmissing-prototypes
 WFLAGS += -Wmissing-declarations -Wold-style-definition -Wformat=2
 
-- 
2.1.4

Re: [PATCH iproute2] Enable use of extra debugging information

[Jakub Sitnicki]

Hi David,

On Wed, Jun 22, 2016 at 01:27 AM CEST, David Ahern <dsa@cumulusnetworks.com> wrote:
> Add -g flag to builds if DEBUG parameter is set. Improves
> debugging with gdb.
>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
> ---
>  Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 15c81ecfdca3..8e006759079d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -39,7 +39,11 @@ HOSTCC = gcc
>  DEFINES += -D_GNU_SOURCE
>  # Turn on transparent support for LFS
>  DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
> +ifdef DEBUG
> +CCOPTS = -g
> +else
>  CCOPTS = -O2
> +endif
>  WFLAGS := -Wall -Wstrict-prototypes  -Wmissing-prototypes
>  WFLAGS += -Wmissing-declarations -Wold-style-definition -Wformat=2

This implies a change of optimization level to -O0 when building with
DEBUG set, doesn't it? Was it intentional?

Perhaps it would be less surprising to explicitly set -O0, if that was
your intention. Just a thought.

Thanks,
Jakub

Re: [PATCH iproute2] Enable use of extra debugging information

[David Ahern]

On 6/22/16 2:36 AM, Jakub Sitnicki wrote:
>> diff --git a/Makefile b/Makefile
>> index 15c81ecfdca3..8e006759079d 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -39,7 +39,11 @@ HOSTCC = gcc
>>  DEFINES += -D_GNU_SOURCE
>>  # Turn on transparent support for LFS
>>  DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
>> +ifdef DEBUG
>> +CCOPTS = -g
>> +else
>>  CCOPTS = -O2
>> +endif
>>  WFLAGS := -Wall -Wstrict-prototypes  -Wmissing-prototypes
>>  WFLAGS += -Wmissing-declarations -Wold-style-definition -Wformat=2
>
> This implies a change of optimization level to -O0 when building with
> DEBUG set, doesn't it? Was it intentional?

yes it is intentional.


> Perhaps it would be less surprising to explicitly set -O0, if that was
> your intention. Just a thought.
>
> Thanks,
> Jakub
>

Re: [PATCH iproute2] Enable use of extra debugging information

[Stephen Hemminger]

On Tue, 21 Jun 2016 16:27:09 -0700
David Ahern <dsa@cumulusnetworks.com> wrote:

> Add -g flag to builds if DEBUG parameter is set. Improves
> debugging with gdb.
> 
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>

I would rather not put this in the upstream repo.
Developers are free to modify flags as they see fit when debugging.