From: Joe Perches <joe@perches.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Stephen Hemminger <stephen@networkplumber.org>,
"David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening
Date: Thu, 23 Jun 2016 12:00:00 -0700 [thread overview]
Message-ID: <1466708400.1847.15.camel@perches.com> (raw)
In-Reply-To: <20160623173659.GA3474@salvia>
On Thu, 2016-06-23 at 19:36 +0200, Pablo Neira Ayuso wrote:
> On Wed, Jun 15, 2016 at 01:58:45PM -0700, Joe Perches wrote:
> >
> > There is code duplication of a masked ethernet address comparison here
> > so make it a separate function instead.
> >
> > Miscellanea:
> >
> > o Neaten alignment of FWINV macro uses to make it clearer for the reader
> Applied, thanks.
>
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> >
> > This masked_ether_addr_equal function could go into etherdevice.h,
> > but I don't see another use like it in kernel code. Is there one?
> This is specific of iptables, not even nftables would use this. So I
> would keep this in the iptables tree.
Did you see the other patch that adds a generic
ether_addr_equal_masked() and uses it in a few
more files?
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Patrick McHardy <kaber@trash.net>,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening
Date: Thu, 23 Jun 2016 12:00:00 -0700 [thread overview]
Message-ID: <1466708400.1847.15.camel@perches.com> (raw)
In-Reply-To: <20160623173659.GA3474@salvia>
On Thu, 2016-06-23 at 19:36 +0200, Pablo Neira Ayuso wrote:
> On Wed, Jun 15, 2016 at 01:58:45PM -0700, Joe Perches wrote:
> >
> > There is code duplication of a masked ethernet address comparison here
> > so make it a separate function instead.
> >
> > Miscellanea:
> >
> > o Neaten alignment of FWINV macro uses to make it clearer for the reader
> Applied, thanks.
>
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> >
> > This masked_ether_addr_equal function could go into etherdevice.h,
> > but I don't see another use like it in kernel code. Is there one?
> This is specific of iptables, not even nftables would use this. So I
> would keep this in the iptables tree.
Did you see the other patch that adds a generic
ether_addr_equal_masked() and uses it in a few
more files?
next prev parent reply other threads:[~2016-06-23 19:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 20:58 [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening Joe Perches
2016-06-15 20:58 ` [Bridge] " Joe Perches
2016-06-16 6:04 ` Joe Perches
2016-06-16 6:04 ` [Bridge] " Joe Perches
2016-06-16 6:04 ` Joe Perches
2016-06-23 17:36 ` Pablo Neira Ayuso
2016-06-23 17:36 ` [Bridge] " Pablo Neira Ayuso
2016-06-23 17:36 ` Pablo Neira Ayuso
2016-06-23 19:00 ` Joe Perches [this message]
2016-06-23 19:00 ` [Bridge] " Joe Perches
2016-06-24 8:51 ` Pablo Neira Ayuso
2016-06-24 8:51 ` [Bridge] " Pablo Neira Ayuso
2016-06-24 8:51 ` Pablo Neira Ayuso
2016-06-24 8:57 ` Pablo Neira Ayuso
2016-06-24 8:57 ` [Bridge] " Pablo Neira Ayuso
2016-06-24 8:57 ` Pablo Neira Ayuso
2016-06-24 18:32 ` [PATCH] etherdevice.h & bridge: netfilter: Add and use ether_addr_equal_masked Joe Perches
2016-06-24 18:32 ` [Bridge] " Joe Perches
2016-06-28 13:01 ` David Miller
2016-06-28 13:01 ` [Bridge] " David Miller
2016-06-28 13:01 ` David Miller
2016-06-30 9:26 ` Pablo Neira Ayuso
2016-06-30 9:26 ` [Bridge] " Pablo Neira Ayuso
2016-06-30 9:26 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466708400.1847.15.camel@perches.com \
--to=joe@perches.com \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.