From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu,
stephen@networkplumber.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH] etherdevice.h & bridge: netfilter: Add and use ether_addr_equal_masked
Date: Tue, 28 Jun 2016 09:01:12 -0400 (EDT) [thread overview]
Message-ID: <20160628.090112.1438085992622018555.davem@davemloft.net> (raw)
In-Reply-To: <3dcddfef3b9ac0eceb2869d9e95ae857b509fabe.1466793022.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Fri, 24 Jun 2016 11:32:26 -0700
> There are code duplications of a masked ethernet address comparison here
> so make it a separate function instead.
>
> Miscellanea:
>
> o Neaten alignment of FWINV macro uses to make it clearer for the reader
>
> Signed-off-by: Joe Perches <joe@perches.com>
Pablo feel free to take this:
Acked-by: David S. Miller <davem@davemloft.net>
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, coreteam@netfilter.org,
netfilter-devel@vger.kernel.org, kadlec@blackhole.kfki.hu,
kaber@trash.net, pablo@netfilter.org
Subject: Re: [PATCH] etherdevice.h & bridge: netfilter: Add and use ether_addr_equal_masked
Date: Tue, 28 Jun 2016 09:01:12 -0400 (EDT) [thread overview]
Message-ID: <20160628.090112.1438085992622018555.davem@davemloft.net> (raw)
In-Reply-To: <3dcddfef3b9ac0eceb2869d9e95ae857b509fabe.1466793022.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Fri, 24 Jun 2016 11:32:26 -0700
> There are code duplications of a masked ethernet address comparison here
> so make it a separate function instead.
>
> Miscellanea:
>
> o Neaten alignment of FWINV macro uses to make it clearer for the reader
>
> Signed-off-by: Joe Perches <joe@perches.com>
Pablo feel free to take this:
Acked-by: David S. Miller <davem@davemloft.net>
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, coreteam@netfilter.org,
netfilter-devel@vger.kernel.org, kadlec@blackhole.kfki.hu,
kaber@trash.net, pablo@netfilter.org
Subject: Re: [Bridge] [PATCH] etherdevice.h & bridge: netfilter: Add and use ether_addr_equal_masked
Date: Tue, 28 Jun 2016 09:01:12 -0400 (EDT) [thread overview]
Message-ID: <20160628.090112.1438085992622018555.davem@davemloft.net> (raw)
In-Reply-To: <3dcddfef3b9ac0eceb2869d9e95ae857b509fabe.1466793022.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Fri, 24 Jun 2016 11:32:26 -0700
> There are code duplications of a masked ethernet address comparison here
> so make it a separate function instead.
>
> Miscellanea:
>
> o Neaten alignment of FWINV macro uses to make it clearer for the reader
>
> Signed-off-by: Joe Perches <joe@perches.com>
Pablo feel free to take this:
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2016-06-28 13:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 20:58 [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening Joe Perches
2016-06-15 20:58 ` [Bridge] " Joe Perches
2016-06-16 6:04 ` Joe Perches
2016-06-16 6:04 ` [Bridge] " Joe Perches
2016-06-16 6:04 ` Joe Perches
2016-06-23 17:36 ` Pablo Neira Ayuso
2016-06-23 17:36 ` [Bridge] " Pablo Neira Ayuso
2016-06-23 17:36 ` Pablo Neira Ayuso
2016-06-23 19:00 ` Joe Perches
2016-06-23 19:00 ` [Bridge] " Joe Perches
2016-06-24 8:51 ` Pablo Neira Ayuso
2016-06-24 8:51 ` [Bridge] " Pablo Neira Ayuso
2016-06-24 8:51 ` Pablo Neira Ayuso
2016-06-24 8:57 ` Pablo Neira Ayuso
2016-06-24 8:57 ` [Bridge] " Pablo Neira Ayuso
2016-06-24 8:57 ` Pablo Neira Ayuso
2016-06-24 18:32 ` [PATCH] etherdevice.h & bridge: netfilter: Add and use ether_addr_equal_masked Joe Perches
2016-06-24 18:32 ` [Bridge] " Joe Perches
2016-06-28 13:01 ` David Miller [this message]
2016-06-28 13:01 ` David Miller
2016-06-28 13:01 ` David Miller
2016-06-30 9:26 ` Pablo Neira Ayuso
2016-06-30 9:26 ` [Bridge] " Pablo Neira Ayuso
2016-06-30 9:26 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628.090112.1438085992622018555.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=joe@perches.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.