From: Garlic Tseng <garlic.tseng@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: <tiwai@suse.de>, <srv_heupstream@mediatek.com>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<koro.chen@mediatek.com>, <PC.Liao@mediatek.com>,
<ir.lian@mediatek.com>
Subject: Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string
Date: Thu, 30 Jun 2016 20:55:45 +0800 [thread overview]
Message-ID: <1467291345.11091.16.camel@mtksdaap41> (raw)
In-Reply-To: <20160629191500.GU6247@sirena.org.uk>
On Wed, 2016-06-29 at 20:15 +0100, Mark Brown wrote:
> On Fri, Jun 17, 2016 at 03:43:58PM +0800, Garlic Tseng wrote:
> > Add supports for 16k (wideband BT) and add a general compatible
> > string "linux,bt-sco"
>
> This will claim that we support 16k on existing systems which we clearly
> don't. It also seems unwise to advertise multiple rates when we've no
> way to configure the rates... how does the BT controller figure out
> what the sample rate is?
The codec driver is a dummy driver for bt device and actually do
nothing. The user-space will control both bt part and alsa part (at
least in mt2701 platform). Yes the sound/soc/codecs/bt-sco.c was only
support 8k and was already there before the patch, but I think it might
be ok to extend it to 16k without any side effect.
If you worry about some potential risk (I don't see any) maybe we have
to develop another dummy bt-sco codec driver which support both 8k and
16k?
WARNING: multiple messages have this Message-ID (diff)
From: Garlic Tseng <garlic.tseng@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, ir.lian@mediatek.com,
srv_heupstream@mediatek.com, tiwai@suse.de,
linux-kernel@vger.kernel.org, koro.chen@mediatek.com,
linux-mediatek@lists.infradead.org, PC.Liao@mediatek.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string
Date: Thu, 30 Jun 2016 20:55:45 +0800 [thread overview]
Message-ID: <1467291345.11091.16.camel@mtksdaap41> (raw)
In-Reply-To: <20160629191500.GU6247@sirena.org.uk>
On Wed, 2016-06-29 at 20:15 +0100, Mark Brown wrote:
> On Fri, Jun 17, 2016 at 03:43:58PM +0800, Garlic Tseng wrote:
> > Add supports for 16k (wideband BT) and add a general compatible
> > string "linux,bt-sco"
>
> This will claim that we support 16k on existing systems which we clearly
> don't. It also seems unwise to advertise multiple rates when we've no
> way to configure the rates... how does the BT controller figure out
> what the sample rate is?
The codec driver is a dummy driver for bt device and actually do
nothing. The user-space will control both bt part and alsa part (at
least in mt2701 platform). Yes the sound/soc/codecs/bt-sco.c was only
support 8k and was already there before the patch, but I think it might
be ok to extend it to 16k without any side effect.
If you worry about some potential risk (I don't see any) maybe we have
to develop another dummy bt-sco codec driver which support both 8k and
16k?
WARNING: multiple messages have this Message-ID (diff)
From: garlic.tseng@mediatek.com (Garlic Tseng)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string
Date: Thu, 30 Jun 2016 20:55:45 +0800 [thread overview]
Message-ID: <1467291345.11091.16.camel@mtksdaap41> (raw)
In-Reply-To: <20160629191500.GU6247@sirena.org.uk>
On Wed, 2016-06-29 at 20:15 +0100, Mark Brown wrote:
> On Fri, Jun 17, 2016 at 03:43:58PM +0800, Garlic Tseng wrote:
> > Add supports for 16k (wideband BT) and add a general compatible
> > string "linux,bt-sco"
>
> This will claim that we support 16k on existing systems which we clearly
> don't. It also seems unwise to advertise multiple rates when we've no
> way to configure the rates... how does the BT controller figure out
> what the sample rate is?
The codec driver is a dummy driver for bt device and actually do
nothing. The user-space will control both bt part and alsa part (at
least in mt2701 platform). Yes the sound/soc/codecs/bt-sco.c was only
support 8k and was already there before the patch, but I think it might
be ok to extend it to 16k without any side effect.
If you worry about some potential risk (I don't see any) maybe we have
to develop another dummy bt-sco codec driver which support both 8k and
16k?
next prev parent reply other threads:[~2016-06-30 12:55 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 7:43 [alsa-devel] [PATCH v5 0/9] ASoC: Mediatek: Add support for MT2701 SOC Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-17 7:43 ` [alsa-devel] [PATCH v5 1/9] ASoC: mediatek: Refine mt8173 driver and change config option Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-17 7:43 ` [alsa-devel] [PATCH v5 2/9] ASoC: mediatek: implement mediatek common structure Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-17 7:43 ` [alsa-devel] [PATCH v5 3/9] ASoC: mediatek: let mt8173 use " Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-29 19:16 ` Applied "ASoC: mediatek: let mt8173 use mediatek common structure" to the asoc tree Mark Brown
2016-06-29 19:16 ` Mark Brown
2016-06-29 19:16 ` Mark Brown
2016-06-17 7:43 ` [alsa-devel] [PATCH v5 4/9] ASoC: mediatek: add documents for mt2701 Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-17 7:43 ` [alsa-devel] [PATCH v5 5/9] ASoC: mediatek: add structure define and clock control for 2701 Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-17 7:43 ` [alsa-devel] [PATCH v5 6/9] ASoC: mediatek: add mt2701 platform driver implementation Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-29 19:13 ` Mark Brown
2016-06-29 19:13 ` Mark Brown
2016-06-30 13:39 ` Garlic Tseng
2016-06-30 13:39 ` Garlic Tseng
2016-06-30 13:39 ` Garlic Tseng
2016-07-04 2:28 ` [alsa-devel] " Garlic Tseng
2016-07-04 2:28 ` Garlic Tseng
2016-07-04 2:28 ` Garlic Tseng
2016-06-17 7:43 ` [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-29 19:15 ` Mark Brown
2016-06-29 19:15 ` Mark Brown
2016-06-29 19:15 ` Mark Brown
2016-06-30 12:55 ` Garlic Tseng [this message]
2016-06-30 12:55 ` Garlic Tseng
2016-06-30 12:55 ` Garlic Tseng
2016-07-01 2:49 ` [alsa-devel] " Garlic Tseng
2016-07-01 2:49 ` Garlic Tseng
2016-07-01 2:49 ` Garlic Tseng
2016-07-01 16:11 ` [alsa-devel] " Mark Brown
2016-07-01 16:11 ` Mark Brown
2016-07-01 16:11 ` Mark Brown
2016-07-02 9:05 ` Chen-Yu Tsai
2016-07-02 9:05 ` Chen-Yu Tsai
2016-07-02 9:05 ` Chen-Yu Tsai
2016-07-04 1:59 ` [alsa-devel] " Garlic Tseng
2016-07-04 1:59 ` Garlic Tseng
2016-07-04 1:59 ` Garlic Tseng
2016-06-17 7:43 ` [alsa-devel] [PATCH v5 8/9] ASoC: mediatek: add BT implementation Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-17 7:43 ` Garlic Tseng
2016-06-17 7:44 ` [alsa-devel] [PATCH v5 9/9] ASoC: mediatek: Add mt2701-cs42448 driver and config option Garlic Tseng
2016-06-17 7:44 ` Garlic Tseng
2016-06-17 7:44 ` Garlic Tseng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467291345.11091.16.camel@mtksdaap41 \
--to=garlic.tseng@mediatek.com \
--cc=PC.Liao@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ir.lian@mediatek.com \
--cc=koro.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=srv_heupstream@mediatek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.