All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ganesh Mahendran <opensource.ganesh@gmail.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, minchan@kernel.org, ngupta@vflare.org,
	sergey.senozhatsky.work@gmail.com, rostedt@goodmis.org,
	mingo@redhat.com, Ganesh Mahendran <opensource.ganesh@gmail.com>
Subject: [PATCH v2 6/8] mm/zsmalloc: keep comments consistent with code
Date: Mon,  4 Jul 2016 14:49:57 +0800	[thread overview]
Message-ID: <1467614999-4326-6-git-send-email-opensource.ganesh@gmail.com> (raw)
In-Reply-To: <1467614999-4326-1-git-send-email-opensource.ganesh@gmail.com>

some minor change of comments:
1). update zs_malloc(),zs_create_pool() function header
2). update "Usage of struct page fields"

Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
----
v2:
    change *object index* to *object offset* - Minchan
---
 mm/zsmalloc.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 2c4549e..df804b8 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -20,6 +20,7 @@
  *	page->freelist(index): links together all component pages of a zspage
  *		For the huge page, this is always 0, so we use this field
  *		to store handle.
+ *	page->units: first object offset in a subpage of zspage
  *
  * Usage of struct page flags:
  *	PG_private: identifies the first component page
@@ -140,9 +141,6 @@
  */
 #define ZS_SIZE_CLASS_DELTA	(PAGE_SIZE >> CLASS_BITS)
 
-/*
- * We do not maintain any list for completely empty or full pages
- */
 enum fullness_group {
 	ZS_EMPTY,
 	ZS_ALMOST_EMPTY,
@@ -1535,6 +1533,7 @@ static unsigned long obj_malloc(struct size_class *class,
  * zs_malloc - Allocate block of given size from pool.
  * @pool: pool to allocate from
  * @size: size of block to allocate
+ * @gfp: gfp flags when allocating object
  *
  * On success, handle to the allocated object is returned,
  * otherwise 0.
@@ -2400,7 +2399,7 @@ static int zs_register_shrinker(struct zs_pool *pool)
 
 /**
  * zs_create_pool - Creates an allocation pool to work from.
- * @flags: allocation flags used to allocate pool metadata
+ * @name: pool name to be created
  *
  * This function must be called before anything when using
  * the zsmalloc allocator.
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Ganesh Mahendran <opensource.ganesh@gmail.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, minchan@kernel.org, ngupta@vflare.org,
	sergey.senozhatsky.work@gmail.com, rostedt@goodmis.org,
	mingo@redhat.com, Ganesh Mahendran <opensource.ganesh@gmail.com>
Subject: [PATCH v2 6/8] mm/zsmalloc: keep comments consistent with code
Date: Mon,  4 Jul 2016 14:49:57 +0800	[thread overview]
Message-ID: <1467614999-4326-6-git-send-email-opensource.ganesh@gmail.com> (raw)
In-Reply-To: <1467614999-4326-1-git-send-email-opensource.ganesh@gmail.com>

some minor change of comments:
1). update zs_malloc(),zs_create_pool() function header
2). update "Usage of struct page fields"

Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
----
v2:
    change *object index* to *object offset* - Minchan
---
 mm/zsmalloc.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 2c4549e..df804b8 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -20,6 +20,7 @@
  *	page->freelist(index): links together all component pages of a zspage
  *		For the huge page, this is always 0, so we use this field
  *		to store handle.
+ *	page->units: first object offset in a subpage of zspage
  *
  * Usage of struct page flags:
  *	PG_private: identifies the first component page
@@ -140,9 +141,6 @@
  */
 #define ZS_SIZE_CLASS_DELTA	(PAGE_SIZE >> CLASS_BITS)
 
-/*
- * We do not maintain any list for completely empty or full pages
- */
 enum fullness_group {
 	ZS_EMPTY,
 	ZS_ALMOST_EMPTY,
@@ -1535,6 +1533,7 @@ static unsigned long obj_malloc(struct size_class *class,
  * zs_malloc - Allocate block of given size from pool.
  * @pool: pool to allocate from
  * @size: size of block to allocate
+ * @gfp: gfp flags when allocating object
  *
  * On success, handle to the allocated object is returned,
  * otherwise 0.
@@ -2400,7 +2399,7 @@ static int zs_register_shrinker(struct zs_pool *pool)
 
 /**
  * zs_create_pool - Creates an allocation pool to work from.
- * @flags: allocation flags used to allocate pool metadata
+ * @name: pool name to be created
  *
  * This function must be called before anything when using
  * the zsmalloc allocator.
-- 
1.9.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2016-07-04  6:52 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04  6:49 [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface Ganesh Mahendran
2016-07-04  6:49 ` Ganesh Mahendran
2016-07-04  6:49 ` [PATCH v2 2/8] mm/zsmalloc: use obj_index to keep consistent with others Ganesh Mahendran
2016-07-04  6:49   ` Ganesh Mahendran
2016-07-05  1:25   ` Sergey Senozhatsky
2016-07-05  1:25     ` Sergey Senozhatsky
2016-07-06  2:37   ` Minchan Kim
2016-07-06  2:37     ` Minchan Kim
2016-07-04  6:49 ` [PATCH v2 3/8] mm/zsmalloc: take obj index back from find_alloced_obj Ganesh Mahendran
2016-07-04  6:49   ` Ganesh Mahendran
2016-07-05  1:32   ` Sergey Senozhatsky
2016-07-05  1:32     ` Sergey Senozhatsky
2016-07-06  2:40   ` Minchan Kim
2016-07-06  2:40     ` Minchan Kim
2016-07-04  6:49 ` [PATCH v2 4/8] mm/zsmalloc: use class->objs_per_zspage to get num of max objects Ganesh Mahendran
2016-07-04  6:49   ` Ganesh Mahendran
2016-07-05  1:30   ` Sergey Senozhatsky
2016-07-05  1:30     ` Sergey Senozhatsky
2016-07-04  6:49 ` [PATCH v2 5/8] mm/zsmalloc: avoid calculate max objects of zspage twice Ganesh Mahendran
2016-07-04  6:49   ` Ganesh Mahendran
2016-07-05  1:18   ` Sergey Senozhatsky
2016-07-05  1:18     ` Sergey Senozhatsky
2016-07-06  2:41   ` Minchan Kim
2016-07-06  2:41     ` Minchan Kim
2016-07-04  6:49 ` Ganesh Mahendran [this message]
2016-07-04  6:49   ` [PATCH v2 6/8] mm/zsmalloc: keep comments consistent with code Ganesh Mahendran
2016-07-05  1:11   ` Sergey Senozhatsky
2016-07-05  1:11     ` Sergey Senozhatsky
2016-07-06  2:41   ` Minchan Kim
2016-07-06  2:41     ` Minchan Kim
2016-07-04  6:49 ` [PATCH v2 7/8] mm/zsmalloc: add __init,__exit attribute Ganesh Mahendran
2016-07-04  6:49   ` Ganesh Mahendran
2016-07-04  8:43   ` Sergey Senozhatsky
2016-07-04  8:43     ` Sergey Senozhatsky
2016-07-04  9:21     ` Ganesh Mahendran
2016-07-04  9:21       ` Ganesh Mahendran
2016-07-05  1:00       ` Sergey Senozhatsky
2016-07-05  1:00         ` Sergey Senozhatsky
2016-07-06  2:48         ` Minchan Kim
2016-07-06  2:48           ` Minchan Kim
2016-07-06  6:21           ` Ganesh Mahendran
2016-07-06  6:21             ` Ganesh Mahendran
2016-07-04  6:49 ` [PATCH v2 8/8] mm/zsmalloc: use helper to clear page->flags bit Ganesh Mahendran
2016-07-04  6:49   ` Ganesh Mahendran
2016-07-04  8:45   ` Sergey Senozhatsky
2016-07-04  8:45     ` Sergey Senozhatsky
2016-07-05 16:50 ` [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface Steven Rostedt
2016-07-05 16:50   ` Steven Rostedt
2016-07-06  2:32 ` Minchan Kim
2016-07-06  2:32   ` Minchan Kim
2016-07-06  6:20   ` Ganesh Mahendran
2016-07-06  6:20     ` Ganesh Mahendran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467614999-4326-6-git-send-email-opensource.ganesh@gmail.com \
    --to=opensource.ganesh@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=mingo@redhat.com \
    --cc=ngupta@vflare.org \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.