From: Steven Rostedt <rostedt@goodmis.org>
To: Ganesh Mahendran <opensource.ganesh@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, minchan@kernel.org, ngupta@vflare.org,
sergey.senozhatsky.work@gmail.com, mingo@redhat.com
Subject: Re: [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface
Date: Tue, 5 Jul 2016 12:50:54 -0400 [thread overview]
Message-ID: <20160705125054.09c5b93e@gandalf.local.home> (raw)
In-Reply-To: <1467614999-4326-1-git-send-email-opensource.ganesh@gmail.com>
On Mon, 4 Jul 2016 14:49:52 +0800
Ganesh Mahendran <opensource.ganesh@gmail.com> wrote:
> This patch changes trace_zsmalloc_compact_start[end] to
> trace_zs_compact_start[end] to keep function naming consistent
> with others in zsmalloc
>
> Also this patch remove pages_total_compacted information which
> may not really needed.
>
> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
This looks fine to me, as long as the zs maintainers are OK with the
tracepoint changes (it is visible from user space).
-- Steve
WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org>
To: Ganesh Mahendran <opensource.ganesh@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, minchan@kernel.org, ngupta@vflare.org,
sergey.senozhatsky.work@gmail.com, mingo@redhat.com
Subject: Re: [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface
Date: Tue, 5 Jul 2016 12:50:54 -0400 [thread overview]
Message-ID: <20160705125054.09c5b93e@gandalf.local.home> (raw)
In-Reply-To: <1467614999-4326-1-git-send-email-opensource.ganesh@gmail.com>
On Mon, 4 Jul 2016 14:49:52 +0800
Ganesh Mahendran <opensource.ganesh@gmail.com> wrote:
> This patch changes trace_zsmalloc_compact_start[end] to
> trace_zs_compact_start[end] to keep function naming consistent
> with others in zsmalloc
>
> Also this patch remove pages_total_compacted information which
> may not really needed.
>
> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
This looks fine to me, as long as the zs maintainers are OK with the
tracepoint changes (it is visible from user space).
-- Steve
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-07-05 16:51 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 6:49 [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface Ganesh Mahendran
2016-07-04 6:49 ` Ganesh Mahendran
2016-07-04 6:49 ` [PATCH v2 2/8] mm/zsmalloc: use obj_index to keep consistent with others Ganesh Mahendran
2016-07-04 6:49 ` Ganesh Mahendran
2016-07-05 1:25 ` Sergey Senozhatsky
2016-07-05 1:25 ` Sergey Senozhatsky
2016-07-06 2:37 ` Minchan Kim
2016-07-06 2:37 ` Minchan Kim
2016-07-04 6:49 ` [PATCH v2 3/8] mm/zsmalloc: take obj index back from find_alloced_obj Ganesh Mahendran
2016-07-04 6:49 ` Ganesh Mahendran
2016-07-05 1:32 ` Sergey Senozhatsky
2016-07-05 1:32 ` Sergey Senozhatsky
2016-07-06 2:40 ` Minchan Kim
2016-07-06 2:40 ` Minchan Kim
2016-07-04 6:49 ` [PATCH v2 4/8] mm/zsmalloc: use class->objs_per_zspage to get num of max objects Ganesh Mahendran
2016-07-04 6:49 ` Ganesh Mahendran
2016-07-05 1:30 ` Sergey Senozhatsky
2016-07-05 1:30 ` Sergey Senozhatsky
2016-07-04 6:49 ` [PATCH v2 5/8] mm/zsmalloc: avoid calculate max objects of zspage twice Ganesh Mahendran
2016-07-04 6:49 ` Ganesh Mahendran
2016-07-05 1:18 ` Sergey Senozhatsky
2016-07-05 1:18 ` Sergey Senozhatsky
2016-07-06 2:41 ` Minchan Kim
2016-07-06 2:41 ` Minchan Kim
2016-07-04 6:49 ` [PATCH v2 6/8] mm/zsmalloc: keep comments consistent with code Ganesh Mahendran
2016-07-04 6:49 ` Ganesh Mahendran
2016-07-05 1:11 ` Sergey Senozhatsky
2016-07-05 1:11 ` Sergey Senozhatsky
2016-07-06 2:41 ` Minchan Kim
2016-07-06 2:41 ` Minchan Kim
2016-07-04 6:49 ` [PATCH v2 7/8] mm/zsmalloc: add __init,__exit attribute Ganesh Mahendran
2016-07-04 6:49 ` Ganesh Mahendran
2016-07-04 8:43 ` Sergey Senozhatsky
2016-07-04 8:43 ` Sergey Senozhatsky
2016-07-04 9:21 ` Ganesh Mahendran
2016-07-04 9:21 ` Ganesh Mahendran
2016-07-05 1:00 ` Sergey Senozhatsky
2016-07-05 1:00 ` Sergey Senozhatsky
2016-07-06 2:48 ` Minchan Kim
2016-07-06 2:48 ` Minchan Kim
2016-07-06 6:21 ` Ganesh Mahendran
2016-07-06 6:21 ` Ganesh Mahendran
2016-07-04 6:49 ` [PATCH v2 8/8] mm/zsmalloc: use helper to clear page->flags bit Ganesh Mahendran
2016-07-04 6:49 ` Ganesh Mahendran
2016-07-04 8:45 ` Sergey Senozhatsky
2016-07-04 8:45 ` Sergey Senozhatsky
2016-07-05 16:50 ` Steven Rostedt [this message]
2016-07-05 16:50 ` [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface Steven Rostedt
2016-07-06 2:32 ` Minchan Kim
2016-07-06 2:32 ` Minchan Kim
2016-07-06 6:20 ` Ganesh Mahendran
2016-07-06 6:20 ` Ganesh Mahendran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705125054.09c5b93e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=ngupta@vflare.org \
--cc=opensource.ganesh@gmail.com \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.