[PATCH rdma-next] IB/rxe: Trivial coding style fix

[PATCH rdma-next] IB/rxe: Trivial coding style fix

[Moni Shoua]

A line was unnecessarily broken and with bad indentation.
Also, unnecessary braces were removed.

Fixes: 99c483da1a82 ('IB/rxe: QP request handling')
Signed-off-by: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 drivers/infiniband/hw/rxe/rxe_req.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/hw/rxe/rxe_req.c b/drivers/infiniband/hw/rxe/rxe_req.c
index e945967..f78efa6 100644
--- a/drivers/infiniband/hw/rxe/rxe_req.c
+++ b/drivers/infiniband/hw/rxe/rxe_req.c
@@ -547,10 +547,8 @@ static void update_state(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
 	qp->req.opcode = pkt->opcode;
 
 
-	if (pkt->mask & RXE_END_MASK) {
-		qp->req.wqe_index = next_index(qp->sq.queue,
-									   qp->req.wqe_index);
-	}
+	if (pkt->mask & RXE_END_MASK)
+		qp->req.wqe_index = next_index(qp->sq.queue, qp->req.wqe_index);
 
 	qp->need_req_skb = 0;
 
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-next] IB/rxe: Trivial coding style fix

[Or Gerlitz]

On Tue, Jul 5, 2016 at 7:09 PM, Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> wrote:
> A line was unnecessarily broken and with bad indentation.
> Also, unnecessary braces were removed.
>
> Fixes: 99c483da1a82 ('IB/rxe: QP request handling')

Doug, is this commit ID gonna persist when you merge RXE to your
for-4.8 branch and later when Linus pulls this? if not, no point to
use it here, in that case, Moni, please remove it.

> Signed-off-by: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-next] IB/rxe: Trivial coding style fix

[Moni Shoua]

On Wed, Jul 6, 2016 at 12:52 AM, Or Gerlitz <gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Tue, Jul 5, 2016 at 7:09 PM, Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> wrote:
>> A line was unnecessarily broken and with bad indentation.
>> Also, unnecessary braces were removed.
>>
>> Fixes: 99c483da1a82 ('IB/rxe: QP request handling')
>
> Doug, is this commit ID gonna persist when you merge RXE to your
> for-4.8 branch and later when Linus pulls this? if not, no point to
> use it here, in that case, Moni, please remove it.
>

You are right Or.
I added the "Fixes" line to help Doug decide which patch to squash to
in case he decides to do that.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-next] IB/rxe: Trivial coding style fix

[Doug Ledford]

[-- Attachment #1.1: Type: text/plain, Size: 885 bytes --]

On 7/6/2016 3:16 AM, Moni Shoua wrote:
> On Wed, Jul 6, 2016 at 12:52 AM, Or Gerlitz <gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On Tue, Jul 5, 2016 at 7:09 PM, Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> wrote:
>>> A line was unnecessarily broken and with bad indentation.
>>> Also, unnecessary braces were removed.
>>>
>>> Fixes: 99c483da1a82 ('IB/rxe: QP request handling')
>>
>> Doug, is this commit ID gonna persist when you merge RXE to your
>> for-4.8 branch and later when Linus pulls this? if not, no point to
>> use it here, in that case, Moni, please remove it.
>>
> 
> You are right Or.
> I added the "Fixes" line to help Doug decide which patch to squash to
> in case he decides to do that.
> 


Applied and squashed.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG Key ID: 0E572FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]