* [PATCH rdma-next] IB/rxe: Trivial coding style fix @ 2016-07-05 16:09 Moni Shoua [not found] ` <1467734999-21389-1-git-send-email-monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Moni Shoua @ 2016-07-05 16:09 UTC (permalink / raw) To: dledford-H+wXaHxf7aLQT0dZR+AlfA Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, matanb-VPRAkNaXOzVWk0Htik3J/w, talal-VPRAkNaXOzVWk0Htik3J/w, leonro-VPRAkNaXOzVWk0Htik3J/w, majd-VPRAkNaXOzVWk0Htik3J/w, Moni Shoua A line was unnecessarily broken and with bad indentation. Also, unnecessary braces were removed. Fixes: 99c483da1a82 ('IB/rxe: QP request handling') Signed-off-by: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> --- drivers/infiniband/hw/rxe/rxe_req.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/rxe/rxe_req.c b/drivers/infiniband/hw/rxe/rxe_req.c index e945967..f78efa6 100644 --- a/drivers/infiniband/hw/rxe/rxe_req.c +++ b/drivers/infiniband/hw/rxe/rxe_req.c @@ -547,10 +547,8 @@ static void update_state(struct rxe_qp *qp, struct rxe_send_wqe *wqe, qp->req.opcode = pkt->opcode; - if (pkt->mask & RXE_END_MASK) { - qp->req.wqe_index = next_index(qp->sq.queue, - qp->req.wqe_index); - } + if (pkt->mask & RXE_END_MASK) + qp->req.wqe_index = next_index(qp->sq.queue, qp->req.wqe_index); qp->need_req_skb = 0; -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <1467734999-21389-1-git-send-email-monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]
* Re: [PATCH rdma-next] IB/rxe: Trivial coding style fix [not found] ` <1467734999-21389-1-git-send-email-monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> @ 2016-07-05 21:52 ` Or Gerlitz [not found] ` <CAJ3xEMggNphYbmSRE_Ffdjmnqf2rDnVZF8k+7vhP3RqeR2EEbg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Or Gerlitz @ 2016-07-05 21:52 UTC (permalink / raw) To: Moni Shoua Cc: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA, Matan Barak, talal-VPRAkNaXOzVWk0Htik3J/w, Leon Romanovsky, Majd Dibbiny On Tue, Jul 5, 2016 at 7:09 PM, Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> wrote: > A line was unnecessarily broken and with bad indentation. > Also, unnecessary braces were removed. > > Fixes: 99c483da1a82 ('IB/rxe: QP request handling') Doug, is this commit ID gonna persist when you merge RXE to your for-4.8 branch and later when Linus pulls this? if not, no point to use it here, in that case, Moni, please remove it. > Signed-off-by: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <CAJ3xEMggNphYbmSRE_Ffdjmnqf2rDnVZF8k+7vhP3RqeR2EEbg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH rdma-next] IB/rxe: Trivial coding style fix [not found] ` <CAJ3xEMggNphYbmSRE_Ffdjmnqf2rDnVZF8k+7vhP3RqeR2EEbg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2016-07-06 7:16 ` Moni Shoua [not found] ` <CAG9sBKO64o-Ynjvy5PqRhDeUmeXonLXH9mHE+_0SmBu2GpE0-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Moni Shoua @ 2016-07-06 7:16 UTC (permalink / raw) To: Or Gerlitz Cc: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA, Matan Barak, talal-VPRAkNaXOzVWk0Htik3J/w, Leon Romanovsky, Majd Dibbiny On Wed, Jul 6, 2016 at 12:52 AM, Or Gerlitz <gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > On Tue, Jul 5, 2016 at 7:09 PM, Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> wrote: >> A line was unnecessarily broken and with bad indentation. >> Also, unnecessary braces were removed. >> >> Fixes: 99c483da1a82 ('IB/rxe: QP request handling') > > Doug, is this commit ID gonna persist when you merge RXE to your > for-4.8 branch and later when Linus pulls this? if not, no point to > use it here, in that case, Moni, please remove it. > You are right Or. I added the "Fixes" line to help Doug decide which patch to squash to in case he decides to do that. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <CAG9sBKO64o-Ynjvy5PqRhDeUmeXonLXH9mHE+_0SmBu2GpE0-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH rdma-next] IB/rxe: Trivial coding style fix [not found] ` <CAG9sBKO64o-Ynjvy5PqRhDeUmeXonLXH9mHE+_0SmBu2GpE0-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2016-07-12 14:55 ` Doug Ledford 0 siblings, 0 replies; 4+ messages in thread From: Doug Ledford @ 2016-07-12 14:55 UTC (permalink / raw) To: Moni Shoua, Or Gerlitz Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Matan Barak, talal-VPRAkNaXOzVWk0Htik3J/w, Leon Romanovsky, Majd Dibbiny [-- Attachment #1.1: Type: text/plain, Size: 885 bytes --] On 7/6/2016 3:16 AM, Moni Shoua wrote: > On Wed, Jul 6, 2016 at 12:52 AM, Or Gerlitz <gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: >> On Tue, Jul 5, 2016 at 7:09 PM, Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> wrote: >>> A line was unnecessarily broken and with bad indentation. >>> Also, unnecessary braces were removed. >>> >>> Fixes: 99c483da1a82 ('IB/rxe: QP request handling') >> >> Doug, is this commit ID gonna persist when you merge RXE to your >> for-4.8 branch and later when Linus pulls this? if not, no point to >> use it here, in that case, Moni, please remove it. >> > > You are right Or. > I added the "Fixes" line to help Doug decide which patch to squash to > in case he decides to do that. > Applied and squashed. -- Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> GPG Key ID: 0E572FDD [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 884 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-12 14:55 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-07-05 16:09 [PATCH rdma-next] IB/rxe: Trivial coding style fix Moni Shoua [not found] ` <1467734999-21389-1-git-send-email-monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> 2016-07-05 21:52 ` Or Gerlitz [not found] ` <CAJ3xEMggNphYbmSRE_Ffdjmnqf2rDnVZF8k+7vhP3RqeR2EEbg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-07-06 7:16 ` Moni Shoua [not found] ` <CAG9sBKO64o-Ynjvy5PqRhDeUmeXonLXH9mHE+_0SmBu2GpE0-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-07-12 14:55 ` Doug Ledford
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.