* [PATCH v4 1/4] mfd: Add DT bindings documentation for Samsung Exynos LPASS
@ 2016-07-05 17:13 ` Sylwester Nawrocki
0 siblings, 0 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2016-07-05 17:13 UTC (permalink / raw)
To: lee.jones
Cc: broonie, robh, alsa-devel, devicetree, ideal.song, inki.dae,
b.zolnierkie, linux-samsung-soc, linux-kernel,
Sylwester Nawrocki
This patch adds documentation of the DT bindings for the Samsung
Exynos SoC Low Power Audio Subsystem.
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
There were few rather significant additions since v3 and I had to drop tags:
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Changes since v3:
- moved to Documentation/devicetree/bindings/mfd,
- added #address-cells, #size-cells, ranges as required
properties,
- added description of the IP block subnodes and links
to their binding's documentation.
Changes since v2:
- none.
---
.../bindings/mfd/samsung,exynos5433-lpass.txt | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
new file mode 100644
index 0000000..7e97c0d
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
@@ -0,0 +1,21 @@
+
+Samsung Exynos SoC Low Power Audio Subsystem (LPASS)
+
+Required properties:
+
+ - compatible : "samsung,exynos5433-lpass"
+ - reg : should contain the LPASS top SFR region location and size
+ - samsung,pmu-syscon : the phandle to the Power Management Unit node
+ - #address-cells: should be 1
+ - #size-cells: should be 1
+ - ranges: must be present
+
+Each IP block of the Low Power Audio Subsystem should be specified
+as an optional sub-node. For "samsung,exynos5433-lpass" compatible
+this includes: UART, SLIMBUS, PCM, I2S, DMAC, Timers 0...4, WDT 0...1
+devices.
+
+Bindings of the sub-nodes are described in:
+ Documentation/devicetree/bindings/serial/samsung_uart.txt
+ Documentation/devicetree/bindings/sound/samsung-i2s.txt
+ Documentation/devicetree/bindings/dma/arm-pl330.txt
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v4 1/4] mfd: Add DT bindings documentation for Samsung Exynos LPASS
@ 2016-07-05 17:13 ` Sylwester Nawrocki
0 siblings, 0 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2016-07-05 17:13 UTC (permalink / raw)
To: lee.jones-QSEj5FYQhm4dnm+yROfE0A
Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A, robh-DgEjT+Ai2ygdnm+yROfE0A,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
devicetree-u79uwXL29TY76Z2rM5mHXA,
ideal.song-Sze3O3UU22JBDgjK7y7TUQ,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Sylwester Nawrocki
This patch adds documentation of the DT bindings for the Samsung
Exynos SoC Low Power Audio Subsystem.
Signed-off-by: Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
There were few rather significant additions since v3 and I had to drop tags:
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Acked-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Changes since v3:
- moved to Documentation/devicetree/bindings/mfd,
- added #address-cells, #size-cells, ranges as required
properties,
- added description of the IP block subnodes and links
to their binding's documentation.
Changes since v2:
- none.
---
.../bindings/mfd/samsung,exynos5433-lpass.txt | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
new file mode 100644
index 0000000..7e97c0d
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
@@ -0,0 +1,21 @@
+
+Samsung Exynos SoC Low Power Audio Subsystem (LPASS)
+
+Required properties:
+
+ - compatible : "samsung,exynos5433-lpass"
+ - reg : should contain the LPASS top SFR region location and size
+ - samsung,pmu-syscon : the phandle to the Power Management Unit node
+ - #address-cells: should be 1
+ - #size-cells: should be 1
+ - ranges: must be present
+
+Each IP block of the Low Power Audio Subsystem should be specified
+as an optional sub-node. For "samsung,exynos5433-lpass" compatible
+this includes: UART, SLIMBUS, PCM, I2S, DMAC, Timers 0...4, WDT 0...1
+devices.
+
+Bindings of the sub-nodes are described in:
+ Documentation/devicetree/bindings/serial/samsung_uart.txt
+ Documentation/devicetree/bindings/sound/samsung-i2s.txt
+ Documentation/devicetree/bindings/dma/arm-pl330.txt
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4 1/4] mfd: Add DT bindings documentation for Samsung Exynos LPASS
2016-07-05 17:13 ` Sylwester Nawrocki
(?)
@ 2016-07-11 14:32 ` Rob Herring
-1 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2016-07-11 14:32 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: lee.jones, broonie, alsa-devel, devicetree, ideal.song, inki.dae,
b.zolnierkie, linux-samsung-soc, linux-kernel
On Tue, Jul 05, 2016 at 07:13:05PM +0200, Sylwester Nawrocki wrote:
> This patch adds documentation of the DT bindings for the Samsung
> Exynos SoC Low Power Audio Subsystem.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>
> There were few rather significant additions since v3 and I had to drop tags:
> Acked-by: Rob Herring <robh@kernel.org>
> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Changes since v3:
> - moved to Documentation/devicetree/bindings/mfd,
> - added #address-cells, #size-cells, ranges as required
> properties,
> - added description of the IP block subnodes and links
> to their binding's documentation.
>
> Changes since v2:
> - none.
> ---
> .../bindings/mfd/samsung,exynos5433-lpass.txt | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 1/4] mfd: Add DT bindings documentation for Samsung Exynos LPASS
2016-07-05 17:13 ` Sylwester Nawrocki
(?)
(?)
@ 2016-08-05 13:36 ` Lee Jones
2016-08-05 15:44 ` Sylwester Nawrocki
-1 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2016-08-05 13:36 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: broonie, robh, alsa-devel, devicetree, ideal.song, inki.dae,
b.zolnierkie, linux-samsung-soc, linux-kernel
On Tue, 05 Jul 2016, Sylwester Nawrocki wrote:
> This patch adds documentation of the DT bindings for the Samsung
> Exynos SoC Low Power Audio Subsystem.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>
> There were few rather significant additions since v3 and I had to drop tags:
> Acked-by: Rob Herring <robh@kernel.org>
> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Changes since v3:
> - moved to Documentation/devicetree/bindings/mfd,
> - added #address-cells, #size-cells, ranges as required
> properties,
> - added description of the IP block subnodes and links
> to their binding's documentation.
>
> Changes since v2:
> - none.
> ---
> .../bindings/mfd/samsung,exynos5433-lpass.txt | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
> new file mode 100644
> index 0000000..7e97c0d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
> @@ -0,0 +1,21 @@
> +
Nit: This line is superfluous.
> +Samsung Exynos SoC Low Power Audio Subsystem (LPASS)
> +
> +Required properties:
> +
> + - compatible : "samsung,exynos5433-lpass"
> + - reg : should contain the LPASS top SFR region location and size
> + - samsung,pmu-syscon : the phandle to the Power Management Unit node
> + - #address-cells: should be 1
> + - #size-cells: should be 1
> + - ranges: must be present
These look so much better like:
- compatible : "samsung,exynos5433-lpass"
- reg : should contain the LPASS top SFR region location and size
- samsung,pmu-syscon : the phandle to the Power Management Unit node
- #address-cells : should be 1
- #size-cells : should be 1
- ranges : must be present
> +Each IP block of the Low Power Audio Subsystem should be specified
> +as an optional sub-node. For "samsung,exynos5433-lpass" compatible
> +this includes: UART, SLIMBUS, PCM, I2S, DMAC, Timers 0...4, WDT 0...1
> +devices.
> +
> +Bindings of the sub-nodes are described in:
> + Documentation/devicetree/bindings/serial/samsung_uart.txt
> + Documentation/devicetree/bindings/sound/samsung-i2s.txt
> + Documentation/devicetree/bindings/dma/arm-pl330.txt
Use relative path names:
../serial/samsung_uart.txt
../sound/samsung-i2s.txt
../dma/arm-pl330.txt
Missing example?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 1/4] mfd: Add DT bindings documentation for Samsung Exynos LPASS
2016-08-05 13:36 ` Lee Jones
@ 2016-08-05 15:44 ` Sylwester Nawrocki
0 siblings, 0 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2016-08-05 15:44 UTC (permalink / raw)
To: Lee Jones
Cc: broonie, robh, alsa-devel, devicetree, ideal.song, inki.dae,
b.zolnierkie, linux-samsung-soc, linux-kernel
On 08/05/2016 03:36 PM, Lee Jones wrote:
> On Tue, 05 Jul 2016, Sylwester Nawrocki wrote:
>
>> This patch adds documentation of the DT bindings for the Samsung
>> Exynos SoC Low Power Audio Subsystem.
>>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> new file mode 100644
>> index 0000000..7e97c0d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
>> @@ -0,0 +1,21 @@
>> +
>
> Nit: This line is superfluous.
>
>> +Samsung Exynos SoC Low Power Audio Subsystem (LPASS)
>> +
>> +Required properties:
>> +
>> + - compatible : "samsung,exynos5433-lpass"
>> + - reg : should contain the LPASS top SFR region location and size
>> + - samsung,pmu-syscon : the phandle to the Power Management Unit node
>> + - #address-cells: should be 1
>> + - #size-cells: should be 1
>> + - ranges: must be present
>
> These look so much better like:
>
> - compatible : "samsung,exynos5433-lpass"
> - reg : should contain the LPASS top SFR region location and size
> - samsung,pmu-syscon : the phandle to the Power Management Unit node
> - #address-cells : should be 1
> - #size-cells : should be 1
> - ranges : must be present
OK, will rewrite it this way.
>> +Each IP block of the Low Power Audio Subsystem should be specified
>> +as an optional sub-node. For "samsung,exynos5433-lpass" compatible
>> +this includes: UART, SLIMBUS, PCM, I2S, DMAC, Timers 0...4, WDT 0...1
>> +devices.
>> +
>> +Bindings of the sub-nodes are described in:
>> + Documentation/devicetree/bindings/serial/samsung_uart.txt
>> + Documentation/devicetree/bindings/sound/samsung-i2s.txt
>> + Documentation/devicetree/bindings/dma/arm-pl330.txt
>
> Use relative path names:
>
> ../serial/samsung_uart.txt
> ../sound/samsung-i2s.txt
> ../dma/arm-pl330.txt
OK, actually I had it this way in one of the versions but somehow
with full paths it appeared better to me.
> Missing example?
Yes, omitted deliberately as that appeared quite many more lines
with fully specified subnodes. Perhaps I will add it with omitted
all properties of the subnodes but compatible.
audio-subsystem {
compatible = "samsung,exynos5433-lpass";
reg = <0x11400000 0x100>, <0x11500000 0x08>;
samsung,pmu-syscon = <&pmu_system_controller>;
#address-cells = <1>;
#size-cells = <1>;
ranges;
adma: adma@11420000 {
compatible = "arm,pl330", "arm,primecell";
reg = <0x11420000 0x1000>;
interrupts = <0 73 0>;
clocks = <&cmu_aud CLK_ACLK_DMAC>;
clock-names = "apb_pclk";
#dma-cells = <1>;
#dma-channels = <8>;
#dma-requests = <32>;
};
i2s0: i2s0@11440000 {
compatible = "samsung,exynos7-i2s";
reg = <0x11440000 0x100>;
dmas = <&adma 0 &adma 2>;
dma-names = "tx", "rx";
interrupts = <0 70 0>;
clocks = <&cmu_aud CLK_PCLK_AUD_I2S>,
<&cmu_aud CLK_SCLK_AUD_I2S>,
<&cmu_aud CLK_SCLK_I2S_BCLK>;
clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
pinctrl-names = "default";
pinctrl-0 = <&i2s0_bus>;
status = "disabled";
};
serial_3: serial@11460000 {
compatible = "samsung,exynos5433-uart";
reg = <0x11460000 0x100>;
interrupts = <0 67 0>;
clocks = <&cmu_aud CLK_PCLK_AUD_UART>,
<&cmu_aud CLK_SCLK_AUD_UART>;
clock-names = "uart", "clk_uart_baud0";
pinctrl-names = "default";
pinctrl-0 = <&uart_aud_bus>;
status = "disabled";
};
};
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 1/4] mfd: Add DT bindings documentation for Samsung Exynos LPASS
@ 2016-08-05 15:44 ` Sylwester Nawrocki
0 siblings, 0 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2016-08-05 15:44 UTC (permalink / raw)
To: Lee Jones
Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A, robh-DgEjT+Ai2ygdnm+yROfE0A,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
devicetree-u79uwXL29TY76Z2rM5mHXA,
ideal.song-Sze3O3UU22JBDgjK7y7TUQ,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On 08/05/2016 03:36 PM, Lee Jones wrote:
> On Tue, 05 Jul 2016, Sylwester Nawrocki wrote:
>
>> This patch adds documentation of the DT bindings for the Samsung
>> Exynos SoC Low Power Audio Subsystem.
>>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>> new file mode 100644
>> index 0000000..7e97c0d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
>> @@ -0,0 +1,21 @@
>> +
>
> Nit: This line is superfluous.
>
>> +Samsung Exynos SoC Low Power Audio Subsystem (LPASS)
>> +
>> +Required properties:
>> +
>> + - compatible : "samsung,exynos5433-lpass"
>> + - reg : should contain the LPASS top SFR region location and size
>> + - samsung,pmu-syscon : the phandle to the Power Management Unit node
>> + - #address-cells: should be 1
>> + - #size-cells: should be 1
>> + - ranges: must be present
>
> These look so much better like:
>
> - compatible : "samsung,exynos5433-lpass"
> - reg : should contain the LPASS top SFR region location and size
> - samsung,pmu-syscon : the phandle to the Power Management Unit node
> - #address-cells : should be 1
> - #size-cells : should be 1
> - ranges : must be present
OK, will rewrite it this way.
>> +Each IP block of the Low Power Audio Subsystem should be specified
>> +as an optional sub-node. For "samsung,exynos5433-lpass" compatible
>> +this includes: UART, SLIMBUS, PCM, I2S, DMAC, Timers 0...4, WDT 0...1
>> +devices.
>> +
>> +Bindings of the sub-nodes are described in:
>> + Documentation/devicetree/bindings/serial/samsung_uart.txt
>> + Documentation/devicetree/bindings/sound/samsung-i2s.txt
>> + Documentation/devicetree/bindings/dma/arm-pl330.txt
>
> Use relative path names:
>
> ../serial/samsung_uart.txt
> ../sound/samsung-i2s.txt
> ../dma/arm-pl330.txt
OK, actually I had it this way in one of the versions but somehow
with full paths it appeared better to me.
> Missing example?
Yes, omitted deliberately as that appeared quite many more lines
with fully specified subnodes. Perhaps I will add it with omitted
all properties of the subnodes but compatible.
audio-subsystem {
compatible = "samsung,exynos5433-lpass";
reg = <0x11400000 0x100>, <0x11500000 0x08>;
samsung,pmu-syscon = <&pmu_system_controller>;
#address-cells = <1>;
#size-cells = <1>;
ranges;
adma: adma@11420000 {
compatible = "arm,pl330", "arm,primecell";
reg = <0x11420000 0x1000>;
interrupts = <0 73 0>;
clocks = <&cmu_aud CLK_ACLK_DMAC>;
clock-names = "apb_pclk";
#dma-cells = <1>;
#dma-channels = <8>;
#dma-requests = <32>;
};
i2s0: i2s0@11440000 {
compatible = "samsung,exynos7-i2s";
reg = <0x11440000 0x100>;
dmas = <&adma 0 &adma 2>;
dma-names = "tx", "rx";
interrupts = <0 70 0>;
clocks = <&cmu_aud CLK_PCLK_AUD_I2S>,
<&cmu_aud CLK_SCLK_AUD_I2S>,
<&cmu_aud CLK_SCLK_I2S_BCLK>;
clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
pinctrl-names = "default";
pinctrl-0 = <&i2s0_bus>;
status = "disabled";
};
serial_3: serial@11460000 {
compatible = "samsung,exynos5433-uart";
reg = <0x11460000 0x100>;
interrupts = <0 67 0>;
clocks = <&cmu_aud CLK_PCLK_AUD_UART>,
<&cmu_aud CLK_SCLK_AUD_UART>;
clock-names = "uart", "clk_uart_baud0";
pinctrl-names = "default";
pinctrl-0 = <&uart_aud_bus>;
status = "disabled";
};
};
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-05 15:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-05 17:13 [PATCH v4 1/4] mfd: Add DT bindings documentation for Samsung Exynos LPASS Sylwester Nawrocki
2016-07-05 17:13 ` Sylwester Nawrocki
2016-07-11 14:32 ` Rob Herring
2016-08-05 13:36 ` Lee Jones
2016-08-05 15:44 ` Sylwester Nawrocki
2016-08-05 15:44 ` Sylwester Nawrocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.