All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
To: Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 7/9] ARM: dts: sun7i: bananapi-m1-plus: red LED is power LED
Date: Wed,  6 Jul 2016 17:10:48 +0800	[thread overview]
Message-ID: <1467796250-22010-8-git-send-email-wens@csie.org> (raw)
In-Reply-To: <1467796250-22010-1-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>

The red led on the Bananapi M1+ is wired to light up as soon as the
board is powered, and continues to be lit while the GPIO is floating.

Rename the LED to "pwr", remove the default trigger, and mark it as
default on.

Also fix the pinmux node that was specifying a different pin for this
LED.

Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
---
 arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
index 14fb463758e4..ba5bca0fe997 100644
--- a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
+++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
@@ -70,12 +70,11 @@
 			gpios = <&pio 7 24 GPIO_ACTIVE_HIGH>;
 		};
 
-		red {
-			label = "bananapi-m1-plus:red:usr";
+		pwr {
+			label = "bananapi-m1-plus:pwr:usr";
 			gpios = <&pio 7 25 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger = "default-on";
+			default-state = "on";
 		};
-
 	};
 
 	mmc3_pwrseq: mmc3_pwrseq {
@@ -202,7 +201,7 @@
 	};
 
 	led_pins_bpi_m1p: led_pins@0 {
-		allwinner,pins = "PH24", "PG2";
+		allwinner,pins = "PH24", "PH25";
 		allwinner,function = "gpio_out";
 		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
 		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
-- 
2.8.1

WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/9] ARM: dts: sun7i: bananapi-m1-plus: red LED is power LED
Date: Wed,  6 Jul 2016 17:10:48 +0800	[thread overview]
Message-ID: <1467796250-22010-8-git-send-email-wens@csie.org> (raw)
In-Reply-To: <1467796250-22010-1-git-send-email-wens@csie.org>

The red led on the Bananapi M1+ is wired to light up as soon as the
board is powered, and continues to be lit while the GPIO is floating.

Rename the LED to "pwr", remove the default trigger, and mark it as
default on.

Also fix the pinmux node that was specifying a different pin for this
LED.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
index 14fb463758e4..ba5bca0fe997 100644
--- a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
+++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
@@ -70,12 +70,11 @@
 			gpios = <&pio 7 24 GPIO_ACTIVE_HIGH>;
 		};
 
-		red {
-			label = "bananapi-m1-plus:red:usr";
+		pwr {
+			label = "bananapi-m1-plus:pwr:usr";
 			gpios = <&pio 7 25 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger = "default-on";
+			default-state = "on";
 		};
-
 	};
 
 	mmc3_pwrseq: mmc3_pwrseq {
@@ -202,7 +201,7 @@
 	};
 
 	led_pins_bpi_m1p: led_pins at 0 {
-		allwinner,pins = "PH24", "PG2";
+		allwinner,pins = "PH24", "PH25";
 		allwinner,function = "gpio_out";
 		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
 		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
-- 
2.8.1

  parent reply	other threads:[~2016-07-06  9:10 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-06  9:10 [PATCH 0/9] ARM: dts: sun7i: BPI-M1+ and Lamobo-R1 fixes Chen-Yu Tsai
2016-07-06  9:10 ` Chen-Yu Tsai
     [not found] ` <1467796250-22010-1-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2016-07-06  9:10   ` [PATCH 1/9] ARM: dts: sun7i: lamobo-r1: Fix USB-based WiFi module power Chen-Yu Tsai
2016-07-06  9:10     ` Chen-Yu Tsai
2016-07-06  9:10   ` [PATCH 2/9] ARM: dts: sun7i: lamobo-r1: Remove usb1 vbus regulator Chen-Yu Tsai
2016-07-06  9:10     ` Chen-Yu Tsai
2016-07-06  9:10   ` [PATCH 3/9] ARM: dts: sun7i: lamobo-r1: Fix GPIO flags in reg_ahci_5v Chen-Yu Tsai
2016-07-06  9:10     ` Chen-Yu Tsai
2016-07-06  9:10   ` [PATCH 4/9] ARM: dts: sun7i: lamobo-r1: Enable audio codec Chen-Yu Tsai
2016-07-06  9:10     ` Chen-Yu Tsai
2016-07-06  9:10   ` [PATCH 5/9] ARM: dts: sun7i: bananapi-m1-plus: Reindent whole file using tabs Chen-Yu Tsai
2016-07-06  9:10     ` Chen-Yu Tsai
2016-07-06  9:10   ` [PATCH 6/9] ARM: dts: sun7i: bananapi-m1-plus: Unify suffix for board specific labels Chen-Yu Tsai
2016-07-06  9:10     ` Chen-Yu Tsai
2016-07-06  9:10   ` Chen-Yu Tsai [this message]
2016-07-06  9:10     ` [PATCH 7/9] ARM: dts: sun7i: bananapi-m1-plus: red LED is power LED Chen-Yu Tsai
2016-07-06  9:10   ` [PATCH 8/9] ARM: dts: sun7i: bananapi-m1-plus: Add PMIC regulators and OPPs for cpufreq Chen-Yu Tsai
2016-07-06  9:10     ` Chen-Yu Tsai
     [not found]     ` <1467796250-22010-9-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2016-07-09  8:18       ` Maxime Ripard
2016-07-09  8:18         ` Maxime Ripard
2016-07-12  2:12         ` Chen-Yu Tsai
2016-07-12  2:12           ` Chen-Yu Tsai
2016-07-06  9:10   ` [PATCH 9/9] ARM: dts: sun7i: bananapi-m1-plus: Enable USB OTG Chen-Yu Tsai
2016-07-06  9:10     ` Chen-Yu Tsai
2016-11-20 22:09   ` [PATCH 0/9] ARM: dts: sun7i: BPI-M1+ and Lamobo-R1 fixes Richard Kojedzinszky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467796250-22010-8-git-send-email-wens@csie.org \
    --to=wens-jday2fn1rrm@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.