Re: [PATCH -v3.1 1/2] ratelimit: Extend to print suppressed messages on release

From: Joe Perches <joe@perches.com>
To: Borislav Petkov <bp@alien8.de>, LKML <linux-kernel@vger.kernel.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Franck Bui" <fbui@suse.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH -v3.1 1/2] ratelimit: Extend to print suppressed messages on release
Date: Wed, 06 Jul 2016 07:50:41 -0700	[thread overview]
Message-ID: <1467816641.8360.18.camel@perches.com> (raw)
In-Reply-To: <20160706132800.GD7300@pd.tnic>

On Wed, 2016-07-06 at 15:28 +0200, Borislav Petkov wrote:
> Extend the ratelimiting facility to print the amount of suppressed lines
> when it is being released.
[]
> diff --git a/include/linux/ratelimit.h b/include/linux/ratelimit.h
[]
> +static inline void ratelimit_state_exit(struct ratelimit_state *rs)
> +{
> +	if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE))
> +		return;
> +
> +	if (rs->missed)
> +		printk(KERN_WARNING "%s: %d output lines suppressed due to ratelimiting\n",
> +		       current->comm, rs->missed);

Please use pr_warn as it will use whatever
pr_fmt prefix is specified by the subsystem.

Maybe:
	if (rs->missed)
		pr_warn("ratelimit: %s: %d output lines suppressed\n",
			current->comm, rs->missed);

to be more similar to the callback suppressed message in
lib/ratelimit.c

				pr_warn("%s: %d callbacks suppressed\n", func, rs->missed);