From: Steven Rostedt <rostedt@goodmis.org>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Franck Bui" <fbui@suse.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH -v3.1 1/2] ratelimit: Extend to print suppressed messages on release
Date: Wed, 6 Jul 2016 09:40:34 -0400 [thread overview]
Message-ID: <20160706094034.281e52c2@gandalf.local.home> (raw)
In-Reply-To: <20160706132800.GD7300@pd.tnic>
On Wed, 6 Jul 2016 15:28:00 +0200
Borislav Petkov <bp@alien8.de> wrote:
> extern struct ratelimit_state printk_ratelimit_state;
> diff --git a/lib/ratelimit.c b/lib/ratelimit.c
> index 2c5de86460c5..734cba5c8842 100644
> --- a/lib/ratelimit.c
> +++ b/lib/ratelimit.c
> @@ -46,12 +46,15 @@ int ___ratelimit(struct ratelimit_state *rs, const char *func)
> rs->begin = jiffies;
>
> if (time_is_before_jiffies(rs->begin + rs->interval)) {
> - if (rs->missed)
> - printk(KERN_WARNING "%s: %d callbacks suppressed\n",
> - func, rs->missed);
> - rs->begin = jiffies;
> - rs->printed = 0;
> - rs->missed = 0;
> + if (rs->missed) {
> + if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE)) {
> + pr_warn("%s: %d callbacks suppressed\n", func, rs->missed);
> + rs->missed = 0;
> + }
> +
> + rs->begin = jiffies;
> + rs->printed = 0;
> + }
Hmm, the above changes the previous logic. That seems wrong.
Before:
if (rs->missed)
[...]
rs->begin = jiffies;
rs->printed = 0;
after:
if (rs->missed) {
rs->begin = jiffies;
rs->printed = 0;
}
I think you wanted:
if (rs->missed) {
if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE)) {
[..]
rs->missed = 0;
}
}
rs->begin = jiffies;
rs->printed = 0;
-- Steve
> }
> if (rs->burst && rs->burst > rs->printed) {
> rs->printed++;
next prev parent reply other threads:[~2016-07-06 13:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 14:24 [PATCH -v3 0/2] printk.devkmsg: Ratelimit it by default Borislav Petkov
2016-07-04 14:24 ` [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release Borislav Petkov
2016-07-05 18:26 ` Steven Rostedt
2016-07-05 18:45 ` Borislav Petkov
2016-07-05 18:57 ` Steven Rostedt
2016-07-05 19:42 ` Borislav Petkov
2016-07-05 19:49 ` Steven Rostedt
2016-07-05 20:08 ` Joe Perches
2016-07-05 20:53 ` Christian Borntraeger
2016-07-05 21:14 ` Paolo Bonzini
2016-07-05 21:23 ` Christian Borntraeger
2016-07-05 21:31 ` Borislav Petkov
2016-07-06 13:28 ` [PATCH -v3.1 " Borislav Petkov
2016-07-06 13:40 ` Steven Rostedt [this message]
2016-07-06 14:59 ` [PATCH -v3.2 " Borislav Petkov
2016-07-07 1:17 ` Steven Rostedt
2016-07-07 5:36 ` Borislav Petkov
2016-07-06 14:50 ` [PATCH -v3.1 " Joe Perches
2016-07-04 14:24 ` [PATCH -v3 2/2] printk: Add kernel parameter to control writes to /dev/kmsg Borislav Petkov
2016-07-05 21:47 ` Steven Rostedt
2016-07-05 22:02 ` Borislav Petkov
2016-07-05 22:08 ` Steven Rostedt
2016-07-06 13:29 ` [PATCH -v3.1 " Borislav Petkov
2016-07-06 17:52 ` Steven Rostedt
2016-07-06 18:32 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706094034.281e52c2@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=fbui@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.