All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: "Joe Perches" <joe@perches.com>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Cornelia Huck" <cornelia.huck@de.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Franck Bui" <fbui@suse.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Janosch Frank" <frankja@linux.vnet.ibm.com>
Subject: Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release
Date: Tue, 5 Jul 2016 23:31:47 +0200	[thread overview]
Message-ID: <20160705213147.GH12027@pd.tnic> (raw)
In-Reply-To: <577C1E63.8060608@de.ibm.com>

On Tue, Jul 05, 2016 at 10:53:55PM +0200, Christian Borntraeger wrote:
> Yes, this is new in next. As far as I can see, the new message would only
> appear if we would call ratelimit_state_exit. Correct? We do not call this -
> I assume this is ok?

Right, the idea for the /dev/kmsg use case was to issue the suppressed
count only when we release the ratelimit state.

> We really only want to reuse the rate limit base code (to avoid writing the same
> code twice) and being in lib indicated that this can indeed be used outside
> printk.
> Now: your patch 1 would allow me to get rid of the messages completely
> by setting the flag and by not calling ratelimit_state_exit. Which is probably
> what we should do in our code.

Yeah, that should work for your usecase.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

  parent reply	other threads:[~2016-07-05 21:32 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04 14:24 [PATCH -v3 0/2] printk.devkmsg: Ratelimit it by default Borislav Petkov
2016-07-04 14:24 ` [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release Borislav Petkov
2016-07-05 18:26   ` Steven Rostedt
2016-07-05 18:45     ` Borislav Petkov
2016-07-05 18:57       ` Steven Rostedt
2016-07-05 19:42         ` Borislav Petkov
2016-07-05 19:49           ` Steven Rostedt
2016-07-05 20:08             ` Joe Perches
2016-07-05 20:53               ` Christian Borntraeger
2016-07-05 21:14                 ` Paolo Bonzini
2016-07-05 21:23                   ` Christian Borntraeger
2016-07-05 21:31                 ` Borislav Petkov [this message]
2016-07-06 13:28   ` [PATCH -v3.1 " Borislav Petkov
2016-07-06 13:40     ` Steven Rostedt
2016-07-06 14:59       ` [PATCH -v3.2 " Borislav Petkov
2016-07-07  1:17         ` Steven Rostedt
2016-07-07  5:36           ` Borislav Petkov
2016-07-06 14:50     ` [PATCH -v3.1 " Joe Perches
2016-07-04 14:24 ` [PATCH -v3 2/2] printk: Add kernel parameter to control writes to /dev/kmsg Borislav Petkov
2016-07-05 21:47   ` Steven Rostedt
2016-07-05 22:02     ` Borislav Petkov
2016-07-05 22:08       ` Steven Rostedt
2016-07-06 13:29   ` [PATCH -v3.1 " Borislav Petkov
2016-07-06 17:52     ` Steven Rostedt
2016-07-06 18:32       ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160705213147.GH12027@pd.tnic \
    --to=bp@alien8.de \
    --cc=akpm@linux-foundation.org \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=fbui@suse.com \
    --cc=frankja@linux.vnet.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rkrcmar@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.