From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Tony Lindgren <tony@atomide.com> Cc: linux-arm-kernel@lists.infradead.org, Ohad Ben-Cohen <ohad@wizery.com>, Joerg Roedel <joerg.roedel@amd.com>, Mauro Carvalho Chehab <mchehab@infradead.org>, Omar Ramirez Luna <omar.luna@linaro.org>, linux-omap@vger.kernel.org, Ido Yariv <ido@wizery.com> Subject: Re: [PATCH 5/6] ARM: OMAP2+: Make some definitions local Date: Thu, 25 Oct 2012 01:37:43 +0200 [thread overview] Message-ID: <1467852.FtkNIyyq5l@avalon> (raw) In-Reply-To: <20121024233317.GE11928@atomide.com> Hi Tony, On Wednesday 24 October 2012 16:33:18 Tony Lindgren wrote: > * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [121024 16:26]: > > On Friday 19 October 2012 09:17:43 Tony Lindgren wrote: > > > * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [121019 02:45]: > > > > On Thursday 18 October 2012 13:28:48 Tony Lindgren wrote: > > > > > @@ -117,13 +112,6 @@ static inline struct omap_iommu > > > > > *dev_to_omap_iommu(struct device *dev) } > > > > > > > > > > #endif > > > > > > > > > > -/* IOMMU errors */ > > > > > -#define OMAP_IOMMU_ERR_TLB_MISS (1 << 0) > > > > > -#define OMAP_IOMMU_ERR_TRANS_FAULT (1 << 1) > > > > > -#define OMAP_IOMMU_ERR_EMU_MISS (1 << 2) > > > > > -#define OMAP_IOMMU_ERR_TBLWALK_FAULT (1 << 3) > > > > > -#define OMAP_IOMMU_ERR_MULTIHIT_FAULT (1 << 4) > > > > > - > > > > > > > > I'll use those in the tidspbridge driver, in patches that I plan to > > > > push soon. > > > > > > > > I will apply this patch set on top of mine, see what breaks. Would you > > > > like me to propose a modified version of this set, or add additional > > > > patches in my set ? > > > > > > Sure, let's try to expose only the minimal amount of omap iommu things > > > with this patch set so we don't break things. Then the iommu development > > > can continue on it's own independent of the core omap code except for > > > the platform data. > > > > I'll rebase my DSP patches on top of this patch set then, it will be > > easier. > > OK sounds good to me. > > Once we have the minimal changes acked by you and Joerg, I'll push > it into an immutable branch that we all can merge in as needed. > > BTW, after updating patch 3/6 I noticed patches 4 - 6 had trivial merge > conflicts with the includes, so let me know if you want met to repost the > whole set. Please do. I'll then ack it (provided I have no more comments to make of course :-)). > > > But again, if there are nasty layering violations using this code, I > > > would just remove those features. Those things tend to just get worse > > > unless they are fixed properly to start with. > > > > The long-term goal is to move the tidspbridge driver to the IOMMU API, but > > we'll need a step by step approach. > > Yes agreed. -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 5/6] ARM: OMAP2+: Make some definitions local Date: Thu, 25 Oct 2012 01:37:43 +0200 [thread overview] Message-ID: <1467852.FtkNIyyq5l@avalon> (raw) In-Reply-To: <20121024233317.GE11928@atomide.com> Hi Tony, On Wednesday 24 October 2012 16:33:18 Tony Lindgren wrote: > * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [121024 16:26]: > > On Friday 19 October 2012 09:17:43 Tony Lindgren wrote: > > > * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [121019 02:45]: > > > > On Thursday 18 October 2012 13:28:48 Tony Lindgren wrote: > > > > > @@ -117,13 +112,6 @@ static inline struct omap_iommu > > > > > *dev_to_omap_iommu(struct device *dev) } > > > > > > > > > > #endif > > > > > > > > > > -/* IOMMU errors */ > > > > > -#define OMAP_IOMMU_ERR_TLB_MISS (1 << 0) > > > > > -#define OMAP_IOMMU_ERR_TRANS_FAULT (1 << 1) > > > > > -#define OMAP_IOMMU_ERR_EMU_MISS (1 << 2) > > > > > -#define OMAP_IOMMU_ERR_TBLWALK_FAULT (1 << 3) > > > > > -#define OMAP_IOMMU_ERR_MULTIHIT_FAULT (1 << 4) > > > > > - > > > > > > > > I'll use those in the tidspbridge driver, in patches that I plan to > > > > push soon. > > > > > > > > I will apply this patch set on top of mine, see what breaks. Would you > > > > like me to propose a modified version of this set, or add additional > > > > patches in my set ? > > > > > > Sure, let's try to expose only the minimal amount of omap iommu things > > > with this patch set so we don't break things. Then the iommu development > > > can continue on it's own independent of the core omap code except for > > > the platform data. > > > > I'll rebase my DSP patches on top of this patch set then, it will be > > easier. > > OK sounds good to me. > > Once we have the minimal changes acked by you and Joerg, I'll push > it into an immutable branch that we all can merge in as needed. > > BTW, after updating patch 3/6 I noticed patches 4 - 6 had trivial merge > conflicts with the includes, so let me know if you want met to repost the > whole set. Please do. I'll then ack it (provided I have no more comments to make of course :-)). > > > But again, if there are nasty layering violations using this code, I > > > would just remove those features. Those things tend to just get worse > > > unless they are fixed properly to start with. > > > > The long-term goal is to move the tidspbridge driver to the IOMMU API, but > > we'll need a step by step approach. > > Yes agreed. -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2012-10-24 23:36 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-10-18 20:28 [PATCH v3 0/6] omap iommu changes to remove plat includes Tony Lindgren 2012-10-18 20:28 ` Tony Lindgren 2012-10-18 20:28 ` [PATCH 1/6] ARM: OMAP: Merge iommu2.h into iommu.h Tony Lindgren 2012-10-18 20:28 ` Tony Lindgren 2012-10-18 20:28 ` [PATCH 2/6] ARM: OMAP2+: Move iopgtable header to drivers/iommu/ Tony Lindgren 2012-10-18 20:28 ` Tony Lindgren 2012-10-18 20:28 ` [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h Tony Lindgren 2012-10-18 20:28 ` Tony Lindgren 2012-10-18 20:56 ` Mauro Carvalho Chehab 2012-10-18 20:56 ` Mauro Carvalho Chehab 2012-10-18 22:11 ` Tony Lindgren 2012-10-18 22:11 ` Tony Lindgren 2012-10-19 9:40 ` Laurent Pinchart 2012-10-19 9:40 ` Laurent Pinchart 2012-10-19 16:14 ` Tony Lindgren 2012-10-19 16:14 ` Tony Lindgren 2012-10-24 22:34 ` Tony Lindgren 2012-10-24 22:34 ` Tony Lindgren 2012-10-24 23:53 ` Laurent Pinchart 2012-10-24 23:53 ` Laurent Pinchart 2012-10-25 0:25 ` Tony Lindgren 2012-10-25 0:25 ` Tony Lindgren 2012-10-18 20:28 ` [PATCH 4/6] ARM: OMAP2+: Move iommu2 to drivers/iommu/omap-iommu2.c Tony Lindgren 2012-10-18 20:28 ` Tony Lindgren 2012-10-18 20:28 ` [PATCH 5/6] ARM: OMAP2+: Make some definitions local Tony Lindgren 2012-10-18 20:28 ` Tony Lindgren 2012-10-19 9:44 ` Laurent Pinchart 2012-10-19 9:44 ` Laurent Pinchart 2012-10-19 16:17 ` Tony Lindgren 2012-10-19 16:17 ` Tony Lindgren 2012-10-24 23:26 ` Laurent Pinchart 2012-10-24 23:26 ` Laurent Pinchart 2012-10-24 23:33 ` Tony Lindgren 2012-10-24 23:33 ` Tony Lindgren 2012-10-24 23:37 ` Laurent Pinchart [this message] 2012-10-24 23:37 ` Laurent Pinchart 2012-10-25 0:24 ` Tony Lindgren 2012-10-25 0:24 ` Tony Lindgren 2012-10-18 20:28 ` [PATCH 6/6] ARM: OMAP2+: Move iommu/iovmm headers to platform_data Tony Lindgren 2012-10-18 20:28 ` Tony Lindgren 2012-10-25 0:20 [PATCH v4 0/6] omap iommu changes to remove plat includes Tony Lindgren 2012-10-25 0:21 ` [PATCH 5/6] ARM: OMAP2+: Make some definitions local Tony Lindgren 2012-10-25 0:21 ` Tony Lindgren 2012-11-02 19:23 [PATCH v5 0/6] Move rest of omap-iommu to live in drivers/iommu Tony Lindgren 2012-11-02 19:24 ` [PATCH 5/6] ARM: OMAP2+: Make some definitions local Tony Lindgren 2012-11-02 19:24 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1467852.FtkNIyyq5l@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=ido@wizery.com \ --cc=joerg.roedel@amd.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=mchehab@infradead.org \ --cc=ohad@wizery.com \ --cc=omar.luna@linaro.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.