All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Ohad Ben-Cohen <ohad@wizery.com>,
	Joerg Roedel <joerg.roedel@amd.com>,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	Omar Ramirez Luna <omar.luna@linaro.org>,
	linux-omap@vger.kernel.org, Ido Yariv <ido@wizery.com>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h
Date: Thu, 25 Oct 2012 01:53:32 +0200	[thread overview]
Message-ID: <2126833.cqGngBPXg2@avalon> (raw)
In-Reply-To: <20121024223412.GM5605@atomide.com>

Hi Tony,

On Wednesday 24 October 2012 15:34:12 Tony Lindgren wrote:
> * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [121019 02:41]:
> > On Thursday 18 October 2012 13:28:42 Tony Lindgren wrote:
> > > --- a/arch/arm/mach-omap2/iommu2.c
> > > +++ b/arch/arm/mach-omap2/iommu2.c
> > > @@ -17,6 +17,7 @@
> > > 
> > >  #include <linux/module.h>
> > >  #include <linux/slab.h>
> > >  #include <linux/stringify.h>
> > > 
> > > +#include <linux/omap-iommu.h>
> > 
> > Nitpicking, please keep the headers sorted alphabetically, here and in all
> > locations below (especially the OMAP3 ISP driver).
> > 
> > (OK, there's already one misplaced #include, but let's not make it worse
> > :-))
>
> This is fixed now.
> 
> > > --- /dev/null
> > > +++ b/include/linux/omap-iommu.h
> > > @@ -0,0 +1,47 @@
> > > +/*
> > > + * omap iommu: simple virtual address space management
> > > + *
> > > + * Copyright (C) 2008-2009 Nokia Corporation
> > > + *
> > > + * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> > > + *
> > > + * This program is free software; you can redistribute it and/or modify
> > > + * it under the terms of the GNU General Public License version 2 as
> > > + * published by the Free Software Foundation.
> > > + */
> > 
> > Missing #ifndef #define ... #endif
> 
> I've added it as _OMAP_IOMMU_H_, looks like both intel-iommu.h and
> amd-iommu.h have it.
> 
> Hopefully that's OK for you as a base to do further iommu patches
> on, updated patch below.
> 
> BTW, doing a test compile on v3.7-rc2, I'm seeing the following warnings
> for omap3isp for isp_video_ioctl_ops:
> 
> drivers/media/platform/omap3isp/ispvideo.c:1213: warning: initialization
> from incompatible pointer type
> drivers/media/platform/omap3isp/ispccdc.c:2303: warning: initialization
> from incompatible pointer type
> drivers/media/platform/omap3isp/ispccdc.c:2304: warning: initialization
> from incompatible pointer type
> drivers/media/platform/omap3isp/isph3a_aewb.c:282: warning: initialization
> from incompatible pointer type
> drivers/media/platform/omap3isp/isph3a_aewb.c:283: warning: initialization
> from incompatible pointer type
> drivers/media/platform/omap3isp/isph3a_af.c:347: warning: initialization
> from incompatible pointer type
> drivers/media/platform/omap3isp/isph3a_af.c:348: warning: initialization
> from incompatible pointer type
> drivers/media/platform/omap3isp/isphist.c:453: warning: initialization from
> incompatible pointer type
> drivers/media/platform/omap3isp/isphist.c:454: warning: initialization from
> incompatible pointer type

I've just sent a pull request to linux-media for v3.7 with fixes for those.
 
-- 
Regards,

Laurent Pinchart


WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h
Date: Thu, 25 Oct 2012 01:53:32 +0200	[thread overview]
Message-ID: <2126833.cqGngBPXg2@avalon> (raw)
In-Reply-To: <20121024223412.GM5605@atomide.com>

Hi Tony,

On Wednesday 24 October 2012 15:34:12 Tony Lindgren wrote:
> * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [121019 02:41]:
> > On Thursday 18 October 2012 13:28:42 Tony Lindgren wrote:
> > > --- a/arch/arm/mach-omap2/iommu2.c
> > > +++ b/arch/arm/mach-omap2/iommu2.c
> > > @@ -17,6 +17,7 @@
> > > 
> > >  #include <linux/module.h>
> > >  #include <linux/slab.h>
> > >  #include <linux/stringify.h>
> > > 
> > > +#include <linux/omap-iommu.h>
> > 
> > Nitpicking, please keep the headers sorted alphabetically, here and in all
> > locations below (especially the OMAP3 ISP driver).
> > 
> > (OK, there's already one misplaced #include, but let's not make it worse
> > :-))
>
> This is fixed now.
> 
> > > --- /dev/null
> > > +++ b/include/linux/omap-iommu.h
> > > @@ -0,0 +1,47 @@
> > > +/*
> > > + * omap iommu: simple virtual address space management
> > > + *
> > > + * Copyright (C) 2008-2009 Nokia Corporation
> > > + *
> > > + * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> > > + *
> > > + * This program is free software; you can redistribute it and/or modify
> > > + * it under the terms of the GNU General Public License version 2 as
> > > + * published by the Free Software Foundation.
> > > + */
> > 
> > Missing #ifndef #define ... #endif
> 
> I've added it as _OMAP_IOMMU_H_, looks like both intel-iommu.h and
> amd-iommu.h have it.
> 
> Hopefully that's OK for you as a base to do further iommu patches
> on, updated patch below.
> 
> BTW, doing a test compile on v3.7-rc2, I'm seeing the following warnings
> for omap3isp for isp_video_ioctl_ops:
> 
> drivers/media/platform/omap3isp/ispvideo.c:1213: warning: initialization
> from incompatible pointer type
> drivers/media/platform/omap3isp/ispccdc.c:2303: warning: initialization
> from incompatible pointer type
> drivers/media/platform/omap3isp/ispccdc.c:2304: warning: initialization
> from incompatible pointer type
> drivers/media/platform/omap3isp/isph3a_aewb.c:282: warning: initialization
> from incompatible pointer type
> drivers/media/platform/omap3isp/isph3a_aewb.c:283: warning: initialization
> from incompatible pointer type
> drivers/media/platform/omap3isp/isph3a_af.c:347: warning: initialization
> from incompatible pointer type
> drivers/media/platform/omap3isp/isph3a_af.c:348: warning: initialization
> from incompatible pointer type
> drivers/media/platform/omap3isp/isphist.c:453: warning: initialization from
> incompatible pointer type
> drivers/media/platform/omap3isp/isphist.c:454: warning: initialization from
> incompatible pointer type

I've just sent a pull request to linux-media for v3.7 with fixes for those.
 
-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2012-10-24 23:52 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18 20:28 [PATCH v3 0/6] omap iommu changes to remove plat includes Tony Lindgren
2012-10-18 20:28 ` Tony Lindgren
2012-10-18 20:28 ` [PATCH 1/6] ARM: OMAP: Merge iommu2.h into iommu.h Tony Lindgren
2012-10-18 20:28   ` Tony Lindgren
2012-10-18 20:28 ` [PATCH 2/6] ARM: OMAP2+: Move iopgtable header to drivers/iommu/ Tony Lindgren
2012-10-18 20:28   ` Tony Lindgren
2012-10-18 20:28 ` [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h Tony Lindgren
2012-10-18 20:28   ` Tony Lindgren
2012-10-18 20:56   ` Mauro Carvalho Chehab
2012-10-18 20:56     ` Mauro Carvalho Chehab
2012-10-18 22:11     ` Tony Lindgren
2012-10-18 22:11       ` Tony Lindgren
2012-10-19  9:40   ` Laurent Pinchart
2012-10-19  9:40     ` Laurent Pinchart
2012-10-19 16:14     ` Tony Lindgren
2012-10-19 16:14       ` Tony Lindgren
2012-10-24 22:34     ` Tony Lindgren
2012-10-24 22:34       ` Tony Lindgren
2012-10-24 23:53       ` Laurent Pinchart [this message]
2012-10-24 23:53         ` Laurent Pinchart
2012-10-25  0:25         ` Tony Lindgren
2012-10-25  0:25           ` Tony Lindgren
2012-10-18 20:28 ` [PATCH 4/6] ARM: OMAP2+: Move iommu2 to drivers/iommu/omap-iommu2.c Tony Lindgren
2012-10-18 20:28   ` Tony Lindgren
2012-10-18 20:28 ` [PATCH 5/6] ARM: OMAP2+: Make some definitions local Tony Lindgren
2012-10-18 20:28   ` Tony Lindgren
2012-10-19  9:44   ` Laurent Pinchart
2012-10-19  9:44     ` Laurent Pinchart
2012-10-19 16:17     ` Tony Lindgren
2012-10-19 16:17       ` Tony Lindgren
2012-10-24 23:26       ` Laurent Pinchart
2012-10-24 23:26         ` Laurent Pinchart
2012-10-24 23:33         ` Tony Lindgren
2012-10-24 23:33           ` Tony Lindgren
2012-10-24 23:37           ` Laurent Pinchart
2012-10-24 23:37             ` Laurent Pinchart
2012-10-25  0:24             ` Tony Lindgren
2012-10-25  0:24               ` Tony Lindgren
2012-10-18 20:28 ` [PATCH 6/6] ARM: OMAP2+: Move iommu/iovmm headers to platform_data Tony Lindgren
2012-10-18 20:28   ` Tony Lindgren
2012-10-25  0:20 [PATCH v4 0/6] omap iommu changes to remove plat includes Tony Lindgren
2012-10-25  0:20 ` [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h Tony Lindgren
2012-10-25  0:20   ` Tony Lindgren
2012-10-25  8:39   ` Laurent Pinchart
2012-10-25  8:39     ` Laurent Pinchart
2012-10-25 16:56     ` Tony Lindgren
2012-10-25 16:56       ` Tony Lindgren
2012-10-25 20:22       ` Laurent Pinchart
2012-10-25 20:22         ` Laurent Pinchart
2012-10-25 21:39         ` Tony Lindgren
2012-10-25 21:39           ` Tony Lindgren
2012-10-26  5:50           ` Ohad Ben-Cohen
2012-10-26  5:50             ` Ohad Ben-Cohen
2012-10-26  9:35             ` Laurent Pinchart
2012-10-26  9:35               ` Laurent Pinchart
2012-10-26  9:54               ` Ohad Ben-Cohen
2012-10-26  9:54                 ` Ohad Ben-Cohen
2012-10-26 18:00                 ` Tony Lindgren
2012-10-26 18:00                   ` Tony Lindgren
2012-10-30 16:29                   ` Tony Lindgren
2012-10-30 16:29                     ` Tony Lindgren
2012-11-02 18:55                     ` Tony Lindgren
2012-11-02 18:55                       ` Tony Lindgren
2012-11-02 19:23 [PATCH v5 0/6] Move rest of omap-iommu to live in drivers/iommu Tony Lindgren
2012-11-02 19:24 ` [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h Tony Lindgren
2012-11-02 19:24   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2126833.cqGngBPXg2@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=ido@wizery.com \
    --cc=joerg.roedel@amd.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=ohad@wizery.com \
    --cc=omar.luna@linaro.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.