All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>,
	moderated for non-subscribers <alsa-devel@alsa-project.org>,
	Takashi Iwai <tiwai@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Bard Liao <bardliao@realtek.com>,
	Oder Chiou <oder_chiou@realtek.com>
Subject: [PATCH -next] sound: rockchip: fix build when SPI is not enabled
Date: Mon, 22 Aug 2016 11:32:45 -0700	[thread overview]
Message-ID: <14691987-ab74-96c4-de5d-8caa06e94d3f@infradead.org> (raw)

From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors found in rt5514 drivers when SPI is not enabled.

Fixes these build errors:
ERROR: "__spi_register_driver" [sound/soc/codecs/snd-soc-rt5514-spi.ko] undefined!
ERROR: "spi_sync" [sound/soc/codecs/snd-soc-rt5514-spi.ko] undefined!

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc:	Bard Liao <bardliao@realtek.com>
Cc:	Oder Chiou <oder_chiou@realtek.com>
---
 sound/soc/rockchip/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This builds without errors, but if you always want to have the SPI
interface available in this driver, change the first "depends" to
include "&& SPI_MASTER".

--- linux-next-20160822.orig/sound/soc/rockchip/Kconfig
+++ linux-next-20160822/sound/soc/rockchip/Kconfig
@@ -49,7 +49,7 @@ config SND_SOC_RK3399_GRU_SOUND
 	select SND_SOC_MAX98357A
 	select SND_SOC_RT5514
 	select SND_SOC_DA7219
-	select SND_SOC_RT5514_SPI
+	select SND_SOC_RT5514_SPI if SPI_MASTER
 	help
 	  Say Y or M here if you want to add support multiple codecs for SoC
 	  audio on Rockchip RK3399 GRU boards.

WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>,
	moderated for non-subscribers <alsa-devel@alsa-project.org>,
	Takashi Iwai <tiwai@suse.de>
Cc: Oder Chiou <oder_chiou@realtek.com>,
	Bard Liao <bardliao@realtek.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH -next] sound: rockchip: fix build when SPI is not enabled
Date: Mon, 22 Aug 2016 11:32:45 -0700	[thread overview]
Message-ID: <14691987-ab74-96c4-de5d-8caa06e94d3f@infradead.org> (raw)

From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors found in rt5514 drivers when SPI is not enabled.

Fixes these build errors:
ERROR: "__spi_register_driver" [sound/soc/codecs/snd-soc-rt5514-spi.ko] undefined!
ERROR: "spi_sync" [sound/soc/codecs/snd-soc-rt5514-spi.ko] undefined!

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc:	Bard Liao <bardliao@realtek.com>
Cc:	Oder Chiou <oder_chiou@realtek.com>
---
 sound/soc/rockchip/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This builds without errors, but if you always want to have the SPI
interface available in this driver, change the first "depends" to
include "&& SPI_MASTER".

--- linux-next-20160822.orig/sound/soc/rockchip/Kconfig
+++ linux-next-20160822/sound/soc/rockchip/Kconfig
@@ -49,7 +49,7 @@ config SND_SOC_RK3399_GRU_SOUND
 	select SND_SOC_MAX98357A
 	select SND_SOC_RT5514
 	select SND_SOC_DA7219
-	select SND_SOC_RT5514_SPI
+	select SND_SOC_RT5514_SPI if SPI_MASTER
 	help
 	  Say Y or M here if you want to add support multiple codecs for SoC
 	  audio on Rockchip RK3399 GRU boards.

             reply	other threads:[~2016-08-22 19:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-22 18:32 Randy Dunlap [this message]
2016-08-22 18:32 ` [PATCH -next] sound: rockchip: fix build when SPI is not enabled Randy Dunlap
2016-08-24 17:55 ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14691987-ab74-96c4-de5d-8caa06e94d3f@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bardliao@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.