* [PATCH -next] sound: rockchip: fix build when SPI is not enabled
@ 2016-08-22 18:32 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2016-08-22 18:32 UTC (permalink / raw)
To: LKML, moderated for non-subscribers, Takashi Iwai
Cc: Andrew Morton, Bard Liao, Oder Chiou
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors found in rt5514 drivers when SPI is not enabled.
Fixes these build errors:
ERROR: "__spi_register_driver" [sound/soc/codecs/snd-soc-rt5514-spi.ko] undefined!
ERROR: "spi_sync" [sound/soc/codecs/snd-soc-rt5514-spi.ko] undefined!
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Bard Liao <bardliao@realtek.com>
Cc: Oder Chiou <oder_chiou@realtek.com>
---
sound/soc/rockchip/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This builds without errors, but if you always want to have the SPI
interface available in this driver, change the first "depends" to
include "&& SPI_MASTER".
--- linux-next-20160822.orig/sound/soc/rockchip/Kconfig
+++ linux-next-20160822/sound/soc/rockchip/Kconfig
@@ -49,7 +49,7 @@ config SND_SOC_RK3399_GRU_SOUND
select SND_SOC_MAX98357A
select SND_SOC_RT5514
select SND_SOC_DA7219
- select SND_SOC_RT5514_SPI
+ select SND_SOC_RT5514_SPI if SPI_MASTER
help
Say Y or M here if you want to add support multiple codecs for SoC
audio on Rockchip RK3399 GRU boards.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH -next] sound: rockchip: fix build when SPI is not enabled
@ 2016-08-22 18:32 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2016-08-22 18:32 UTC (permalink / raw)
To: LKML, moderated for non-subscribers, Takashi Iwai
Cc: Oder Chiou, Bard Liao, Andrew Morton
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors found in rt5514 drivers when SPI is not enabled.
Fixes these build errors:
ERROR: "__spi_register_driver" [sound/soc/codecs/snd-soc-rt5514-spi.ko] undefined!
ERROR: "spi_sync" [sound/soc/codecs/snd-soc-rt5514-spi.ko] undefined!
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Bard Liao <bardliao@realtek.com>
Cc: Oder Chiou <oder_chiou@realtek.com>
---
sound/soc/rockchip/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This builds without errors, but if you always want to have the SPI
interface available in this driver, change the first "depends" to
include "&& SPI_MASTER".
--- linux-next-20160822.orig/sound/soc/rockchip/Kconfig
+++ linux-next-20160822/sound/soc/rockchip/Kconfig
@@ -49,7 +49,7 @@ config SND_SOC_RK3399_GRU_SOUND
select SND_SOC_MAX98357A
select SND_SOC_RT5514
select SND_SOC_DA7219
- select SND_SOC_RT5514_SPI
+ select SND_SOC_RT5514_SPI if SPI_MASTER
help
Say Y or M here if you want to add support multiple codecs for SoC
audio on Rockchip RK3399 GRU boards.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] sound: rockchip: fix build when SPI is not enabled
2016-08-22 18:32 ` Randy Dunlap
(?)
@ 2016-08-24 17:55 ` Randy Dunlap
-1 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2016-08-24 17:55 UTC (permalink / raw)
To: LKML, moderated for non-subscribers, Takashi Iwai
Cc: Andrew Morton, Bard Liao, Oder Chiou
On 08/22/16 11:32, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors found in rt5514 drivers when SPI is not enabled.
>
> Fixes these build errors:
> ERROR: "__spi_register_driver" [sound/soc/codecs/snd-soc-rt5514-spi.ko] undefined!
> ERROR: "spi_sync" [sound/soc/codecs/snd-soc-rt5514-spi.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Bard Liao <bardliao@realtek.com>
> Cc: Oder Chiou <oder_chiou@realtek.com>
> ---
> sound/soc/rockchip/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This builds without errors, but if you always want to have the SPI
> interface available in this driver, change the first "depends" to
> include "&& SPI_MASTER".
Please drop this patch. The comment above is the correct thing to do
and I am sending a patch with that change.
> --- linux-next-20160822.orig/sound/soc/rockchip/Kconfig
> +++ linux-next-20160822/sound/soc/rockchip/Kconfig
> @@ -49,7 +49,7 @@ config SND_SOC_RK3399_GRU_SOUND
> select SND_SOC_MAX98357A
> select SND_SOC_RT5514
> select SND_SOC_DA7219
> - select SND_SOC_RT5514_SPI
> + select SND_SOC_RT5514_SPI if SPI_MASTER
> help
> Say Y or M here if you want to add support multiple codecs for SoC
> audio on Rockchip RK3399 GRU boards.
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-24 17:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-22 18:32 [PATCH -next] sound: rockchip: fix build when SPI is not enabled Randy Dunlap
2016-08-22 18:32 ` Randy Dunlap
2016-08-24 17:55 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.