All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Romell <danielromell@gmail.com>
To: a.zummo@towertech.it
Cc: alexandre.belloni@free-electrons.com, rtc-linux@googlegroups.com,
	linux-kernel@vger.kernel.org, daro@hms.se, jao@hms.se,
	mago@hms.se
Subject: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register.
Date: Thu, 11 Aug 2016 13:31:43 +0200	[thread overview]
Message-ID: <1470915104-10683-2-git-send-email-daro@hms.se> (raw)
In-Reply-To: <1470915104-10683-1-git-send-email-daro@hms.se>
In-Reply-To: <1470909555-9226-1-git-send-email-daro@hms.se>

From: Jan Östlund <jao@hms.se>

The BQ32K_SECONDS_MASK and BQ32K_MINUTES_MASK both has the same
value. This is no functional change.

Signed-off-by: Daniel Romell <daro@hms.se>
---
 drivers/rtc/rtc-bq32k.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c
index 0299988..5a0c137 100644
--- a/drivers/rtc/rtc-bq32k.c
+++ b/drivers/rtc/rtc-bq32k.c
@@ -94,7 +94,7 @@ static int bq32k_rtc_read_time(struct device *dev, struct rtc_time *tm)
 		return error;
 
 	tm->tm_sec = bcd2bin(regs.seconds & BQ32K_SECONDS_MASK);
-	tm->tm_min = bcd2bin(regs.minutes & BQ32K_SECONDS_MASK);
+	tm->tm_min = bcd2bin(regs.minutes & BQ32K_MINUTES_MASK);
 	tm->tm_hour = bcd2bin(regs.cent_hours & BQ32K_HOURS_MASK);
 	tm->tm_mday = bcd2bin(regs.date);
 	tm->tm_wday = bcd2bin(regs.day) - 1;
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Romell <danielromell@gmail.com>
To: a.zummo@towertech.it
Cc: alexandre.belloni@free-electrons.com, rtc-linux@googlegroups.com,
	linux-kernel@vger.kernel.org, daro@hms.se, jao@hms.se,
	mago@hms.se
Subject: [rtc-linux] [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register.
Date: Thu, 11 Aug 2016 13:31:43 +0200	[thread overview]
Message-ID: <1470915104-10683-2-git-send-email-daro@hms.se> (raw)
In-Reply-To: <1470915104-10683-1-git-send-email-daro@hms.se>
In-Reply-To: <1470909555-9226-1-git-send-email-daro@hms.se>

From: Jan =C3=96stlund <jao@hms.se>

The BQ32K_SECONDS_MASK and BQ32K_MINUTES_MASK both has the same
value. This is no functional change.

Signed-off-by: Daniel Romell <daro@hms.se>
---
 drivers/rtc/rtc-bq32k.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c
index 0299988..5a0c137 100644
--- a/drivers/rtc/rtc-bq32k.c
+++ b/drivers/rtc/rtc-bq32k.c
@@ -94,7 +94,7 @@ static int bq32k_rtc_read_time(struct device *dev, struct=
 rtc_time *tm)
 		return error;
=20
 	tm->tm_sec =3D bcd2bin(regs.seconds & BQ32K_SECONDS_MASK);
-	tm->tm_min =3D bcd2bin(regs.minutes & BQ32K_SECONDS_MASK);
+	tm->tm_min =3D bcd2bin(regs.minutes & BQ32K_MINUTES_MASK);
 	tm->tm_hour =3D bcd2bin(regs.cent_hours & BQ32K_HOURS_MASK);
 	tm->tm_mday =3D bcd2bin(regs.date);
 	tm->tm_wday =3D bcd2bin(regs.day) - 1;
--=20
2.7.4

--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

  parent reply	other threads:[~2016-08-11 11:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11  9:59 [PATCH 0/2] bq32000 fixes Daniel Romell
2016-08-11  9:59 ` [rtc-linux] " Daniel Romell
2016-08-11  9:59 ` [PATCH 1/2] rtc: bq32k: Use correct mask name for 'minutes' register Daniel Romell
2016-08-11  9:59   ` [rtc-linux] " Daniel Romell
2016-08-11  9:59 ` [PATCH 2/2] rtc: bq32k: Fix handling of oscillator failure flag Daniel Romell
2016-08-11  9:59   ` [rtc-linux] " Daniel Romell
2016-08-11 10:15   ` Alexandre Belloni
2016-08-11 10:15     ` [rtc-linux] " Alexandre Belloni
2016-08-11 11:31 ` [PATCH v2 0/2] bq32000 fixes Daniel Romell
2016-08-11 11:31   ` [rtc-linux] " Daniel Romell
2016-08-11 11:31 ` Daniel Romell [this message]
2016-08-11 11:31   ` [rtc-linux] [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register Daniel Romell
2016-08-11 13:42   ` Alexandre Belloni
2016-08-11 13:42     ` [rtc-linux] " Alexandre Belloni
2016-08-11 14:56     ` danielromell
2016-08-11 21:13       ` Alexandre Belloni
2016-08-15  7:10   ` Jan Östlund
2016-08-15  7:10     ` [rtc-linux] " Jan Östlund
2016-08-11 11:31 ` [PATCH v2 2/2] rtc: bq32k: Fix handling of oscillator failure flag Daniel Romell
2016-08-11 11:31   ` [rtc-linux] " Daniel Romell
2016-08-15  7:10   ` Jan Östlund
2016-08-15  7:10     ` [rtc-linux] " Jan Östlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470915104-10683-2-git-send-email-daro@hms.se \
    --to=danielromell@gmail.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=daro@hms.se \
    --cc=jao@hms.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mago@hms.se \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.