* [PATCH 01/28] media: dvb-frontends: rtl2832_sdr: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 02/28] media: radio: si470x: radio-si470x-usb: " Wolfram Sang
` (27 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb
Cc: Wolfram Sang, Antti Palosaari, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/dvb-frontends/rtl2832_sdr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/rtl2832_sdr.c b/drivers/media/dvb-frontends/rtl2832_sdr.c
index 6e22af36b637b7..e038e886731b13 100644
--- a/drivers/media/dvb-frontends/rtl2832_sdr.c
+++ b/drivers/media/dvb-frontends/rtl2832_sdr.c
@@ -392,7 +392,6 @@ static int rtl2832_sdr_alloc_urbs(struct rtl2832_sdr_dev *dev)
dev_dbg(&pdev->dev, "alloc urb=%d\n", i);
dev->urb_list[i] = usb_alloc_urb(0, GFP_ATOMIC);
if (!dev->urb_list[i]) {
- dev_dbg(&pdev->dev, "failed\n");
for (j = 0; j < i; j++)
usb_free_urb(dev->urb_list[j]);
return -ENOMEM;
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 02/28] media: radio: si470x: radio-si470x-usb: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
2016-08-11 21:03 ` [PATCH 01/28] media: dvb-frontends: rtl2832_sdr: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 03/28] media: rc: imon: " Wolfram Sang
` (26 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Hans Verkuil, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/radio/si470x/radio-si470x-usb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/radio/si470x/radio-si470x-usb.c b/drivers/media/radio/si470x/radio-si470x-usb.c
index 091d793f658361..4b132c29f2900c 100644
--- a/drivers/media/radio/si470x/radio-si470x-usb.c
+++ b/drivers/media/radio/si470x/radio-si470x-usb.c
@@ -627,7 +627,6 @@ static int si470x_usb_driver_probe(struct usb_interface *intf,
radio->int_in_urb = usb_alloc_urb(0, GFP_KERNEL);
if (!radio->int_in_urb) {
- dev_info(&intf->dev, "could not allocate int_in_urb");
retval = -ENOMEM;
goto err_intbuffer;
}
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 03/28] media: rc: imon: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
2016-08-11 21:03 ` [PATCH 01/28] media: dvb-frontends: rtl2832_sdr: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 02/28] media: radio: si470x: radio-si470x-usb: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 04/28] media: rc: redrat3: " Wolfram Sang
` (25 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/rc/imon.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c
index 65f80b8b9f7ab9..86cc70fe25348f 100644
--- a/drivers/media/rc/imon.c
+++ b/drivers/media/rc/imon.c
@@ -2211,16 +2211,11 @@ static struct imon_context *imon_init_intf0(struct usb_interface *intf,
goto exit;
}
rx_urb = usb_alloc_urb(0, GFP_KERNEL);
- if (!rx_urb) {
- dev_err(dev, "%s: usb_alloc_urb failed for IR urb", __func__);
+ if (!rx_urb)
goto rx_urb_alloc_failed;
- }
tx_urb = usb_alloc_urb(0, GFP_KERNEL);
- if (!tx_urb) {
- dev_err(dev, "%s: usb_alloc_urb failed for display urb",
- __func__);
+ if (!tx_urb)
goto tx_urb_alloc_failed;
- }
mutex_init(&ictx->lock);
spin_lock_init(&ictx->kc_lock);
@@ -2305,10 +2300,8 @@ static struct imon_context *imon_init_intf1(struct usb_interface *intf,
int ret = -ENOMEM;
rx_urb = usb_alloc_urb(0, GFP_KERNEL);
- if (!rx_urb) {
- pr_err("usb_alloc_urb failed for IR urb\n");
+ if (!rx_urb)
goto rx_urb_alloc_failed;
- }
mutex_lock(&ictx->lock);
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 04/28] media: rc: redrat3: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (2 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 03/28] media: rc: imon: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 05/28] media: usb: airspy: airspy: " Wolfram Sang
` (24 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/rc/redrat3.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
index 399f44d89a2986..ec8016d9b00907 100644
--- a/drivers/media/rc/redrat3.c
+++ b/drivers/media/rc/redrat3.c
@@ -970,10 +970,8 @@ static int redrat3_dev_probe(struct usb_interface *intf,
/* set up bulk-in endpoint */
rr3->read_urb = usb_alloc_urb(0, GFP_KERNEL);
- if (!rr3->read_urb) {
- dev_err(dev, "Read urb allocation failure\n");
+ if (!rr3->read_urb)
goto error;
- }
rr3->ep_in = ep_in;
rr3->bulk_in_buf = usb_alloc_coherent(udev,
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 05/28] media: usb: airspy: airspy: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (3 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 04/28] media: rc: redrat3: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 06/28] media: usb: as102: as102_usb_drv: " Wolfram Sang
` (23 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb
Cc: Wolfram Sang, Antti Palosaari, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/airspy/airspy.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/usb/airspy/airspy.c b/drivers/media/usb/airspy/airspy.c
index fe031b06935fbb..3c556ee306cd33 100644
--- a/drivers/media/usb/airspy/airspy.c
+++ b/drivers/media/usb/airspy/airspy.c
@@ -426,7 +426,6 @@ static int airspy_alloc_urbs(struct airspy *s)
dev_dbg(s->dev, "alloc urb=%d\n", i);
s->urb_list[i] = usb_alloc_urb(0, GFP_ATOMIC);
if (!s->urb_list[i]) {
- dev_dbg(s->dev, "failed\n");
for (j = 0; j < i; j++)
usb_free_urb(s->urb_list[j]);
return -ENOMEM;
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 06/28] media: usb: as102: as102_usb_drv: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (4 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 05/28] media: usb: airspy: airspy: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 07/28] media: usb: au0828: au0828-video: " Wolfram Sang
` (22 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/as102/as102_usb_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/usb/as102/as102_usb_drv.c b/drivers/media/usb/as102/as102_usb_drv.c
index 0e8030c071b8e7..68c3a80ce349b7 100644
--- a/drivers/media/usb/as102/as102_usb_drv.c
+++ b/drivers/media/usb/as102/as102_usb_drv.c
@@ -270,8 +270,6 @@ static int as102_alloc_usb_stream_buffer(struct as102_dev_t *dev)
urb = usb_alloc_urb(0, GFP_ATOMIC);
if (urb == NULL) {
- dev_dbg(&dev->bus_adap.usb_dev->dev,
- "%s: usb_alloc_urb failed\n", __func__);
as102_free_usb_stream_buffer(dev);
return -ENOMEM;
}
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 07/28] media: usb: au0828: au0828-video: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (5 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 06/28] media: usb: as102: as102_usb_drv: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 08/28] media: usb: cpia2: cpia2_usb: " Wolfram Sang
` (21 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/au0828/au0828-video.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c
index 82b02698586835..13b8387082f277 100644
--- a/drivers/media/usb/au0828/au0828-video.c
+++ b/drivers/media/usb/au0828/au0828-video.c
@@ -245,7 +245,6 @@ static int au0828_init_isoc(struct au0828_dev *dev, int max_packets,
for (i = 0; i < dev->isoc_ctl.num_bufs; i++) {
urb = usb_alloc_urb(max_packets, GFP_KERNEL);
if (!urb) {
- au0828_isocdbg("cannot alloc isoc_ctl.urb %i\n", i);
au0828_uninit_isoc(dev);
return -ENOMEM;
}
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 08/28] media: usb: cpia2: cpia2_usb: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (6 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 07/28] media: usb: au0828: au0828-video: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 09/28] media: usb: cx231xx: cx231xx-audio: " Wolfram Sang
` (20 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/cpia2/cpia2_usb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/usb/cpia2/cpia2_usb.c b/drivers/media/usb/cpia2/cpia2_usb.c
index c1aa1ab2ece9ff..13620cdf05996f 100644
--- a/drivers/media/usb/cpia2/cpia2_usb.c
+++ b/drivers/media/usb/cpia2/cpia2_usb.c
@@ -662,7 +662,6 @@ static int submit_urbs(struct camera_data *cam)
}
urb = usb_alloc_urb(FRAMES_PER_DESC, GFP_KERNEL);
if (!urb) {
- ERR("%s: usb_alloc_urb error!\n", __func__);
for (j = 0; j < i; j++)
usb_free_urb(cam->sbuf[j].urb);
return -ENOMEM;
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 09/28] media: usb: cx231xx: cx231xx-audio: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (7 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 08/28] media: usb: cpia2: cpia2_usb: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 10/28] media: usb: cx231xx: cx231xx-core: " Wolfram Sang
` (19 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/cx231xx/cx231xx-audio.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/usb/cx231xx/cx231xx-audio.c b/drivers/media/usb/cx231xx/cx231xx-audio.c
index a6a9508418f8ee..4cd5fa91612f62 100644
--- a/drivers/media/usb/cx231xx/cx231xx-audio.c
+++ b/drivers/media/usb/cx231xx/cx231xx-audio.c
@@ -293,7 +293,6 @@ static int cx231xx_init_audio_isoc(struct cx231xx *dev)
memset(dev->adev.transfer_buffer[i], 0x80, sb_size);
urb = usb_alloc_urb(CX231XX_ISO_NUM_AUDIO_PACKETS, GFP_ATOMIC);
if (!urb) {
- dev_err(dev->dev, "usb_alloc_urb failed!\n");
for (j = 0; j < i; j++) {
usb_free_urb(dev->adev.urb[j]);
kfree(dev->adev.transfer_buffer[j]);
@@ -355,7 +354,6 @@ static int cx231xx_init_audio_bulk(struct cx231xx *dev)
memset(dev->adev.transfer_buffer[i], 0x80, sb_size);
urb = usb_alloc_urb(CX231XX_NUM_AUDIO_PACKETS, GFP_ATOMIC);
if (!urb) {
- dev_err(dev->dev, "usb_alloc_urb failed!\n");
for (j = 0; j < i; j++) {
usb_free_urb(dev->adev.urb[j]);
kfree(dev->adev.transfer_buffer[j]);
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 10/28] media: usb: cx231xx: cx231xx-core: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (8 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 09/28] media: usb: cx231xx: cx231xx-audio: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 11/28] media: usb: cx231xx: cx231xx-vbi: " Wolfram Sang
` (18 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/cx231xx/cx231xx-core.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/media/usb/cx231xx/cx231xx-core.c b/drivers/media/usb/cx231xx/cx231xx-core.c
index 630f4fc5155f12..8ec05cb306d89a 100644
--- a/drivers/media/usb/cx231xx/cx231xx-core.c
+++ b/drivers/media/usb/cx231xx/cx231xx-core.c
@@ -1035,8 +1035,6 @@ int cx231xx_init_isoc(struct cx231xx *dev, int max_packets,
for (i = 0; i < dev->video_mode.isoc_ctl.num_bufs; i++) {
urb = usb_alloc_urb(max_packets, GFP_KERNEL);
if (!urb) {
- dev_err(dev->dev,
- "cannot alloc isoc_ctl.urb %i\n", i);
cx231xx_uninit_isoc(dev);
return -ENOMEM;
}
@@ -1172,8 +1170,6 @@ int cx231xx_init_bulk(struct cx231xx *dev, int max_packets,
for (i = 0; i < dev->video_mode.bulk_ctl.num_bufs; i++) {
urb = usb_alloc_urb(0, GFP_KERNEL);
if (!urb) {
- dev_err(dev->dev,
- "cannot alloc bulk_ctl.urb %i\n", i);
cx231xx_uninit_bulk(dev);
return -ENOMEM;
}
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 11/28] media: usb: cx231xx: cx231xx-vbi: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (9 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 10/28] media: usb: cx231xx: cx231xx-core: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 12/28] media: usb: dvb-usb: dib0700_core: " Wolfram Sang
` (17 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/cx231xx/cx231xx-vbi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/usb/cx231xx/cx231xx-vbi.c b/drivers/media/usb/cx231xx/cx231xx-vbi.c
index 15bb573b78ac82..76e901920f6f9b 100644
--- a/drivers/media/usb/cx231xx/cx231xx-vbi.c
+++ b/drivers/media/usb/cx231xx/cx231xx-vbi.c
@@ -442,8 +442,6 @@ int cx231xx_init_vbi_isoc(struct cx231xx *dev, int max_packets,
urb = usb_alloc_urb(0, GFP_KERNEL);
if (!urb) {
- dev_err(dev->dev,
- "cannot alloc bulk_ctl.urb %i\n", i);
cx231xx_uninit_vbi_isoc(dev);
return -ENOMEM;
}
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 12/28] media: usb: dvb-usb: dib0700_core: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (10 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 11/28] media: usb: cx231xx: cx231xx-vbi: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 13/28] media: usb: em28xx: em28xx-audio: " Wolfram Sang
` (16 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/dvb-usb/dib0700_core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c b/drivers/media/usb/dvb-usb/dib0700_core.c
index bf890c3d9cda02..26797979ebce4b 100644
--- a/drivers/media/usb/dvb-usb/dib0700_core.c
+++ b/drivers/media/usb/dvb-usb/dib0700_core.c
@@ -783,10 +783,8 @@ int dib0700_rc_setup(struct dvb_usb_device *d, struct usb_interface *intf)
/* Starting in firmware 1.20, the RC info is provided on a bulk pipe */
purb = usb_alloc_urb(0, GFP_KERNEL);
- if (purb == NULL) {
- err("rc usb alloc urb failed");
+ if (purb == NULL)
return -ENOMEM;
- }
purb->transfer_buffer = kzalloc(RC_MSG_SIZE_V1_20, GFP_KERNEL);
if (purb->transfer_buffer == NULL) {
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 13/28] media: usb: em28xx: em28xx-audio: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (11 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 12/28] media: usb: dvb-usb: dib0700_core: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 14/28] media: usb: em28xx: em28xx-core: " Wolfram Sang
` (15 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/em28xx/em28xx-audio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/usb/em28xx/em28xx-audio.c b/drivers/media/usb/em28xx/em28xx-audio.c
index 49a5f9532bd8d8..78f3687772bfe3 100644
--- a/drivers/media/usb/em28xx/em28xx-audio.c
+++ b/drivers/media/usb/em28xx/em28xx-audio.c
@@ -850,7 +850,6 @@ static int em28xx_audio_urb_init(struct em28xx *dev)
urb = usb_alloc_urb(npackets, GFP_ATOMIC);
if (!urb) {
- em28xx_errdev("usb_alloc_urb failed!\n");
em28xx_audio_free_urb(dev);
return -ENOMEM;
}
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 14/28] media: usb: em28xx: em28xx-core: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (12 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 13/28] media: usb: em28xx: em28xx-audio: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 15/28] media: usb: gspca: benq: " Wolfram Sang
` (14 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/em28xx/em28xx-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/usb/em28xx/em28xx-core.c b/drivers/media/usb/em28xx/em28xx-core.c
index 37456079f490d9..eebd5d7088d009 100644
--- a/drivers/media/usb/em28xx/em28xx-core.c
+++ b/drivers/media/usb/em28xx/em28xx-core.c
@@ -934,7 +934,6 @@ int em28xx_alloc_urbs(struct em28xx *dev, enum em28xx_mode mode, int xfer_bulk,
for (i = 0; i < usb_bufs->num_bufs; i++) {
urb = usb_alloc_urb(usb_bufs->num_packets, GFP_KERNEL);
if (!urb) {
- em28xx_err("cannot alloc usb_ctl.urb %i\n", i);
em28xx_uninit_usb_xfer(dev, mode);
return -ENOMEM;
}
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 15/28] media: usb: gspca: benq: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (13 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 14/28] media: usb: em28xx: em28xx-core: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 16/28] media: usb: gspca: gspca: " Wolfram Sang
` (13 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Hans Verkuil, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/gspca/benq.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/usb/gspca/benq.c b/drivers/media/usb/gspca/benq.c
index 790baed339639d..5fa67b78ad49b1 100644
--- a/drivers/media/usb/gspca/benq.c
+++ b/drivers/media/usb/gspca/benq.c
@@ -95,10 +95,8 @@ static int sd_start(struct gspca_dev *gspca_dev)
#define SD_NPKT 32
for (n = 0; n < 4; n++) {
urb = usb_alloc_urb(SD_NPKT, GFP_KERNEL);
- if (!urb) {
- pr_err("usb_alloc_urb failed\n");
+ if (!urb)
return -ENOMEM;
- }
gspca_dev->urb[n] = urb;
urb->transfer_buffer = usb_alloc_coherent(gspca_dev->dev,
SD_PKT_SZ * SD_NPKT,
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 16/28] media: usb: gspca: gspca: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (14 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 15/28] media: usb: gspca: benq: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 17/28] media: usb: gspca: konica: " Wolfram Sang
` (12 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Hans Verkuil, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/gspca/gspca.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/usb/gspca/gspca.c b/drivers/media/usb/gspca/gspca.c
index b17bd7ebcb47f7..af2395a76d8bf9 100644
--- a/drivers/media/usb/gspca/gspca.c
+++ b/drivers/media/usb/gspca/gspca.c
@@ -795,10 +795,8 @@ static int create_urbs(struct gspca_dev *gspca_dev,
for (n = 0; n < nurbs; n++) {
urb = usb_alloc_urb(npkt, GFP_KERNEL);
- if (!urb) {
- pr_err("usb_alloc_urb failed\n");
+ if (!urb)
return -ENOMEM;
- }
gspca_dev->urb[n] = urb;
urb->transfer_buffer = usb_alloc_coherent(gspca_dev->dev,
bsize,
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 17/28] media: usb: gspca: konica: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (15 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 16/28] media: usb: gspca: gspca: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 18/28] media: usb: hackrf: hackrf: " Wolfram Sang
` (11 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Hans Verkuil, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/gspca/konica.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/usb/gspca/konica.c b/drivers/media/usb/gspca/konica.c
index 0712b1bc90b4dd..40aaaa9c5f30eb 100644
--- a/drivers/media/usb/gspca/konica.c
+++ b/drivers/media/usb/gspca/konica.c
@@ -208,10 +208,8 @@ static int sd_start(struct gspca_dev *gspca_dev)
packet_size =
le16_to_cpu(alt->endpoint[i].desc.wMaxPacketSize);
urb = usb_alloc_urb(SD_NPKT, GFP_KERNEL);
- if (!urb) {
- pr_err("usb_alloc_urb failed\n");
+ if (!urb)
return -ENOMEM;
- }
gspca_dev->urb[n] = urb;
urb->transfer_buffer = usb_alloc_coherent(gspca_dev->dev,
packet_size * SD_NPKT,
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 18/28] media: usb: hackrf: hackrf: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (16 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 17/28] media: usb: gspca: konica: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 19/28] media: usb: hdpvr: hdpvr-video: " Wolfram Sang
` (10 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb
Cc: Wolfram Sang, Antti Palosaari, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/hackrf/hackrf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/usb/hackrf/hackrf.c b/drivers/media/usb/hackrf/hackrf.c
index b1e229a44192d3..c2c8d12e949868 100644
--- a/drivers/media/usb/hackrf/hackrf.c
+++ b/drivers/media/usb/hackrf/hackrf.c
@@ -691,7 +691,6 @@ static int hackrf_alloc_urbs(struct hackrf_dev *dev, bool rcv)
dev_dbg(dev->dev, "alloc urb=%d\n", i);
dev->urb_list[i] = usb_alloc_urb(0, GFP_ATOMIC);
if (!dev->urb_list[i]) {
- dev_dbg(dev->dev, "failed\n");
for (j = 0; j < i; j++)
usb_free_urb(dev->urb_list[j]);
return -ENOMEM;
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 19/28] media: usb: hdpvr: hdpvr-video: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (17 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 18/28] media: usb: hackrf: hackrf: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 20/28] media: usb: msi2500: msi2500: " Wolfram Sang
` (9 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Hans Verkuil, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/hdpvr/hdpvr-video.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/media/usb/hdpvr/hdpvr-video.c
index 2a3a8b470555b9..6d43d75493ea0e 100644
--- a/drivers/media/usb/hdpvr/hdpvr-video.c
+++ b/drivers/media/usb/hdpvr/hdpvr-video.c
@@ -155,10 +155,8 @@ int hdpvr_alloc_buffers(struct hdpvr_device *dev, uint count)
buf->dev = dev;
urb = usb_alloc_urb(0, GFP_KERNEL);
- if (!urb) {
- v4l2_err(&dev->v4l2_dev, "cannot allocate urb\n");
+ if (!urb)
goto exit_urb;
- }
buf->urb = urb;
mem = usb_alloc_coherent(dev->udev, dev->bulk_in_size, GFP_KERNEL,
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 20/28] media: usb: msi2500: msi2500: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (18 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 19/28] media: usb: hdpvr: hdpvr-video: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 21/28] media: usb: pwc: pwc-if: " Wolfram Sang
` (8 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb
Cc: Wolfram Sang, Antti Palosaari, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/msi2500/msi2500.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/usb/msi2500/msi2500.c b/drivers/media/usb/msi2500/msi2500.c
index e7f167d44c61ce..367eb7e2a31dbc 100644
--- a/drivers/media/usb/msi2500/msi2500.c
+++ b/drivers/media/usb/msi2500/msi2500.c
@@ -509,7 +509,6 @@ static int msi2500_isoc_init(struct msi2500_dev *dev)
for (i = 0; i < MAX_ISO_BUFS; i++) {
urb = usb_alloc_urb(ISO_FRAMES_PER_DESC, GFP_KERNEL);
if (urb == NULL) {
- dev_err(dev->dev, "Failed to allocate urb %d\n", i);
msi2500_isoc_cleanup(dev);
return -ENOMEM;
}
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 21/28] media: usb: pwc: pwc-if: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (19 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 20/28] media: usb: msi2500: msi2500: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 22/28] media: usb: s2255: s2255drv: " Wolfram Sang
` (7 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Hans Verkuil, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/pwc/pwc-if.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/usb/pwc/pwc-if.c b/drivers/media/usb/pwc/pwc-if.c
index b51b27a3fd6108..c4454c928776f7 100644
--- a/drivers/media/usb/pwc/pwc-if.c
+++ b/drivers/media/usb/pwc/pwc-if.c
@@ -410,7 +410,6 @@ retry:
for (i = 0; i < MAX_ISO_BUFS; i++) {
urb = usb_alloc_urb(ISO_FRAMES_PER_DESC, GFP_KERNEL);
if (urb == NULL) {
- PWC_ERROR("Failed to allocate urb %d\n", i);
pwc_isoc_cleanup(pdev);
return -ENOMEM;
}
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 22/28] media: usb: s2255: s2255drv: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (20 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 21/28] media: usb: pwc: pwc-if: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:03 ` [PATCH 23/28] media: usb: stk1160: stk1160-video: " Wolfram Sang
` (6 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/s2255/s2255drv.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c
index 43ba71a7d02b8f..9458eb0ef66f43 100644
--- a/drivers/media/usb/s2255/s2255drv.c
+++ b/drivers/media/usb/s2255/s2255drv.c
@@ -2113,11 +2113,8 @@ static int s2255_start_readpipe(struct s2255_dev *dev)
pipe_info->state = 1;
pipe_info->err_count = 0;
pipe_info->stream_urb = usb_alloc_urb(0, GFP_KERNEL);
- if (!pipe_info->stream_urb) {
- dev_err(&dev->udev->dev,
- "ReadStream: Unable to alloc URB\n");
+ if (!pipe_info->stream_urb)
return -ENOMEM;
- }
/* transfer buffer allocated in board_init */
usb_fill_bulk_urb(pipe_info->stream_urb, dev->udev,
pipe,
@@ -2290,10 +2287,8 @@ static int s2255_probe(struct usb_interface *interface,
}
dev->fw_data->fw_urb = usb_alloc_urb(0, GFP_KERNEL);
- if (!dev->fw_data->fw_urb) {
- dev_err(&interface->dev, "out of memory!\n");
+ if (!dev->fw_data->fw_urb)
goto errorFWURB;
- }
dev->fw_data->pfw_data = kzalloc(CHUNK_SIZE, GFP_KERNEL);
if (!dev->fw_data->pfw_data) {
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 23/28] media: usb: stk1160: stk1160-video: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (21 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 22/28] media: usb: s2255: s2255drv: " Wolfram Sang
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-11 21:04 ` [PATCH 24/28] media: usb: stkwebcam: stk-webcam: " Wolfram Sang
` (5 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb
Cc: Wolfram Sang, Ezequiel Garcia, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/stk1160/stk1160-video.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/usb/stk1160/stk1160-video.c b/drivers/media/usb/stk1160/stk1160-video.c
index 6ecb0b48423f3d..ce8ebbe395a620 100644
--- a/drivers/media/usb/stk1160/stk1160-video.c
+++ b/drivers/media/usb/stk1160/stk1160-video.c
@@ -457,10 +457,8 @@ int stk1160_alloc_isoc(struct stk1160 *dev)
for (i = 0; i < num_bufs; i++) {
urb = usb_alloc_urb(max_packets, GFP_KERNEL);
- if (!urb) {
- stk1160_err("cannot alloc urb[%d]\n", i);
+ if (!urb)
goto free_i_bufs;
- }
dev->isoc_ctl.urb[i] = urb;
#ifndef CONFIG_DMA_NONCOHERENT
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 24/28] media: usb: stkwebcam: stk-webcam: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (22 preceding siblings ...)
2016-08-11 21:03 ` [PATCH 23/28] media: usb: stk1160: stk1160-video: " Wolfram Sang
@ 2016-08-11 21:04 ` Wolfram Sang
2016-08-11 21:04 ` [PATCH 25/28] media: usb: tm6000: tm6000-dvb: " Wolfram Sang
` (4 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:04 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/stkwebcam/stk-webcam.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/usb/stkwebcam/stk-webcam.c b/drivers/media/usb/stkwebcam/stk-webcam.c
index c21c4c004f9778..db200c9d796d36 100644
--- a/drivers/media/usb/stkwebcam/stk-webcam.c
+++ b/drivers/media/usb/stkwebcam/stk-webcam.c
@@ -452,10 +452,8 @@ static int stk_prepare_iso(struct stk_camera *dev)
STK_ERROR("isobuf data already allocated\n");
if (dev->isobufs[i].urb == NULL) {
urb = usb_alloc_urb(ISO_FRAMES_PER_DESC, GFP_KERNEL);
- if (urb == NULL) {
- STK_ERROR("Failed to allocate URB %d\n", i);
+ if (urb == NULL)
goto isobufs_out;
- }
dev->isobufs[i].urb = urb;
} else {
STK_ERROR("Killing URB\n");
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 25/28] media: usb: tm6000: tm6000-dvb: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (23 preceding siblings ...)
2016-08-11 21:04 ` [PATCH 24/28] media: usb: stkwebcam: stk-webcam: " Wolfram Sang
@ 2016-08-11 21:04 ` Wolfram Sang
2016-08-11 21:04 ` [PATCH 26/28] media: usb: tm6000: tm6000-video: " Wolfram Sang
` (3 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:04 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/tm6000/tm6000-dvb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/usb/tm6000/tm6000-dvb.c b/drivers/media/usb/tm6000/tm6000-dvb.c
index 095f5db1a790f9..0426b210383b7c 100644
--- a/drivers/media/usb/tm6000/tm6000-dvb.c
+++ b/drivers/media/usb/tm6000/tm6000-dvb.c
@@ -129,10 +129,8 @@ static int tm6000_start_stream(struct tm6000_core *dev)
}
dvb->bulk_urb = usb_alloc_urb(0, GFP_KERNEL);
- if (dvb->bulk_urb == NULL) {
- printk(KERN_ERR "tm6000: couldn't allocate urb\n");
+ if (dvb->bulk_urb == NULL)
return -ENOMEM;
- }
pipe = usb_rcvbulkpipe(dev->udev, dev->bulk_in.endp->desc.bEndpointAddress
& USB_ENDPOINT_NUMBER_MASK);
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 26/28] media: usb: tm6000: tm6000-video: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (24 preceding siblings ...)
2016-08-11 21:04 ` [PATCH 25/28] media: usb: tm6000: tm6000-dvb: " Wolfram Sang
@ 2016-08-11 21:04 ` Wolfram Sang
2016-08-11 21:04 ` [PATCH 27/28] media: usb: usbvision: usbvision-core: " Wolfram Sang
` (2 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:04 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/tm6000/tm6000-video.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/usb/tm6000/tm6000-video.c b/drivers/media/usb/tm6000/tm6000-video.c
index fa5e8bda2ae4a7..dee7e7d3d47d71 100644
--- a/drivers/media/usb/tm6000/tm6000-video.c
+++ b/drivers/media/usb/tm6000/tm6000-video.c
@@ -635,7 +635,6 @@ static int tm6000_prepare_isoc(struct tm6000_core *dev)
for (i = 0; i < dev->isoc_ctl.num_bufs; i++) {
urb = usb_alloc_urb(max_packets, GFP_KERNEL);
if (!urb) {
- tm6000_err("cannot alloc isoc_ctl.urb %i\n", i);
tm6000_uninit_isoc(dev);
usb_free_urb(urb);
return -ENOMEM;
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 27/28] media: usb: usbvision: usbvision-core: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (25 preceding siblings ...)
2016-08-11 21:04 ` [PATCH 26/28] media: usb: tm6000: tm6000-video: " Wolfram Sang
@ 2016-08-11 21:04 ` Wolfram Sang
2016-08-11 21:04 ` [PATCH 28/28] media: usb: zr364xx: zr364xx: " Wolfram Sang
2016-08-30 17:14 ` [PATCH 00/28] media: " Greg KH
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:04 UTC (permalink / raw)
To: linux-usb; +Cc: Wolfram Sang, Hans Verkuil, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/usbvision/usbvision-core.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/media/usb/usbvision/usbvision-core.c b/drivers/media/usb/usbvision/usbvision-core.c
index 52ac4391582c49..c23bf73a68ea97 100644
--- a/drivers/media/usb/usbvision/usbvision-core.c
+++ b/drivers/media/usb/usbvision/usbvision-core.c
@@ -2303,11 +2303,8 @@ int usbvision_init_isoc(struct usb_usbvision *usbvision)
struct urb *urb;
urb = usb_alloc_urb(USBVISION_URB_FRAMES, GFP_KERNEL);
- if (urb == NULL) {
- dev_err(&usbvision->dev->dev,
- "%s: usb_alloc_urb() failed\n", __func__);
+ if (urb == NULL)
return -ENOMEM;
- }
usbvision->sbuf[buf_idx].urb = urb;
usbvision->sbuf[buf_idx].data =
usb_alloc_coherent(usbvision->dev,
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 28/28] media: usb: zr364xx: zr364xx: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (26 preceding siblings ...)
2016-08-11 21:04 ` [PATCH 27/28] media: usb: usbvision: usbvision-core: " Wolfram Sang
@ 2016-08-11 21:04 ` Wolfram Sang
2016-08-30 17:14 ` [PATCH 00/28] media: " Greg KH
28 siblings, 0 replies; 30+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:04 UTC (permalink / raw)
To: linux-usb
Cc: Wolfram Sang, Antoine Jacquet, Mauro Carvalho Chehab, linux-media
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/media/usb/zr364xx/zr364xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/usb/zr364xx/zr364xx.c b/drivers/media/usb/zr364xx/zr364xx.c
index 7433ba5c4bad8b..cc128db85723c9 100644
--- a/drivers/media/usb/zr364xx/zr364xx.c
+++ b/drivers/media/usb/zr364xx/zr364xx.c
@@ -1045,10 +1045,8 @@ static int zr364xx_start_readpipe(struct zr364xx_camera *cam)
pipe_info->state = 1;
pipe_info->err_count = 0;
pipe_info->stream_urb = usb_alloc_urb(0, GFP_KERNEL);
- if (!pipe_info->stream_urb) {
- dev_err(&cam->udev->dev, "ReadStream: Unable to alloc URB\n");
+ if (!pipe_info->stream_urb)
return -ENOMEM;
- }
/* transfer buffer allocated in board_init */
usb_fill_bulk_urb(pipe_info->stream_urb, cam->udev,
pipe,
--
2.8.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 00/28] media: don't print error when allocating urb fails
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
` (27 preceding siblings ...)
2016-08-11 21:04 ` [PATCH 28/28] media: usb: zr364xx: zr364xx: " Wolfram Sang
@ 2016-08-30 17:14 ` Greg KH
28 siblings, 0 replies; 30+ messages in thread
From: Greg KH @ 2016-08-30 17:14 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-usb, linux-media
On Thu, Aug 11, 2016 at 11:03:36PM +0200, Wolfram Sang wrote:
> This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses
> kmalloc which already prints enough information on failure. So, let's simply
> remove those "allocation failed" messages from drivers like we did already for
> other -ENOMEM cases. gkh acked this approach when we talked about it at LCJ in
> Tokyo a few weeks ago.
I've taken all of these through the usb tree given the delay in response
from the media developers :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 30+ messages in thread