All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Li <ayaka@soulik.info>
To: linux-usb@vger.kernel.org
Cc: johnyoun@synopsys.com, gregkh@linuxfoundation.org,
	robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, eddie.cai@rock-chips.com,
	randy.li@rock-chips.com, kishon@ti.com,
	linux-kernel@vger.kernel.org, heiko@sntech.de,
	linux-rockchip@lists.infradead.org, Randy Li <ayaka@soulik.info>
Subject: [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup
Date: Sun, 21 Aug 2016 15:56:43 +0800	[thread overview]
Message-ID: <1471766205-12940-3-git-send-email-ayaka@soulik.info> (raw)
In-Reply-To: <1471766205-12940-1-git-send-email-ayaka@soulik.info>

It is a hardware bug in RK3288, the only way to solve it is to
reset the phy.

Signed-off-by: Randy Li <ayaka@soulik.info>
---
 .../devicetree/bindings/phy/rockchip-usb-phy.txt     |  3 +++
 drivers/phy/phy-rockchip-usb.c                       | 20 ++++++++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt
index cc6be96..57dc388 100644
--- a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt
+++ b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt
@@ -27,6 +27,9 @@ Optional Properties:
 - clocks : phandle + clock specifier for the phy clocks
 - clock-names: string, clock name, must be "phyclk"
 - #clock-cells: for users of the phy-pll, should be 0
+- reset-names: Only allow the following entries:
+ - phy-reset
+- resets: Must contain an entry for each entry in reset-names.
 
 Example:
 
diff --git a/drivers/phy/phy-rockchip-usb.c b/drivers/phy/phy-rockchip-usb.c
index 2a7381f..734987f 100644
--- a/drivers/phy/phy-rockchip-usb.c
+++ b/drivers/phy/phy-rockchip-usb.c
@@ -29,6 +29,7 @@
 #include <linux/reset.h>
 #include <linux/regmap.h>
 #include <linux/mfd/syscon.h>
+#include <linux/delay.h>
 
 static int enable_usb_uart;
 
@@ -64,6 +65,7 @@ struct rockchip_usb_phy {
 	struct clk_hw	clk480m_hw;
 	struct phy	*phy;
 	bool		uart_enabled;
+	struct reset_control *reset;
 };
 
 static int rockchip_usb_phy_power(struct rockchip_usb_phy *phy,
@@ -144,9 +146,23 @@ static int rockchip_usb_phy_power_on(struct phy *_phy)
 	return clk_prepare_enable(phy->clk480m);
 }
 
+static int rockchip_usb_phy_reset(struct phy *_phy)
+{
+	struct rockchip_usb_phy *phy = phy_get_drvdata(_phy);
+
+	if (phy->reset) {
+		reset_control_assert(phy->reset);
+		udelay(10);
+		reset_control_deassert(phy->reset);
+	}
+
+	return 0;
+}
+
 static const struct phy_ops ops = {
 	.power_on	= rockchip_usb_phy_power_on,
 	.power_off	= rockchip_usb_phy_power_off,
+	.reset		= rockchip_usb_phy_reset,
 	.owner		= THIS_MODULE,
 };
 
@@ -185,6 +201,10 @@ static int rockchip_usb_phy_init(struct rockchip_usb_phy_base *base,
 		return -EINVAL;
 	}
 
+	rk_phy->reset = of_reset_control_get(child, "phy-reset");
+	if (IS_ERR(rk_phy->reset))
+		rk_phy->reset = NULL;
+
 	rk_phy->reg_offset = reg_offset;
 
 	rk_phy->clk = of_clk_get_by_name(child, "phyclk");
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Randy Li <ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
To: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
	johnyoun-HKixBCOQz3hWk0Htik3J/w@public.gmane.org,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	Randy Li <ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>,
	randy.li-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kishon-l0cyMroinI0@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	eddie.cai-TNX95d0MmH7DzftRWevZcw@public.gmane.org
Subject: [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup
Date: Sun, 21 Aug 2016 15:56:43 +0800	[thread overview]
Message-ID: <1471766205-12940-3-git-send-email-ayaka@soulik.info> (raw)
In-Reply-To: <1471766205-12940-1-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>

It is a hardware bug in RK3288, the only way to solve it is to
reset the phy.

Signed-off-by: Randy Li <ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
---
 .../devicetree/bindings/phy/rockchip-usb-phy.txt     |  3 +++
 drivers/phy/phy-rockchip-usb.c                       | 20 ++++++++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt
index cc6be96..57dc388 100644
--- a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt
+++ b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt
@@ -27,6 +27,9 @@ Optional Properties:
 - clocks : phandle + clock specifier for the phy clocks
 - clock-names: string, clock name, must be "phyclk"
 - #clock-cells: for users of the phy-pll, should be 0
+- reset-names: Only allow the following entries:
+ - phy-reset
+- resets: Must contain an entry for each entry in reset-names.
 
 Example:
 
diff --git a/drivers/phy/phy-rockchip-usb.c b/drivers/phy/phy-rockchip-usb.c
index 2a7381f..734987f 100644
--- a/drivers/phy/phy-rockchip-usb.c
+++ b/drivers/phy/phy-rockchip-usb.c
@@ -29,6 +29,7 @@
 #include <linux/reset.h>
 #include <linux/regmap.h>
 #include <linux/mfd/syscon.h>
+#include <linux/delay.h>
 
 static int enable_usb_uart;
 
@@ -64,6 +65,7 @@ struct rockchip_usb_phy {
 	struct clk_hw	clk480m_hw;
 	struct phy	*phy;
 	bool		uart_enabled;
+	struct reset_control *reset;
 };
 
 static int rockchip_usb_phy_power(struct rockchip_usb_phy *phy,
@@ -144,9 +146,23 @@ static int rockchip_usb_phy_power_on(struct phy *_phy)
 	return clk_prepare_enable(phy->clk480m);
 }
 
+static int rockchip_usb_phy_reset(struct phy *_phy)
+{
+	struct rockchip_usb_phy *phy = phy_get_drvdata(_phy);
+
+	if (phy->reset) {
+		reset_control_assert(phy->reset);
+		udelay(10);
+		reset_control_deassert(phy->reset);
+	}
+
+	return 0;
+}
+
 static const struct phy_ops ops = {
 	.power_on	= rockchip_usb_phy_power_on,
 	.power_off	= rockchip_usb_phy_power_off,
+	.reset		= rockchip_usb_phy_reset,
 	.owner		= THIS_MODULE,
 };
 
@@ -185,6 +201,10 @@ static int rockchip_usb_phy_init(struct rockchip_usb_phy_base *base,
 		return -EINVAL;
 	}
 
+	rk_phy->reset = of_reset_control_get(child, "phy-reset");
+	if (IS_ERR(rk_phy->reset))
+		rk_phy->reset = NULL;
+
 	rk_phy->reg_offset = reg_offset;
 
 	rk_phy->clk = of_clk_get_by_name(child, "phyclk");
-- 
2.7.4

  parent reply	other threads:[~2016-08-21  7:57 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-30 20:17 [PATCH v2 0/2] Patches to fix remote wakeup on rk3288 dwc2 "host" port Douglas Anderson
2015-10-30 20:17 ` Douglas Anderson
2015-10-30 20:17 ` Douglas Anderson
2015-10-30 20:17 ` [PATCH v2 1/2] usb: dwc2: optionally assert phy "full reset" when waking up Douglas Anderson
2015-11-02 16:12   ` Rob Herring
2015-11-02 16:12     ` Rob Herring
2015-11-02 16:22     ` Doug Anderson
2015-11-02 17:16       ` Rob Herring
2015-11-02 17:48         ` Doug Anderson
2015-11-02 17:48           ` Doug Anderson
     [not found]   ` <1446236275-12698-2-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-07-19 12:00     ` [PATCH v3 0/2] usb: dwc2: fix the usb host for host port at RK3288 Randy Li
2016-07-19 12:05     ` [PATCH 1/2] usb: dwc2: optionally assert phy "full reset" when waking up Randy Li
     [not found]       ` <1468929933-6971-1-git-send-email-randy.li-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-07-20  1:36         ` Rob Herring
2016-07-20  2:54           ` Randy Li
     [not found]             ` <0c61cf90-6fea-19ce-ce74-91648cb2d921-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-07-21 20:48               ` Rob Herring
2016-08-15 22:19         ` John Youn
     [not found]           ` <38019f37-8d68-b7c1-a5b1-b34ffbadf461-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2016-08-16  1:10             ` Randy Li
     [not found]               ` <39f96d60-09c0-c71f-b6e3-c84c8304e5f6-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-16  2:33                 ` John Youn
2016-08-20 20:32                   ` [PATCH 0/4 v4] usb: dwc2: fix the usb host for host port at RK32 Randy Li
2016-08-20 20:32                     ` Randy Li
2016-08-20 20:32                     ` [PATCH 1/4] phy: Add reset callback Randy Li
2016-08-20 20:32                     ` [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup Randy Li
2016-08-20 20:32                       ` Randy Li
2016-08-22 11:47                       ` Kishon Vijay Abraham I
2016-08-22 11:47                         ` Kishon Vijay Abraham I
2016-08-22 13:00                         ` Heiko Stübner
2016-08-29  9:32                           ` Kishon Vijay Abraham I
2016-08-29  9:32                             ` Kishon Vijay Abraham I
2016-08-20 20:32                     ` [PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li
2016-08-20 21:30                       ` Sergei Shtylyov
2016-08-21  7:56                         ` [PATCH 0/4 v5] usb: dwc2: fix the usb host for host port at RK32 Randy Li
2016-08-21  7:56                           ` Randy Li
2016-08-21  7:56                           ` [PATCH 1/4] phy: Add reset callback Randy Li
2016-08-21  7:56                           ` Randy Li [this message]
2016-08-21  7:56                             ` [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup Randy Li
2016-08-23 17:53                             ` Rob Herring
2016-08-23 17:53                               ` Rob Herring
2016-08-21  7:56                           ` [PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li
2016-08-21  7:56                           ` [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li
2016-08-21 11:06                             ` Sergei Shtylyov
2016-08-21 12:19                               ` ayaka
2016-08-21 12:19                                 ` ayaka
2016-08-22 10:30                                 ` Sergei Shtylyov
2016-08-22 10:30                                   ` Sergei Shtylyov
2016-08-21 19:31                         ` [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li
2016-08-21 19:31                           ` [RESEND PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li
2016-08-21 19:31                             ` Randy Li
2016-08-23 20:46                           ` [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform John Youn
2016-08-23 20:46                             ` John Youn
2016-08-24  8:54                             ` Randy Li
2016-08-24  8:54                               ` Randy Li
2016-08-25 18:23                               ` John Youn
2016-08-25 18:23                                 ` John Youn
2016-08-29  7:51                                 ` Felipe Balbi
2016-08-29  7:51                                   ` Felipe Balbi
2016-08-29 18:24                                   ` John Youn
2016-08-29 18:24                                     ` John Youn
2016-08-20 20:32                     ` [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li
2016-07-19 12:05     ` [PATCH 2/2] " Randy Li
2015-10-30 20:17 ` [PATCH v2 " Douglas Anderson
2015-10-30 20:17   ` Douglas Anderson
2016-09-08 14:27 [PATCH 0/4] the fix for the USB HOST1 at rk3288 platform Randy Li
2016-09-08 14:27 ` [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup Randy Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471766205-12940-3-git-send-email-ayaka@soulik.info \
    --to=ayaka@soulik.info \
    --cc=devicetree@vger.kernel.org \
    --cc=eddie.cai@rock-chips.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=johnyoun@synopsys.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=randy.li@rock-chips.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.