* [PATCH net-next] net: xfrm: Change u32 sysctl entries to use proc_douintvec
@ 2016-09-07 0:09 Subash Abhinov Kasiviswanathan
2016-09-08 0:25 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Subash Abhinov Kasiviswanathan @ 2016-09-07 0:09 UTC (permalink / raw)
To: netdev, davem, steffen.klassert; +Cc: Subash Abhinov Kasiviswanathan
proc_dointvec limits the values to INT_MAX in u32 sysctl entries.
proc_douintvec allows to write upto UINT_MAX.
Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
---
net/xfrm/xfrm_sysctl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/xfrm/xfrm_sysctl.c b/net/xfrm/xfrm_sysctl.c
index 05a6e3d..35a7e79 100644
--- a/net/xfrm/xfrm_sysctl.c
+++ b/net/xfrm/xfrm_sysctl.c
@@ -17,13 +17,13 @@ static struct ctl_table xfrm_table[] = {
.procname = "xfrm_aevent_etime",
.maxlen = sizeof(u32),
.mode = 0644,
- .proc_handler = proc_dointvec
+ .proc_handler = proc_douintvec
},
{
.procname = "xfrm_aevent_rseqth",
.maxlen = sizeof(u32),
.mode = 0644,
- .proc_handler = proc_dointvec
+ .proc_handler = proc_douintvec
},
{
.procname = "xfrm_larval_drop",
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: xfrm: Change u32 sysctl entries to use proc_douintvec
2016-09-07 0:09 [PATCH net-next] net: xfrm: Change u32 sysctl entries to use proc_douintvec Subash Abhinov Kasiviswanathan
@ 2016-09-08 0:25 ` David Miller
2016-09-08 5:51 ` Steffen Klassert
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2016-09-08 0:25 UTC (permalink / raw)
To: subashab; +Cc: netdev, steffen.klassert
From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Date: Tue, 6 Sep 2016 18:09:31 -0600
> proc_dointvec limits the values to INT_MAX in u32 sysctl entries.
> proc_douintvec allows to write upto UINT_MAX.
>
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
I am assuming Steffen will pick this up.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: xfrm: Change u32 sysctl entries to use proc_douintvec
2016-09-08 0:25 ` David Miller
@ 2016-09-08 5:51 ` Steffen Klassert
2016-09-08 6:18 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Steffen Klassert @ 2016-09-08 5:51 UTC (permalink / raw)
To: David Miller; +Cc: subashab, netdev
On Wed, Sep 07, 2016 at 05:25:18PM -0700, David Miller wrote:
> From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
> Date: Tue, 6 Sep 2016 18:09:31 -0600
>
> > proc_dointvec limits the values to INT_MAX in u32 sysctl entries.
> > proc_douintvec allows to write upto UINT_MAX.
> >
> > Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
>
> I am assuming Steffen will pick this up.
proc_douintvec is not in the ipsec-next tree. The ipsec-next
tree is currently based on net-next from Aug 9. The patch
that introduces proc_douintvec came in on Aug 25.
I can take it after the pull request for ipsec-next, that
I plan to do today. Alternatively, you can take it directly
into net-next. It does not interfere anything that I
have in ipsec-next. In case you want to take it directly:
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: xfrm: Change u32 sysctl entries to use proc_douintvec
2016-09-08 5:51 ` Steffen Klassert
@ 2016-09-08 6:18 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-09-08 6:18 UTC (permalink / raw)
To: steffen.klassert; +Cc: subashab, netdev
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Thu, 8 Sep 2016 07:51:17 +0200
> On Wed, Sep 07, 2016 at 05:25:18PM -0700, David Miller wrote:
>> From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
>> Date: Tue, 6 Sep 2016 18:09:31 -0600
>>
>> > proc_dointvec limits the values to INT_MAX in u32 sysctl entries.
>> > proc_douintvec allows to write upto UINT_MAX.
>> >
>> > Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
>>
>> I am assuming Steffen will pick this up.
>
> proc_douintvec is not in the ipsec-next tree. The ipsec-next
> tree is currently based on net-next from Aug 9. The patch
> that introduces proc_douintvec came in on Aug 25.
>
> I can take it after the pull request for ipsec-next, that
> I plan to do today. Alternatively, you can take it directly
> into net-next. It does not interfere anything that I
> have in ipsec-next. In case you want to take it directly:
>
> Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Ok, I've applied it to net-next then, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-08 6:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-07 0:09 [PATCH net-next] net: xfrm: Change u32 sysctl entries to use proc_douintvec Subash Abhinov Kasiviswanathan
2016-09-08 0:25 ` David Miller
2016-09-08 5:51 ` Steffen Klassert
2016-09-08 6:18 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.