All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cedric Bosdonnat <cbosdonnat@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel@lists.xen.org
Subject: Re: per-domain logging
Date: Thu, 15 Sep 2016 17:41:38 +0200	[thread overview]
Message-ID: <1473954098.6008.8.camel@suse.com> (raw)
In-Reply-To: <20160915151102.GO15958@citrix.com>

On Thu, 2016-09-15 at 16:11 +0100, Wei Liu wrote:
> On Thu, Sep 15, 2016 at 03:50:25PM +0100, Wei Liu wrote:
> > 
> > CC Ian who might have some ideas on this.
> > 
> > On Wed, Sep 14, 2016 at 04:22:24PM +0200, Cedric Bosdonnat wrote:
> > > 
> > > Hi all,
> > > 
> > > I wanted to get libvirt's libxl driver have per-domain logs like all other drivers. After
> > > looking at the libxl and XenToolLogger it seems I'll need to add the feature in either libxl
> > > XenToolLogger. Would anyone already have an idea how best to add API to allow this?
> > > 
> 
> Can you briefly describe how other drivers do per-domain logging?

For example, the qemu driver is storing all logging of domain X in /var/log/libvirt/qemu/X.log file.
So far all libxl logs are going to /var/log/libvirt/libxl/libxl-driver.log.

> Basically one libxl_ctx corresponds to one logger. I guess you don't
> want multiple libxl_ctx, right?

Indeed, we have on libxl_ctx for the driver, not one per domain.

> IIRC there is already logfile abstraction inside libvirt -- can you just
> pass in a libvirt logfile fd and try to demux there?

The abstraction we have is something similar to the XenToolLogger, not
something abstracting the log files. Even if we had that, how could we demux since there is
no domain name in the libxl messages.

--
Cedric

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-09-15 15:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-14 14:22 per-domain logging Cedric Bosdonnat
2016-09-15 14:50 ` Wei Liu
2016-09-15 15:11   ` Wei Liu
2016-09-15 15:41     ` Cedric Bosdonnat [this message]
2016-09-19 15:23       ` Ian Jackson
2016-09-19 16:53         ` Konrad Rzeszutek Wilk
2016-10-04  9:14         ` Cedric Bosdonnat
2016-10-07 14:09           ` Wei Liu
2016-10-07 15:37             ` Ian Jackson
2016-10-10  7:05               ` Cedric Bosdonnat
2016-10-10  7:03             ` Cedric Bosdonnat
2016-10-10 10:06               ` Wei Liu
2016-10-13  9:28                 ` Cedric Bosdonnat
2016-10-13  9:41                   ` Wei Liu
2016-11-09 10:27                     ` Cedric Bosdonnat
2016-11-11  1:51                       ` Wei Liu
2016-11-11 11:22                       ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473954098.6008.8.camel@suse.com \
    --to=cbosdonnat@suse.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.