From: Cedric Bosdonnat <cbosdonnat@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org
Subject: Re: per-domain logging
Date: Wed, 09 Nov 2016 11:27:34 +0100 [thread overview]
Message-ID: <1478687254.4314.5.camel@suse.com> (raw)
In-Reply-To: <20161013094146.GE3687@citrix.com>
Hi Wei, Ian,
I now have a big lot of changes to use the LOG*D family through the libxl code.
What should be the best way to submit that for review? I guess a giant commit
won't be too easy to handle for review and maintenance, maybe I should have one
commit per changed file... any opinion on that?
--
Cedric
On Thu, 2016-10-13 at 10:41 +0100, Wei Liu wrote:
> On Thu, Oct 13, 2016 at 11:28:21AM +0200, Cedric Bosdonnat wrote:
> > Hi Wei, Ian,
> >
> > In quite a number of places, the domid we have in the function calling LOG*
> > may be the one of a stubdom. In the log we want to output the domid of the
> > domain the user knows about. Would there be a way to get it?
> >
> > An example of that is do_pci_add. It has a libxl_is_stubdom call, suggesting
> > that domid may not be the real domain id. An I wonder if there are other
> > places where domid may be the one of a stubdom and I don't know it.
> >
>
> The third argument of libxl_is_stubdom can be used to retrieve the
> target domid.
>
> If you find other places where you need to get the domid, please let me
> know. I believe there are some fields embedded in various structs that
> we can interrogate.
>
> Wei.
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-11-09 10:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 14:22 per-domain logging Cedric Bosdonnat
2016-09-15 14:50 ` Wei Liu
2016-09-15 15:11 ` Wei Liu
2016-09-15 15:41 ` Cedric Bosdonnat
2016-09-19 15:23 ` Ian Jackson
2016-09-19 16:53 ` Konrad Rzeszutek Wilk
2016-10-04 9:14 ` Cedric Bosdonnat
2016-10-07 14:09 ` Wei Liu
2016-10-07 15:37 ` Ian Jackson
2016-10-10 7:05 ` Cedric Bosdonnat
2016-10-10 7:03 ` Cedric Bosdonnat
2016-10-10 10:06 ` Wei Liu
2016-10-13 9:28 ` Cedric Bosdonnat
2016-10-13 9:41 ` Wei Liu
2016-11-09 10:27 ` Cedric Bosdonnat [this message]
2016-11-11 1:51 ` Wei Liu
2016-11-11 11:22 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478687254.4314.5.camel@suse.com \
--to=cbosdonnat@suse.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.