From: Ian Jackson <ian.jackson@eu.citrix.com>
To: Cedric Bosdonnat <cbosdonnat@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
Subject: Re: per-domain logging
Date: Mon, 19 Sep 2016 16:23:06 +0100 [thread overview]
Message-ID: <22496.730.407667.327755@mariner.uk.xensource.com> (raw)
In-Reply-To: <1473954098.6008.8.camel@suse.com>
Cedric Bosdonnat writes ("Re: [Xen-devel] per-domain logging"):
> On Thu, 2016-09-15 at 16:11 +0100, Wei Liu wrote:
> > IIRC there is already logfile abstraction inside libvirt -- can you just
> > pass in a libvirt logfile fd and try to demux there?
>
> The abstraction we have is something similar to the XenToolLogger,
> not something abstracting the log files. Even if we had that, how
> could we demux since there is no domain name in the libxl messages.
Right.
It's not trivial to change the xtl API because there is no
negotiation, just a vops structure. I can think of a way to do it,
but do we want to make all xtl logger users (that is, all generators
of log messages) pass a domid ?
Do we want to extend this to other information ? (Not sure _what_
other information.)
Alternatively, we could have libxl (and perhaps libxc) put the domid
in a standard format in the message, so it could be extracted ?
However we do it, we would have to add a domid to every LOG call in
libxl.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-19 15:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 14:22 per-domain logging Cedric Bosdonnat
2016-09-15 14:50 ` Wei Liu
2016-09-15 15:11 ` Wei Liu
2016-09-15 15:41 ` Cedric Bosdonnat
2016-09-19 15:23 ` Ian Jackson [this message]
2016-09-19 16:53 ` Konrad Rzeszutek Wilk
2016-10-04 9:14 ` Cedric Bosdonnat
2016-10-07 14:09 ` Wei Liu
2016-10-07 15:37 ` Ian Jackson
2016-10-10 7:05 ` Cedric Bosdonnat
2016-10-10 7:03 ` Cedric Bosdonnat
2016-10-10 10:06 ` Wei Liu
2016-10-13 9:28 ` Cedric Bosdonnat
2016-10-13 9:41 ` Wei Liu
2016-11-09 10:27 ` Cedric Bosdonnat
2016-11-11 1:51 ` Wei Liu
2016-11-11 11:22 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22496.730.407667.327755@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=cbosdonnat@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.