From: Bernd Petrovitsch <bernd@petrovitsch.priv.at>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Steven Rostedt <rostedt@goodmis.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Olof Johansson <olof@lxom.net>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
"David S . Miller" <davem@davemloft.net>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Paul Lawrence <paullawrence@google.com>,
Sandipan Das <sandipan@linux.vnet.ibm.com>,
Andrey Konovalov <andreyknvl@google.com>,
David Woodhouse <dwmw2@infradead.org>,
Will Deacon <will.deacon@arm.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Paul Burton <paul.burton@mips.com>,
David Rientjes <rientjes@google.com>, Willy Tarreau <w@1wt.eu>,
Martin Sebor <msebor@gmail.com>,
Christopher Li <sparse@chrisli.org>,
Jonathan Corbet <corbet@lwn.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Joe Perches <joe@perches.com>, Arnd Bergmann <arnd@arndb.de>,
Dominique Martinet <asmadeus@codewreck.org>,
Stefan Agner <stefan@agner.ch>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-doc@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-sparse@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)
Date: Mon, 22 Oct 2018 12:45:03 +0200 [thread overview]
Message-ID: <1474d995-1b5a-2efb-f077-33eb4a5d9e31@petrovitsch.priv.at> (raw)
In-Reply-To: <20181022102743.nua5fgbscyeymzal@mwanda>
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
On 22/10/18 12:27, Dan Carpenter wrote:
[...]
> What does that even mean? Use both the attribute and the comment until
> Eclipse is updated?
>
> case 3:
> frob();
> __fall_through; /* fall through */
> case 4:
>
> That seems like a wrong idea...
It's more like
---- snip ----
case 3:
frob();
__fall_through;
/* no break - fall through */
case 4:
---- snip ----
as "eclipse" doesn't accept anything else.
And yes, it's far from "beautiful" but I hadn't time to dig into
eclipses innards to fix that.
MfG,
Bernd
--
"I dislike type abstraction if it has no real reason. And saving
on typing is not a good reason - if your typing speed is the main
issue when you're coding, you're doing something seriously wrong."
- Linus Torvalds
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 2513 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Bernd Petrovitsch <bernd@petrovitsch.priv.at>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Steven Rostedt <rostedt@goodmis.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Olof Johansson <olof@lxom.net>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
"David S . Miller" <davem@davemloft.net>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Paul Lawrence <paullawrence@google.com>,
Sandipan Das <sandipan@linux.vnet.ibm.com>Andre
Subject: Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)
Date: Mon, 22 Oct 2018 12:45:03 +0200 [thread overview]
Message-ID: <1474d995-1b5a-2efb-f077-33eb4a5d9e31@petrovitsch.priv.at> (raw)
In-Reply-To: <20181022102743.nua5fgbscyeymzal@mwanda>
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
On 22/10/18 12:27, Dan Carpenter wrote:
[...]
> What does that even mean? Use both the attribute and the comment until
> Eclipse is updated?
>
> case 3:
> frob();
> __fall_through; /* fall through */
> case 4:
>
> That seems like a wrong idea...
It's more like
---- snip ----
case 3:
frob();
__fall_through;
/* no break - fall through */
case 4:
---- snip ----
as "eclipse" doesn't accept anything else.
And yes, it's far from "beautiful" but I hadn't time to dig into
eclipses innards to fix that.
MfG,
Bernd
--
"I dislike type abstraction if it has no real reason. And saving
on typing is not a good reason - if your typing speed is the main
issue when you're coding, you're doing something seriously wrong."
- Linus Torvalds
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 2513 bytes --]
next prev parent reply other threads:[~2018-10-22 10:47 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-21 17:14 [PATCH 0/2] Compiler Attributes: __fallthrough Miguel Ojeda
2018-10-21 17:14 ` Miguel Ojeda
2018-10-21 17:14 ` [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1) Miguel Ojeda
2018-10-21 17:14 ` Miguel Ojeda
2018-10-21 17:14 ` Miguel Ojeda
2018-10-21 22:27 ` Theodore Y. Ts'o
2018-10-21 22:27 ` Theodore Y. Ts'o
2018-10-22 9:26 ` Miguel Ojeda
2018-10-22 9:34 ` Kees Cook
2018-10-22 9:34 ` Kees Cook
2018-10-22 9:41 ` Miguel Ojeda
2018-10-22 9:41 ` Miguel Ojeda
2018-10-22 9:43 ` Miguel Ojeda
2018-10-22 9:43 ` Miguel Ojeda
2018-10-22 17:17 ` Nick Desaulniers
2018-10-22 17:17 ` Nick Desaulniers
2018-10-22 20:59 ` Miguel Ojeda
2018-10-22 20:59 ` Miguel Ojeda
2018-10-22 10:53 ` Kees Cook
2018-10-22 10:53 ` Kees Cook
2018-10-22 11:24 ` Miguel Ojeda
2018-10-22 11:24 ` Miguel Ojeda
2018-10-22 13:39 ` Miguel Ojeda
2018-10-22 13:39 ` Miguel Ojeda
2018-10-22 17:23 ` Nick Desaulniers
2018-10-22 17:23 ` Nick Desaulniers
2018-10-22 9:41 ` Bernd Petrovitsch
2018-10-22 10:27 ` Dan Carpenter
2018-10-22 10:27 ` Dan Carpenter
2018-10-22 10:45 ` Bernd Petrovitsch [this message]
2018-10-22 10:45 ` Bernd Petrovitsch
2018-10-22 10:53 ` Dan Carpenter
2018-10-22 10:53 ` Dan Carpenter
2018-10-22 11:07 ` Miguel Ojeda
2018-10-22 11:07 ` Miguel Ojeda
2018-10-22 17:49 ` Bernd Petrovitsch
2018-10-22 17:49 ` Bernd Petrovitsch
2018-10-22 17:49 ` Bernd Petrovitsch
2018-10-22 17:54 ` Nick Desaulniers
2018-10-22 17:54 ` Nick Desaulniers
2018-10-22 18:13 ` Bernd Petrovitsch
2018-10-22 18:13 ` Bernd Petrovitsch
2018-10-22 19:56 ` Nick Desaulniers
2018-10-22 21:34 ` Miguel Ojeda
2018-10-22 21:34 ` Miguel Ojeda
2018-10-22 17:26 ` Nick Desaulniers
2018-10-22 17:26 ` Nick Desaulniers
2018-10-22 0:42 ` Matthew Wilcox
2018-10-22 0:42 ` Matthew Wilcox
2018-10-22 6:58 ` Theodore Y. Ts'o
2018-10-22 6:58 ` Theodore Y. Ts'o
2018-10-22 7:05 ` Willy Tarreau
2018-10-22 9:32 ` Miguel Ojeda
2018-10-22 9:32 ` Miguel Ojeda
2018-10-22 12:07 ` Luc Van Oostenryck
2018-10-22 12:07 ` Luc Van Oostenryck
2018-10-22 12:09 ` Miguel Ojeda
2018-10-22 12:09 ` Miguel Ojeda
2018-10-22 17:36 ` Nick Desaulniers
2018-10-22 17:36 ` Nick Desaulniers
2018-10-22 21:17 ` Miguel Ojeda
2018-10-22 21:17 ` Miguel Ojeda
2018-10-21 17:14 ` [PATCH 2/2] Compiler Attributes: auxdisplay: panel: use __fallthrough Miguel Ojeda
2018-10-21 17:14 ` Miguel Ojeda
2018-10-21 18:11 ` Joe Perches
2018-10-21 18:11 ` Joe Perches
2018-10-22 9:51 ` Miguel Ojeda
2018-10-22 9:51 ` Miguel Ojeda
2018-10-22 15:48 ` Joe Perches
2018-10-22 15:48 ` Joe Perches
2018-10-22 14:10 ` Kees Cook
2018-10-22 14:10 ` Kees Cook
[not found] ` <20181023053542.lsklua2p3lnbkqir@mwanda>
2018-11-02 10:49 ` Miguel Ojeda
2018-11-02 10:49 ` Miguel Ojeda
2018-11-02 10:56 ` Miguel Ojeda
2018-11-02 10:56 ` Miguel Ojeda
2018-10-21 18:29 ` [PATCH 0/2] Compiler Attributes: __fallthrough Greg Kroah-Hartman
2018-10-21 18:29 ` Greg Kroah-Hartman
2018-10-21 18:52 ` Joe Perches
2018-10-21 18:52 ` Joe Perches
2018-10-22 5:27 ` Dan Carpenter
2018-10-22 5:27 ` Dan Carpenter
2018-10-22 9:48 ` Miguel Ojeda
2018-10-22 9:48 ` Miguel Ojeda
2018-10-22 16:54 ` Nick Desaulniers
2018-10-22 16:54 ` Nick Desaulniers
2018-10-22 21:23 ` Miguel Ojeda
2018-10-22 21:23 ` Miguel Ojeda
2018-10-23 5:43 ` Dan Carpenter
2018-10-23 5:43 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474d995-1b5a-2efb-f077-33eb4a5d9e31@petrovitsch.priv.at \
--to=bernd@petrovitsch.priv.at \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=asmadeus@codewreck.org \
--cc=corbet@lwn.net \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=konstantin@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luc.vanoostenryck@gmail.com \
--cc=mchehab+samsung@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@kernel.org \
--cc=msebor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=olof@lxom.net \
--cc=paul.burton@mips.com \
--cc=paullawrence@google.com \
--cc=pombredanne@nexb.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sandipan@linux.vnet.ibm.com \
--cc=sparse@chrisli.org \
--cc=stefan@agner.ch \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=w@1wt.eu \
--cc=will.deacon@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.