All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernd Petrovitsch <bernd@petrovitsch.priv.at>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
	dan.carpenter@oracle.com, "Theodore Ts'o" <tytso@mit.edu>,
	Greg KH <gregkh@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	adilger.kernel@dilger.ca,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>,
	rostedt@goodmis.org, mchehab+samsung@kernel.org, olof@lxom.net,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Kees Cook <keescook@chromium.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	Paul Lawrence <paullawrence@google.com>,
	sandipan@linux.vnet.ibm.com,
	Andrey Konovalov <andreyknvl@google.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Will Deacon <will.deacon@arm.com>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	paul.burton@mips.com, David Rientjes <rientjes@google.com>,
	Willy Tarreau <w@1wt.eu>,
	msebor@gmail.com, sparse@chrisli.org,
	Jonathan Corbet <corbet@lwn.net>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	joe@perches.com, Arnd Bergmann <arnd@arndb.de>,
	asmadeus@codewreck.org, Stefan Agner <stefan@agner.ch>,
	Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-doc@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-sparse@vger.kernel.org,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)
Date: Mon, 22 Oct 2018 20:13:46 +0200	[thread overview]
Message-ID: <9c52827b-4783-8f39-9030-a166d5436f05@petrovitsch.priv.at> (raw)
In-Reply-To: <CAKwvOdnWkPi_2UJ7VKYZ6cuWi+BDgpEUf+tcrfZLUYawbm+grw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

Hi all!

On 22/10/18 19:54, Nick Desaulniers wrote:
> On Mon, Oct 22, 2018 at 10:50 AM Bernd Petrovitsch
> <bernd@petrovitsch.priv.at> wrote:
[...]
>> PS: clang++ errors with "fallthrough annotation in unreachable code" if
>>     [[fallthrough]] is after an assert(). clang-devs there, please, the
>>     fallthrough doesn't really generated code (I hope;-).
[...]
> Can you send me a link to a simple reproducer in godbolt (godbolt.org)
> and we'll take a look?

Does https://godbolt.org/z/2Y4zIo do it - I'm a godbolt-newbie?

For
----  snip  ----
#include <cassert>

int main(void)
{
  switch (1) {
  default:
    assert(0);
    [[fallthrough]];
  case 1:
    ;
  }
  return 0;
}
----  snip  ----
Just "clang++ -Wimplicit-fallthrough -Werror" it .....

MfG,
	Bernd
-- 
"I dislike type abstraction if it has no real reason. And saving
on typing is not a good reason - if your typing speed is the main
issue when you're coding, you're doing something seriously wrong."
    - Linus Torvalds

[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 2513 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Bernd Petrovitsch <bernd@petrovitsch.priv.at>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
	dan.carpenter@oracle.com, Theodore Ts'o <tytso@mit.edu>,
	Greg KH <gregkh@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	adilger.kernel@dilger.ca,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>,
	rostedt@goodmis.org, mchehab+samsung@kernel.org, olof@lxom.net,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Kees Cook <keescook@chromium.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	Paul Lawrence <paullawrence@google.com>,
	sandipan@linux.vnet.ibm.com,
	Andrey Konovalov <andreyknvl@google.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Will
Subject: Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)
Date: Mon, 22 Oct 2018 20:13:46 +0200	[thread overview]
Message-ID: <9c52827b-4783-8f39-9030-a166d5436f05@petrovitsch.priv.at> (raw)
In-Reply-To: <CAKwvOdnWkPi_2UJ7VKYZ6cuWi+BDgpEUf+tcrfZLUYawbm+grw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

Hi all!

On 22/10/18 19:54, Nick Desaulniers wrote:
> On Mon, Oct 22, 2018 at 10:50 AM Bernd Petrovitsch
> <bernd@petrovitsch.priv.at> wrote:
[...]
>> PS: clang++ errors with "fallthrough annotation in unreachable code" if
>>     [[fallthrough]] is after an assert(). clang-devs there, please, the
>>     fallthrough doesn't really generated code (I hope;-).
[...]
> Can you send me a link to a simple reproducer in godbolt (godbolt.org)
> and we'll take a look?

Does https://godbolt.org/z/2Y4zIo do it - I'm a godbolt-newbie?

For
----  snip  ----
#include <cassert>

int main(void)
{
  switch (1) {
  default:
    assert(0);
    [[fallthrough]];
  case 1:
    ;
  }
  return 0;
}
----  snip  ----
Just "clang++ -Wimplicit-fallthrough -Werror" it .....

MfG,
	Bernd
-- 
"I dislike type abstraction if it has no real reason. And saving
on typing is not a good reason - if your typing speed is the main
issue when you're coding, you're doing something seriously wrong."
    - Linus Torvalds

[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 2513 bytes --]

  reply	other threads:[~2018-10-22 18:16 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-21 17:14 [PATCH 0/2] Compiler Attributes: __fallthrough Miguel Ojeda
2018-10-21 17:14 ` Miguel Ojeda
2018-10-21 17:14 ` [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1) Miguel Ojeda
2018-10-21 17:14   ` Miguel Ojeda
2018-10-21 17:14   ` Miguel Ojeda
2018-10-21 22:27   ` Theodore Y. Ts'o
2018-10-21 22:27     ` Theodore Y. Ts'o
2018-10-22  9:26     ` Miguel Ojeda
2018-10-22  9:34       ` Kees Cook
2018-10-22  9:34         ` Kees Cook
2018-10-22  9:41         ` Miguel Ojeda
2018-10-22  9:41           ` Miguel Ojeda
2018-10-22  9:43           ` Miguel Ojeda
2018-10-22  9:43             ` Miguel Ojeda
2018-10-22 17:17             ` Nick Desaulniers
2018-10-22 17:17               ` Nick Desaulniers
2018-10-22 20:59               ` Miguel Ojeda
2018-10-22 20:59                 ` Miguel Ojeda
2018-10-22 10:53           ` Kees Cook
2018-10-22 10:53             ` Kees Cook
2018-10-22 11:24             ` Miguel Ojeda
2018-10-22 11:24               ` Miguel Ojeda
2018-10-22 13:39               ` Miguel Ojeda
2018-10-22 13:39                 ` Miguel Ojeda
2018-10-22 17:23       ` Nick Desaulniers
2018-10-22 17:23         ` Nick Desaulniers
2018-10-22  9:41     ` Bernd Petrovitsch
2018-10-22 10:27       ` Dan Carpenter
2018-10-22 10:27         ` Dan Carpenter
2018-10-22 10:45         ` Bernd Petrovitsch
2018-10-22 10:45           ` Bernd Petrovitsch
2018-10-22 10:53           ` Dan Carpenter
2018-10-22 10:53             ` Dan Carpenter
2018-10-22 11:07             ` Miguel Ojeda
2018-10-22 11:07               ` Miguel Ojeda
2018-10-22 17:49               ` Bernd Petrovitsch
2018-10-22 17:49                 ` Bernd Petrovitsch
2018-10-22 17:49                 ` Bernd Petrovitsch
2018-10-22 17:54                 ` Nick Desaulniers
2018-10-22 17:54                   ` Nick Desaulniers
2018-10-22 18:13                   ` Bernd Petrovitsch [this message]
2018-10-22 18:13                     ` Bernd Petrovitsch
2018-10-22 19:56                     ` Nick Desaulniers
2018-10-22 21:34                 ` Miguel Ojeda
2018-10-22 21:34                   ` Miguel Ojeda
2018-10-22 17:26             ` Nick Desaulniers
2018-10-22 17:26               ` Nick Desaulniers
2018-10-22  0:42   ` Matthew Wilcox
2018-10-22  0:42     ` Matthew Wilcox
2018-10-22  6:58     ` Theodore Y. Ts'o
2018-10-22  6:58       ` Theodore Y. Ts'o
2018-10-22  7:05       ` Willy Tarreau
2018-10-22  9:32     ` Miguel Ojeda
2018-10-22  9:32       ` Miguel Ojeda
2018-10-22 12:07   ` Luc Van Oostenryck
2018-10-22 12:07     ` Luc Van Oostenryck
2018-10-22 12:09     ` Miguel Ojeda
2018-10-22 12:09       ` Miguel Ojeda
2018-10-22 17:36   ` Nick Desaulniers
2018-10-22 17:36     ` Nick Desaulniers
2018-10-22 21:17     ` Miguel Ojeda
2018-10-22 21:17       ` Miguel Ojeda
2018-10-21 17:14 ` [PATCH 2/2] Compiler Attributes: auxdisplay: panel: use __fallthrough Miguel Ojeda
2018-10-21 17:14   ` Miguel Ojeda
2018-10-21 18:11   ` Joe Perches
2018-10-21 18:11     ` Joe Perches
2018-10-22  9:51     ` Miguel Ojeda
2018-10-22  9:51       ` Miguel Ojeda
2018-10-22 15:48       ` Joe Perches
2018-10-22 15:48         ` Joe Perches
2018-10-22 14:10   ` Kees Cook
2018-10-22 14:10     ` Kees Cook
     [not found]     ` <20181023053542.lsklua2p3lnbkqir@mwanda>
2018-11-02 10:49       ` Miguel Ojeda
2018-11-02 10:49         ` Miguel Ojeda
2018-11-02 10:56         ` Miguel Ojeda
2018-11-02 10:56           ` Miguel Ojeda
2018-10-21 18:29 ` [PATCH 0/2] Compiler Attributes: __fallthrough Greg Kroah-Hartman
2018-10-21 18:29   ` Greg Kroah-Hartman
2018-10-21 18:52   ` Joe Perches
2018-10-21 18:52     ` Joe Perches
2018-10-22  5:27     ` Dan Carpenter
2018-10-22  5:27       ` Dan Carpenter
2018-10-22  9:48   ` Miguel Ojeda
2018-10-22  9:48     ` Miguel Ojeda
2018-10-22 16:54     ` Nick Desaulniers
2018-10-22 16:54       ` Nick Desaulniers
2018-10-22 21:23       ` Miguel Ojeda
2018-10-22 21:23         ` Miguel Ojeda
2018-10-23  5:43       ` Dan Carpenter
2018-10-23  5:43         ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c52827b-4783-8f39-9030-a166d5436f05@petrovitsch.priv.at \
    --to=bernd@petrovitsch.priv.at \
    --cc=adilger.kernel@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@google.com \
    --cc=arnd@arndb.de \
    --cc=aryabinin@virtuozzo.com \
    --cc=asmadeus@codewreck.org \
    --cc=corbet@lwn.net \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=dwmw2@infradead.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=keescook@chromium.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mingo@kernel.org \
    --cc=msebor@gmail.com \
    --cc=ndesaulniers@google.com \
    --cc=olof@lxom.net \
    --cc=paul.burton@mips.com \
    --cc=paullawrence@google.com \
    --cc=pombredanne@nexb.com \
    --cc=rientjes@google.com \
    --cc=rostedt@goodmis.org \
    --cc=sandipan@linux.vnet.ibm.com \
    --cc=sparse@chrisli.org \
    --cc=stefan@agner.ch \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=w@1wt.eu \
    --cc=will.deacon@arm.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.