* [Qemu-devel] [PATCH] block: modify top-id's comments
@ 2016-09-30 8:53 Wang WeiWei
2016-09-30 9:48 ` [Qemu-devel] [Qemu-block] " Kashyap Chamarthy
2016-09-30 9:52 ` [Qemu-devel] [PATCH v2] " Kevin Wolf
0 siblings, 2 replies; 7+ messages in thread
From: Wang WeiWei @ 2016-09-30 8:53 UTC (permalink / raw)
To: qemu devel, qemu block, Stefan Hajnoczi, Fam Zheng, Max Reitz,
Kevin Wolf, Jeff Cody
Cc: Paolo Bonzini, John Snow, Eric Blake, Markus Armbruster,
Dr . David Alan Gilbert, Dong Eddie, Jiang Yunhong,
zhanghailiang, Gonglei, Wen Congyang, Changlong Xie, Wang Weiwei
Kevin Wolf's advice:
http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
qapi/block-core.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index ada3202..a605107 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2184,7 +2184,8 @@
# @mode: the replication mode
#
# @top-id: #optional In secondary mode, node name or device ID of the root
-# node who owns the replication node chain. Ignored in primary mode.
+# node who owns the replication node chain. Must not be given in
+# primary mode.
#
# Since: 2.8
##
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments
2016-09-30 8:53 [Qemu-devel] [PATCH] block: modify top-id's comments Wang WeiWei
@ 2016-09-30 9:48 ` Kashyap Chamarthy
2016-09-30 10:53 ` Stefan Hajnoczi
2016-09-30 9:52 ` [Qemu-devel] [PATCH v2] " Kevin Wolf
1 sibling, 1 reply; 7+ messages in thread
From: Kashyap Chamarthy @ 2016-09-30 9:48 UTC (permalink / raw)
To: Wang WeiWei
Cc: qemu devel, qemu block, Stefan Hajnoczi, Fam Zheng, Max Reitz,
Kevin Wolf, Jeff Cody, Changlong Xie, zhanghailiang,
Wen Congyang, Jiang Yunhong, Dong Eddie, Markus Armbruster,
Dr . David Alan Gilbert, Gonglei, Paolo Bonzini
On Fri, Sep 30, 2016 at 04:53:38PM +0800, Wang WeiWei wrote:
> Kevin Wolf's advice:
> http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html
IIUC, what Stefan meant is to write a simple descriptive commit message
that explains why this change is necessary -- the above URL might have
context, but having it spelled out in the Git commit message will be
useful when someone is examining Git history offline.
I think Stefan was looking for something like (came up with this after
reading the above thread):
QAPI: BlockdevOptionsReplication: Clarify 'top-id' parameter usage
In primary mode, the replication driver will ignore 'top-id'
parameter, thus it must not be supplied. Explicitly spell that out in
the QAPI schema for BlockdevOptionsReplication.
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> qapi/block-core.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index ada3202..a605107 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2184,7 +2184,8 @@
> # @mode: the replication mode
> #
> # @top-id: #optional In secondary mode, node name or device ID of the root
> -# node who owns the replication node chain. Ignored in primary mode.
> +# node who owns the replication node chain. Must not be given in
> +# primary mode.
> #
> # Since: 2.8
> ##
> --
> 2.7.4
>
>
>
>
--
/kashyap
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v2] block: modify top-id's comments
2016-09-30 8:53 [Qemu-devel] [PATCH] block: modify top-id's comments Wang WeiWei
2016-09-30 9:48 ` [Qemu-devel] [Qemu-block] " Kashyap Chamarthy
@ 2016-09-30 9:52 ` Kevin Wolf
2016-09-30 9:57 ` wangweiwei
1 sibling, 1 reply; 7+ messages in thread
From: Kevin Wolf @ 2016-09-30 9:52 UTC (permalink / raw)
To: Wang WeiWei
Cc: qemu devel, qemu block, Stefan Hajnoczi, Fam Zheng, Max Reitz,
Jeff Cody, Paolo Bonzini, John Snow, Eric Blake,
Markus Armbruster, Dr . David Alan Gilbert, Dong Eddie,
Jiang Yunhong, zhanghailiang, Gonglei, Wen Congyang,
Changlong Xie
This is v2, should be included in the subject line.
Am 30.09.2016 um 10:53 hat Wang WeiWei geschrieben:
> Kevin Wolf's advice:
> http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html
>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> qapi/block-core.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index ada3202..a605107 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2184,7 +2184,8 @@
> # @mode: the replication mode
> #
> # @top-id: #optional In secondary mode, node name or device ID of the root
> -# node who owns the replication node chain. Ignored in primary mode.
> +# node who owns the replication node chain. Must not be given in
> +# primary mode.
> #
> # Since: 2.8
> ##
As I already wrote for v1:
The matching code in block/replication.c is missing to actually error
out if the option is given in primary mode.
Kevin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v2] block: modify top-id's comments
2016-09-30 9:52 ` [Qemu-devel] [PATCH v2] " Kevin Wolf
@ 2016-09-30 9:57 ` wangweiwei
0 siblings, 0 replies; 7+ messages in thread
From: wangweiwei @ 2016-09-30 9:57 UTC (permalink / raw)
To: Kevin Wolf
Cc: qemu devel, qemu block, Stefan Hajnoczi, Fam Zheng, Max Reitz,
Jeff Cody, Paolo Bonzini, John Snow, Eric Blake,
Markus Armbruster, Dr . David Alan Gilbert, Dong Eddie,
Jiang Yunhong, zhanghailiang, Gonglei, Wen Congyang,
Changlong Xie
Ok,thanks.
On 09/30/2016 05:52 PM, Kevin Wolf wrote:
> This is v2, should be included in the subject line.
>
> Am 30.09.2016 um 10:53 hat Wang WeiWei geschrieben:
>> Kevin Wolf's advice:
>> http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html
>>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>> Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> ---
>> qapi/block-core.json | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>> index ada3202..a605107 100644
>> --- a/qapi/block-core.json
>> +++ b/qapi/block-core.json
>> @@ -2184,7 +2184,8 @@
>> # @mode: the replication mode
>> #
>> # @top-id: #optional In secondary mode, node name or device ID of the root
>> -# node who owns the replication node chain. Ignored in primary mode.
>> +# node who owns the replication node chain. Must not be given in
>> +# primary mode.
>> #
>> # Since: 2.8
>> ##
>
> As I already wrote for v1:
>
> The matching code in block/replication.c is missing to actually error
> out if the option is given in primary mode.
>
> Kevin
>
>
> .
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments
2016-09-30 9:48 ` [Qemu-devel] [Qemu-block] " Kashyap Chamarthy
@ 2016-09-30 10:53 ` Stefan Hajnoczi
0 siblings, 0 replies; 7+ messages in thread
From: Stefan Hajnoczi @ 2016-09-30 10:53 UTC (permalink / raw)
To: Wang WeiWei
Cc: Kashyap Chamarthy, qemu devel, qemu block, Fam Zheng, Max Reitz,
Kevin Wolf, Jeff Cody, Changlong Xie, zhanghailiang,
Wen Congyang, Jiang Yunhong, Dong Eddie, Markus Armbruster,
Dr . David Alan Gilbert, Gonglei, Paolo Bonzini
[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]
On Fri, Sep 30, 2016 at 11:48:44AM +0200, Kashyap Chamarthy wrote:
> On Fri, Sep 30, 2016 at 04:53:38PM +0800, Wang WeiWei wrote:
> > Kevin Wolf's advice:
> > http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html
>
> IIUC, what Stefan meant is to write a simple descriptive commit message
> that explains why this change is necessary -- the above URL might have
> context, but having it spelled out in the Git commit message will be
> useful when someone is examining Git history offline.
>
> I think Stefan was looking for something like (came up with this after
> reading the above thread):
>
> QAPI: BlockdevOptionsReplication: Clarify 'top-id' parameter usage
>
> In primary mode, the replication driver will ignore 'top-id'
> parameter, thus it must not be supplied. Explicitly spell that out in
> the QAPI schema for BlockdevOptionsReplication.
Yes. Posting just a URL as the commit description is not enough.
I tried to explain the purpose of commit messages/descriptions in my
previous reply.
You can read a lot more about it elsewhere too:
http://chris.beams.io/posts/git-commit/
(The key points are the introduction and "7. Use the body to explain
what and why vs. how")
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] block: modify top-id's comments
2016-09-28 5:30 [Qemu-devel] [PATCH] " Wang WeiWei
@ 2016-09-28 9:03 ` Kevin Wolf
0 siblings, 0 replies; 7+ messages in thread
From: Kevin Wolf @ 2016-09-28 9:03 UTC (permalink / raw)
To: Wang WeiWei
Cc: qemu devel, qemu block, Stefan Hajnoczi, Fam Zheng, Max Reitz,
Jeff Cody, Paolo Bonzini, John Snow, Eric Blake,
Markus Armbruster, Dr. David Alan Gilbert, Dong Eddie,
Jiang Yunhong, zhanghailiang, Gonglei, Wen Congyang,
Changlong Xie
Am 28.09.2016 um 07:30 hat Wang WeiWei geschrieben:
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> qapi/block-core.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index ada3202..0935b81 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2184,7 +2184,7 @@
> # @mode: the replication mode
> #
> # @top-id: #optional In secondary mode, node name or device ID of the root
> -# node who owns the replication node chain. Ignored in primary mode.
> +# node who owns the replication node chain. Must not be given in primary mode.
> #
> # Since: 2.8
> ##
The matching code in block/replication.c is missing to actually error
out if the option is given in primary mode.
Kevin
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] [PATCH] block: modify top-id's comments
@ 2016-09-28 5:30 Wang WeiWei
2016-09-28 9:03 ` Kevin Wolf
0 siblings, 1 reply; 7+ messages in thread
From: Wang WeiWei @ 2016-09-28 5:30 UTC (permalink / raw)
To: qemu devel, qemu block, Stefan Hajnoczi, Fam Zheng, Max Reitz,
Kevin Wolf, Jeff Cody
Cc: Paolo Bonzini, John Snow, Eric Blake, Markus Armbruster,
Dr. David Alan Gilbert, Dong Eddie, Jiang Yunhong, zhanghailiang,
Gonglei, Wen Congyang, Changlong Xie, Wang Weiwei
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
qapi/block-core.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index ada3202..0935b81 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2184,7 +2184,7 @@
# @mode: the replication mode
#
# @top-id: #optional In secondary mode, node name or device ID of the root
-# node who owns the replication node chain. Ignored in primary mode.
+# node who owns the replication node chain. Must not be given in primary mode.
#
# Since: 2.8
##
--
1.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-09-30 10:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-30 8:53 [Qemu-devel] [PATCH] block: modify top-id's comments Wang WeiWei
2016-09-30 9:48 ` [Qemu-devel] [Qemu-block] " Kashyap Chamarthy
2016-09-30 10:53 ` Stefan Hajnoczi
2016-09-30 9:52 ` [Qemu-devel] [PATCH v2] " Kevin Wolf
2016-09-30 9:57 ` wangweiwei
-- strict thread matches above, loose matches on Subject: below --
2016-09-28 5:30 [Qemu-devel] [PATCH] " Wang WeiWei
2016-09-28 9:03 ` Kevin Wolf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.