* [Qemu-devel] [PATCH] block: modify top-id's comments
@ 2016-09-28 5:30 Wang WeiWei
2016-09-28 9:03 ` Kevin Wolf
2016-09-28 10:31 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
0 siblings, 2 replies; 6+ messages in thread
From: Wang WeiWei @ 2016-09-28 5:30 UTC (permalink / raw)
To: qemu devel, qemu block, Stefan Hajnoczi, Fam Zheng, Max Reitz,
Kevin Wolf, Jeff Cody
Cc: Paolo Bonzini, John Snow, Eric Blake, Markus Armbruster,
Dr. David Alan Gilbert, Dong Eddie, Jiang Yunhong, zhanghailiang,
Gonglei, Wen Congyang, Changlong Xie, Wang Weiwei
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
qapi/block-core.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index ada3202..0935b81 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2184,7 +2184,7 @@
# @mode: the replication mode
#
# @top-id: #optional In secondary mode, node name or device ID of the root
-# node who owns the replication node chain. Ignored in primary mode.
+# node who owns the replication node chain. Must not be given in primary mode.
#
# Since: 2.8
##
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] block: modify top-id's comments
2016-09-28 5:30 [Qemu-devel] [PATCH] block: modify top-id's comments Wang WeiWei
@ 2016-09-28 9:03 ` Kevin Wolf
2016-09-28 10:31 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
1 sibling, 0 replies; 6+ messages in thread
From: Kevin Wolf @ 2016-09-28 9:03 UTC (permalink / raw)
To: Wang WeiWei
Cc: qemu devel, qemu block, Stefan Hajnoczi, Fam Zheng, Max Reitz,
Jeff Cody, Paolo Bonzini, John Snow, Eric Blake,
Markus Armbruster, Dr. David Alan Gilbert, Dong Eddie,
Jiang Yunhong, zhanghailiang, Gonglei, Wen Congyang,
Changlong Xie
Am 28.09.2016 um 07:30 hat Wang WeiWei geschrieben:
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> qapi/block-core.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index ada3202..0935b81 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2184,7 +2184,7 @@
> # @mode: the replication mode
> #
> # @top-id: #optional In secondary mode, node name or device ID of the root
> -# node who owns the replication node chain. Ignored in primary mode.
> +# node who owns the replication node chain. Must not be given in primary mode.
> #
> # Since: 2.8
> ##
The matching code in block/replication.c is missing to actually error
out if the option is given in primary mode.
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments
2016-09-28 5:30 [Qemu-devel] [PATCH] block: modify top-id's comments Wang WeiWei
2016-09-28 9:03 ` Kevin Wolf
@ 2016-09-28 10:31 ` Stefan Hajnoczi
2016-09-29 13:35 ` Eric Blake
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Hajnoczi @ 2016-09-28 10:31 UTC (permalink / raw)
To: Wang WeiWei
Cc: qemu devel, qemu block, Stefan Hajnoczi, Fam Zheng, Max Reitz,
Kevin Wolf, Jeff Cody, Changlong Xie, zhanghailiang,
Wen Congyang, Jiang Yunhong, Dong Eddie, Markus Armbruster,
Dr. David Alan Gilbert, Gonglei, Paolo Bonzini
[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]
On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote:
Please send a proper commit message and commit description. "modify
top-id's comments" says almost nothing and there is no commit
description. I don't know why you are making this change so I can't
review and apply it.
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> qapi/block-core.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index ada3202..0935b81 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2184,7 +2184,7 @@
> # @mode: the replication mode
> #
> # @top-id: #optional In secondary mode, node name or device ID of the root
> -# node who owns the replication node chain. Ignored in primary mode.
> +# node who owns the replication node chain. Must not be given in primary mode.
> #
> # Since: 2.8
> ##
> --
> 1.9.3
>
>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments
2016-09-28 10:31 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
@ 2016-09-29 13:35 ` Eric Blake
2016-09-30 8:30 ` wangweiwei
0 siblings, 1 reply; 6+ messages in thread
From: Eric Blake @ 2016-09-29 13:35 UTC (permalink / raw)
To: Stefan Hajnoczi, Wang WeiWei
Cc: Kevin Wolf, Changlong Xie, Fam Zheng, zhanghailiang, qemu block,
Markus Armbruster, Jeff Cody, Jiang Yunhong, Dong Eddie,
qemu devel, Max Reitz, Gonglei, Stefan Hajnoczi, Paolo Bonzini,
Dr. David Alan Gilbert
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
On 09/28/2016 05:31 AM, Stefan Hajnoczi wrote:
> On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote:
>
> Please send a proper commit message and commit description. "modify
> top-id's comments" says almost nothing and there is no commit
> description. I don't know why you are making this change so I can't
> review and apply it.
>
>> +++ b/qapi/block-core.json
>> @@ -2184,7 +2184,7 @@
>> # @mode: the replication mode
>> #
>> # @top-id: #optional In secondary mode, node name or device ID of the root
>> -# node who owns the replication node chain. Ignored in primary mode.
>> +# node who owns the replication node chain. Must not be given in primary mode.
That, and your line exceeds 80 columns; please wrap it.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments
2016-09-29 13:35 ` Eric Blake
@ 2016-09-30 8:30 ` wangweiwei
0 siblings, 0 replies; 6+ messages in thread
From: wangweiwei @ 2016-09-30 8:30 UTC (permalink / raw)
To: Eric Blake, Stefan Hajnoczi
Cc: Kevin Wolf, Changlong Xie, Fam Zheng, zhanghailiang, qemu block,
Markus Armbruster, Jeff Cody, Jiang Yunhong, Dong Eddie,
qemu devel, Max Reitz, Gonglei, Stefan Hajnoczi, Paolo Bonzini,
Dr. David Alan Gilbert
Ok, I'wll wrap it.
On 09/29/2016 09:35 PM, Eric Blake wrote:
> On 09/28/2016 05:31 AM, Stefan Hajnoczi wrote:
>> On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote:
>>
>> Please send a proper commit message and commit description. "modify
>> top-id's comments" says almost nothing and there is no commit
>> description. I don't know why you are making this change so I can't
>> review and apply it.
>>
>
>>> +++ b/qapi/block-core.json
>>> @@ -2184,7 +2184,7 @@
>>> # @mode: the replication mode
>>> #
>>> # @top-id: #optional In secondary mode, node name or device ID of the root
>>> -# node who owns the replication node chain. Ignored in primary mode.
>>> +# node who owns the replication node chain. Must not be given in primary mode.
>
> That, and your line exceeds 80 columns; please wrap it.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH] block: modify top-id's comments
@ 2016-09-30 8:53 Wang WeiWei
0 siblings, 0 replies; 6+ messages in thread
From: Wang WeiWei @ 2016-09-30 8:53 UTC (permalink / raw)
To: qemu devel, qemu block, Stefan Hajnoczi, Fam Zheng, Max Reitz,
Kevin Wolf, Jeff Cody
Cc: Paolo Bonzini, John Snow, Eric Blake, Markus Armbruster,
Dr . David Alan Gilbert, Dong Eddie, Jiang Yunhong,
zhanghailiang, Gonglei, Wen Congyang, Changlong Xie, Wang Weiwei
Kevin Wolf's advice:
http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
qapi/block-core.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index ada3202..a605107 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2184,7 +2184,8 @@
# @mode: the replication mode
#
# @top-id: #optional In secondary mode, node name or device ID of the root
-# node who owns the replication node chain. Ignored in primary mode.
+# node who owns the replication node chain. Must not be given in
+# primary mode.
#
# Since: 2.8
##
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-30 8:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-28 5:30 [Qemu-devel] [PATCH] block: modify top-id's comments Wang WeiWei
2016-09-28 9:03 ` Kevin Wolf
2016-09-28 10:31 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-09-29 13:35 ` Eric Blake
2016-09-30 8:30 ` wangweiwei
2016-09-30 8:53 [Qemu-devel] " Wang WeiWei
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.