From: Julia Lawall <Julia.Lawall@lip6.fr> To: Jie Yang <yang.jie@linux.intel.com> Cc: kernel-janitors@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/7] ASoC: intel: broadwell: constify snd_soc_ops structures Date: Sat, 15 Oct 2016 16:55:45 +0200 [thread overview] Message-ID: <1476543351-17858-2-git-send-email-Julia.Lawall@lip6.fr> (raw) In-Reply-To: <1476543351-17858-1-git-send-email-Julia.Lawall@lip6.fr> Check for snd_soc_ops structures that are only stored in the ops field of a snd_soc_dai_link structure. This field is declared const, so snd_soc_ops structures that have this property can be declared as const also. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct snd_soc_ops i@p = { ... }; @ok1@ identifier r.i; struct snd_soc_dai_link e; position p; @@ e.ops = &i@p; @ok2@ identifier r.i, e; position p; @@ struct snd_soc_dai_link e[] = { ..., { .ops = &i@p, }, ..., }; @bad@ position p != {r.p,ok1.p,ok2.p}; identifier r.i; struct snd_soc_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct snd_soc_ops i = { ... }; // </smpl> The effect on the layout of the .o file is shown by the following output of the size command, first before then after the transformation: text data bss dec hex filename 3865 2784 384 7033 1b79 sound/soc/intel/boards/broadwell.o 3929 2720 384 7033 1b79 sound/soc/intel/boards/broadwell.o Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- sound/soc/intel/boards/broadwell.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/sound/soc/intel/boards/broadwell.c b/sound/soc/intel/boards/broadwell.c --- a/sound/soc/intel/boards/broadwell.c +++ b/sound/soc/intel/boards/broadwell.c @@ -126,7 +126,7 @@ static int broadwell_rt286_hw_params(str return ret; } -static struct snd_soc_ops broadwell_rt286_ops = { +static const struct snd_soc_ops broadwell_rt286_ops = { .hw_params = broadwell_rt286_hw_params, };
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <Julia.Lawall@lip6.fr> To: Jie Yang <yang.jie@linux.intel.com> Cc: kernel-janitors@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/7] ASoC: intel: broadwell: constify snd_soc_ops structures Date: Sat, 15 Oct 2016 14:55:45 +0000 [thread overview] Message-ID: <1476543351-17858-2-git-send-email-Julia.Lawall@lip6.fr> (raw) In-Reply-To: <1476543351-17858-1-git-send-email-Julia.Lawall@lip6.fr> Check for snd_soc_ops structures that are only stored in the ops field of a snd_soc_dai_link structure. This field is declared const, so snd_soc_ops structures that have this property can be declared as const also. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct snd_soc_ops i@p = { ... }; @ok1@ identifier r.i; struct snd_soc_dai_link e; position p; @@ e.ops = &i@p; @ok2@ identifier r.i, e; position p; @@ struct snd_soc_dai_link e[] = { ..., { .ops = &i@p, }, ..., }; @bad@ position p != {r.p,ok1.p,ok2.p}; identifier r.i; struct snd_soc_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct snd_soc_ops i = { ... }; // </smpl> The effect on the layout of the .o file is shown by the following output of the size command, first before then after the transformation: text data bss dec hex filename 3865 2784 384 7033 1b79 sound/soc/intel/boards/broadwell.o 3929 2720 384 7033 1b79 sound/soc/intel/boards/broadwell.o Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- sound/soc/intel/boards/broadwell.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/sound/soc/intel/boards/broadwell.c b/sound/soc/intel/boards/broadwell.c --- a/sound/soc/intel/boards/broadwell.c +++ b/sound/soc/intel/boards/broadwell.c @@ -126,7 +126,7 @@ static int broadwell_rt286_hw_params(str return ret; } -static struct snd_soc_ops broadwell_rt286_ops = { +static const struct snd_soc_ops broadwell_rt286_ops = { .hw_params = broadwell_rt286_hw_params, };
next prev parent reply other threads:[~2016-10-15 15:14 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-15 14:55 [PATCH 0/7] constify snd_soc_ops structures Julia Lawall 2016-10-15 14:55 ` Julia Lawall 2016-10-15 14:55 ` Julia Lawall 2016-10-15 14:55 ` Julia Lawall [this message] 2016-10-15 14:55 ` [PATCH 1/7] ASoC: intel: broadwell: " Julia Lawall 2016-10-17 2:22 ` [alsa-devel] " Keyon Jie 2016-10-17 2:22 ` Keyon Jie 2016-10-24 18:01 ` Applied "ASoC: intel: broadwell: constify snd_soc_ops structures" to the asoc tree Mark Brown 2016-10-24 18:01 ` Mark Brown 2016-10-24 18:01 ` Mark Brown 2016-10-15 14:55 ` [PATCH 2/7] ASoC: atmel_wm8904: constify snd_soc_ops structures Julia Lawall 2016-10-15 14:55 ` Julia Lawall 2016-10-18 8:13 ` Nicolas Ferre 2016-10-18 8:13 ` Nicolas Ferre 2016-10-18 8:13 ` Nicolas Ferre 2016-10-24 18:01 ` Applied "ASoC: atmel_wm8904: constify snd_soc_ops structures" to the asoc tree Mark Brown 2016-10-24 18:01 ` Mark Brown 2016-10-24 18:01 ` Mark Brown 2016-10-15 14:55 ` [PATCH 3/7] ASoC: rockchip: constify snd_soc_ops structures Julia Lawall 2016-10-15 14:55 ` Julia Lawall 2016-10-15 14:55 ` Julia Lawall 2016-10-24 18:01 ` Applied "ASoC: rockchip: constify snd_soc_ops structures" to the asoc tree Mark Brown 2016-10-24 18:01 ` Mark Brown 2016-10-24 18:01 ` Mark Brown 2016-10-24 18:01 ` Mark Brown 2016-10-24 18:01 ` Mark Brown 2016-10-15 14:55 ` [PATCH 4/7] ASoC: qcom: storm: constify snd_soc_ops structures Julia Lawall 2016-10-15 14:55 ` Julia Lawall 2016-10-24 18:01 ` Applied "ASoC: qcom: storm: constify snd_soc_ops structures" to the asoc tree Mark Brown 2016-10-24 18:01 ` Mark Brown 2016-10-24 18:01 ` Mark Brown 2016-10-15 14:55 ` [PATCH 5/7] ASoC: constify snd_soc_ops structures Julia Lawall 2016-10-15 14:55 ` Julia Lawall 2016-10-24 17:34 ` Mark Brown 2016-10-24 17:34 ` Mark Brown 2016-10-24 19:48 ` Julia Lawall 2016-10-24 19:48 ` Julia Lawall 2016-10-25 5:55 ` Julia Lawall 2016-10-25 5:55 ` Julia Lawall 2016-10-25 8:04 ` Joe Perches 2016-10-25 8:04 ` Joe Perches 2016-10-25 8:39 ` Julia Lawall 2016-10-25 8:39 ` Julia Lawall 2016-10-25 14:08 ` Mark Brown 2016-10-25 14:08 ` Mark Brown 2016-10-15 14:55 ` [PATCH 6/7] " Julia Lawall 2016-10-15 14:55 ` Julia Lawall 2016-10-24 18:01 ` Applied "ASoC: constify snd_soc_ops structures" to the asoc tree Mark Brown 2016-10-24 18:01 ` Mark Brown 2016-10-24 18:01 ` Mark Brown 2016-10-15 14:55 ` [PATCH 7/7] ASoC: tegra: constify snd_soc_ops structures Julia Lawall 2016-10-15 14:55 ` Julia Lawall [not found] ` <1476543351-17858-8-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org> 2016-10-24 18:01 ` Applied "ASoC: tegra: constify snd_soc_ops structures" to the asoc tree Mark Brown 2016-10-24 18:01 ` Mark Brown 2016-10-24 18:01 ` Mark Brown 2016-10-24 18:01 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1476543351-17858-2-git-send-email-Julia.Lawall@lip6.fr \ --to=julia.lawall@lip6.fr \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=perex@perex.cz \ --cc=tiwai@suse.com \ --cc=yang.jie@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.