From: Mark Brown <broonie@kernel.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Mark Brown <broonie@kernel.org>,
Patrick Lai <plai@codeaurora.org>,
alsa-devel@alsa-project.org,
Banajit Goswami <bgoswami@codeaurora.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Applied "ASoC: qcom: storm: constify snd_soc_ops structures" to the asoc tree
Date: Mon, 24 Oct 2016 19:01:29 +0100 [thread overview]
Message-ID: <E1byjYv-0000ro-8b@debutante> (raw)
In-Reply-To: <1476543351-17858-5-git-send-email-Julia.Lawall@lip6.fr>
The patch
ASoC: qcom: storm: constify snd_soc_ops structures
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 251fc7a58eca13e4af385cc6458b5533596ddb10 Mon Sep 17 00:00:00 2001
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sat, 15 Oct 2016 16:55:48 +0200
Subject: [PATCH] ASoC: qcom: storm: constify snd_soc_ops structures
Check for snd_soc_ops structures that are only stored in the ops field of a
snd_soc_dai_link structure. This field is declared const, so snd_soc_ops
structures that have this property can be declared as const also.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct snd_soc_ops i@p = { ... };
@ok1@
identifier r.i;
struct snd_soc_dai_link e;
position p;
@@
e.ops = &i@p;
@ok2@
identifier r.i, e;
position p;
@@
struct snd_soc_dai_link e[] = { ..., { .ops = &i@p, }, ..., };
@bad@
position p != {r.p,ok1.p,ok2.p};
identifier r.i;
struct snd_soc_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct snd_soc_ops i = { ... };
// </smpl>
The effect on the layout of the .o file is shown by the following output of
the size command, first before then after the transformation:
text data bss dec hex filename
1420 512 0 1932 78c sound/soc/qcom/storm.o
1484 456 0 1940 794 sound/soc/qcom/storm.o
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/qcom/storm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/storm.c b/sound/soc/qcom/storm.c
index 2d833bffdba0..8fcac2ac3aa6 100644
--- a/sound/soc/qcom/storm.c
+++ b/sound/soc/qcom/storm.c
@@ -58,7 +58,7 @@ static int storm_ops_hw_params(struct snd_pcm_substream *substream,
return 0;
}
-static struct snd_soc_ops storm_soc_ops = {
+static const struct snd_soc_ops storm_soc_ops = {
.hw_params = storm_ops_hw_params,
};
--
2.8.1
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Mark Brown <broonie@kernel.org>,
Patrick Lai <plai@codeaurora.org>,
alsa-devel@alsa-project.org,
Banajit Goswami <bgoswami@codeaurora.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>Mark Brown
<broonie@kernel.org>
Subject: Applied "ASoC: qcom: storm: constify snd_soc_ops structures" to the asoc tree
Date: Mon, 24 Oct 2016 18:01:29 +0000 [thread overview]
Message-ID: <E1byjYv-0000ro-8b@debutante> (raw)
In-Reply-To: <1476543351-17858-5-git-send-email-Julia.Lawall@lip6.fr>
The patch
ASoC: qcom: storm: constify snd_soc_ops structures
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 251fc7a58eca13e4af385cc6458b5533596ddb10 Mon Sep 17 00:00:00 2001
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sat, 15 Oct 2016 16:55:48 +0200
Subject: [PATCH] ASoC: qcom: storm: constify snd_soc_ops structures
Check for snd_soc_ops structures that are only stored in the ops field of a
snd_soc_dai_link structure. This field is declared const, so snd_soc_ops
structures that have this property can be declared as const also.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct snd_soc_ops i@p = { ... };
@ok1@
identifier r.i;
struct snd_soc_dai_link e;
position p;
@@
e.ops = &i@p;
@ok2@
identifier r.i, e;
position p;
@@
struct snd_soc_dai_link e[] = { ..., { .ops = &i@p, }, ..., };
@bad@
position p != {r.p,ok1.p,ok2.p};
identifier r.i;
struct snd_soc_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct snd_soc_ops i = { ... };
// </smpl>
The effect on the layout of the .o file is shown by the following output of
the size command, first before then after the transformation:
text data bss dec hex filename
1420 512 0 1932 78c sound/soc/qcom/storm.o
1484 456 0 1940 794 sound/soc/qcom/storm.o
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/qcom/storm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/storm.c b/sound/soc/qcom/storm.c
index 2d833bffdba0..8fcac2ac3aa6 100644
--- a/sound/soc/qcom/storm.c
+++ b/sound/soc/qcom/storm.c
@@ -58,7 +58,7 @@ static int storm_ops_hw_params(struct snd_pcm_substream *substream,
return 0;
}
-static struct snd_soc_ops storm_soc_ops = {
+static const struct snd_soc_ops storm_soc_ops = {
.hw_params = storm_ops_hw_params,
};
--
2.8.1
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Mark Brown <broonie@kernel.org>,
Patrick Lai <plai@codeaurora.org>,
alsa-devel@alsa-project.org,
Banajit Goswami <bgoswami@codeaurora.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>Mark Brown
<broonie@kernel.org>
Subject: Applied "ASoC: qcom: storm: constify snd_soc_ops structures" to the asoc tree
Date: Mon, 24 Oct 2016 19:01:29 +0100 [thread overview]
Message-ID: <E1byjYv-0000ro-8b@debutante> (raw)
In-Reply-To: <1476543351-17858-5-git-send-email-Julia.Lawall@lip6.fr>
The patch
ASoC: qcom: storm: constify snd_soc_ops structures
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 251fc7a58eca13e4af385cc6458b5533596ddb10 Mon Sep 17 00:00:00 2001
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sat, 15 Oct 2016 16:55:48 +0200
Subject: [PATCH] ASoC: qcom: storm: constify snd_soc_ops structures
Check for snd_soc_ops structures that are only stored in the ops field of a
snd_soc_dai_link structure. This field is declared const, so snd_soc_ops
structures that have this property can be declared as const also.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct snd_soc_ops i@p = { ... };
@ok1@
identifier r.i;
struct snd_soc_dai_link e;
position p;
@@
e.ops = &i@p;
@ok2@
identifier r.i, e;
position p;
@@
struct snd_soc_dai_link e[] = { ..., { .ops = &i@p, }, ..., };
@bad@
position p != {r.p,ok1.p,ok2.p};
identifier r.i;
struct snd_soc_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct snd_soc_ops i = { ... };
// </smpl>
The effect on the layout of the .o file is shown by the following output of
the size command, first before then after the transformation:
text data bss dec hex filename
1420 512 0 1932 78c sound/soc/qcom/storm.o
1484 456 0 1940 794 sound/soc/qcom/storm.o
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/qcom/storm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/storm.c b/sound/soc/qcom/storm.c
index 2d833bffdba0..8fcac2ac3aa6 100644
--- a/sound/soc/qcom/storm.c
+++ b/sound/soc/qcom/storm.c
@@ -58,7 +58,7 @@ static int storm_ops_hw_params(struct snd_pcm_substream *substream,
return 0;
}
-static struct snd_soc_ops storm_soc_ops = {
+static const struct snd_soc_ops storm_soc_ops = {
.hw_params = storm_ops_hw_params,
};
--
2.8.1
next prev parent reply other threads:[~2016-10-24 18:01 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-15 14:55 [PATCH 0/7] constify snd_soc_ops structures Julia Lawall
2016-10-15 14:55 ` Julia Lawall
2016-10-15 14:55 ` Julia Lawall
2016-10-15 14:55 ` [PATCH 1/7] ASoC: intel: broadwell: " Julia Lawall
2016-10-15 14:55 ` Julia Lawall
2016-10-17 2:22 ` [alsa-devel] " Keyon Jie
2016-10-17 2:22 ` Keyon Jie
2016-10-24 18:01 ` Applied "ASoC: intel: broadwell: constify snd_soc_ops structures" to the asoc tree Mark Brown
2016-10-24 18:01 ` Mark Brown
2016-10-24 18:01 ` Mark Brown
2016-10-15 14:55 ` [PATCH 2/7] ASoC: atmel_wm8904: constify snd_soc_ops structures Julia Lawall
2016-10-15 14:55 ` Julia Lawall
2016-10-18 8:13 ` Nicolas Ferre
2016-10-18 8:13 ` Nicolas Ferre
2016-10-18 8:13 ` Nicolas Ferre
2016-10-24 18:01 ` Applied "ASoC: atmel_wm8904: constify snd_soc_ops structures" to the asoc tree Mark Brown
2016-10-24 18:01 ` Mark Brown
2016-10-24 18:01 ` Mark Brown
2016-10-15 14:55 ` [PATCH 3/7] ASoC: rockchip: constify snd_soc_ops structures Julia Lawall
2016-10-15 14:55 ` Julia Lawall
2016-10-15 14:55 ` Julia Lawall
2016-10-24 18:01 ` Applied "ASoC: rockchip: constify snd_soc_ops structures" to the asoc tree Mark Brown
2016-10-24 18:01 ` Mark Brown
2016-10-24 18:01 ` Mark Brown
2016-10-24 18:01 ` Mark Brown
2016-10-24 18:01 ` Mark Brown
2016-10-15 14:55 ` [PATCH 4/7] ASoC: qcom: storm: constify snd_soc_ops structures Julia Lawall
2016-10-15 14:55 ` Julia Lawall
2016-10-24 18:01 ` Mark Brown [this message]
2016-10-24 18:01 ` Applied "ASoC: qcom: storm: constify snd_soc_ops structures" to the asoc tree Mark Brown
2016-10-24 18:01 ` Mark Brown
2016-10-15 14:55 ` [PATCH 5/7] ASoC: constify snd_soc_ops structures Julia Lawall
2016-10-15 14:55 ` Julia Lawall
2016-10-24 17:34 ` Mark Brown
2016-10-24 17:34 ` Mark Brown
2016-10-24 19:48 ` Julia Lawall
2016-10-24 19:48 ` Julia Lawall
2016-10-25 5:55 ` Julia Lawall
2016-10-25 5:55 ` Julia Lawall
2016-10-25 8:04 ` Joe Perches
2016-10-25 8:04 ` Joe Perches
2016-10-25 8:39 ` Julia Lawall
2016-10-25 8:39 ` Julia Lawall
2016-10-25 14:08 ` Mark Brown
2016-10-25 14:08 ` Mark Brown
2016-10-15 14:55 ` [PATCH 6/7] " Julia Lawall
2016-10-15 14:55 ` Julia Lawall
2016-10-24 18:01 ` Applied "ASoC: constify snd_soc_ops structures" to the asoc tree Mark Brown
2016-10-24 18:01 ` Mark Brown
2016-10-24 18:01 ` Mark Brown
2016-10-15 14:55 ` [PATCH 7/7] ASoC: tegra: constify snd_soc_ops structures Julia Lawall
2016-10-15 14:55 ` Julia Lawall
[not found] ` <1476543351-17858-8-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2016-10-24 18:01 ` Applied "ASoC: tegra: constify snd_soc_ops structures" to the asoc tree Mark Brown
2016-10-24 18:01 ` Mark Brown
2016-10-24 18:01 ` Mark Brown
2016-10-24 18:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1byjYv-0000ro-8b@debutante \
--to=broonie@kernel.org \
--cc=Julia.Lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.