* [PATCH] [media] c8sectpfe: Remove clk_disable_unprepare hacks
@ 2016-10-21 8:55 ` Peter Griffin
0 siblings, 0 replies; 4+ messages in thread
From: Peter Griffin @ 2016-10-21 8:55 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, kernel, mchehab, patrice.chotard
Cc: peter.griffin, lee.jones, linux-media
Now that CLK_PROC_STFE is defined as a critical clock in
DT, we can remove the commented clk_disable_unprepare from
the c8sectpfe driver. This means we now have balanced
clk*enable/disable calls in the driver, but on STiH407
family the clock in reality will never actually be disabled.
This is due to a HW bug where once the IP has been configured
and the SLIM core is running, disabling the clock causes a
unrecoverable bus lockup.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
index 30c148b..79d793b 100644
--- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
+++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
@@ -888,8 +888,7 @@ static int c8sectpfe_probe(struct platform_device *pdev)
return 0;
err_clk_disable:
- /* TODO uncomment when upstream has taken a reference on this clk */
- /*clk_disable_unprepare(fei->c8sectpfeclk);*/
+ clk_disable_unprepare(fei->c8sectpfeclk);
return ret;
}
@@ -924,11 +923,8 @@ static int c8sectpfe_remove(struct platform_device *pdev)
if (readl(fei->io + SYS_OTHER_CLKEN))
writel(0, fei->io + SYS_OTHER_CLKEN);
- /* TODO uncomment when upstream has taken a reference on this clk */
- /*
if (fei->c8sectpfeclk)
clk_disable_unprepare(fei->c8sectpfeclk);
- */
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] [media] c8sectpfe: Remove clk_disable_unprepare hacks
@ 2016-10-21 8:55 ` Peter Griffin
0 siblings, 0 replies; 4+ messages in thread
From: Peter Griffin @ 2016-10-21 8:55 UTC (permalink / raw)
To: linux-arm-kernel
Now that CLK_PROC_STFE is defined as a critical clock in
DT, we can remove the commented clk_disable_unprepare from
the c8sectpfe driver. This means we now have balanced
clk*enable/disable calls in the driver, but on STiH407
family the clock in reality will never actually be disabled.
This is due to a HW bug where once the IP has been configured
and the SLIM core is running, disabling the clock causes a
unrecoverable bus lockup.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
index 30c148b..79d793b 100644
--- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
+++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
@@ -888,8 +888,7 @@ static int c8sectpfe_probe(struct platform_device *pdev)
return 0;
err_clk_disable:
- /* TODO uncomment when upstream has taken a reference on this clk */
- /*clk_disable_unprepare(fei->c8sectpfeclk);*/
+ clk_disable_unprepare(fei->c8sectpfeclk);
return ret;
}
@@ -924,11 +923,8 @@ static int c8sectpfe_remove(struct platform_device *pdev)
if (readl(fei->io + SYS_OTHER_CLKEN))
writel(0, fei->io + SYS_OTHER_CLKEN);
- /* TODO uncomment when upstream has taken a reference on this clk */
- /*
if (fei->c8sectpfeclk)
clk_disable_unprepare(fei->c8sectpfeclk);
- */
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [media] c8sectpfe: Remove clk_disable_unprepare hacks
2016-10-21 8:55 ` Peter Griffin
@ 2016-10-21 12:23 ` Patrice Chotard
-1 siblings, 0 replies; 4+ messages in thread
From: Patrice Chotard @ 2016-10-21 12:23 UTC (permalink / raw)
To: Peter Griffin, linux-arm-kernel, linux-kernel, kernel, mchehab
Cc: lee.jones, linux-media
On 10/21/2016 10:55 AM, Peter Griffin wrote:
> Now that CLK_PROC_STFE is defined as a critical clock in
> DT, we can remove the commented clk_disable_unprepare from
> the c8sectpfe driver. This means we now have balanced
> clk*enable/disable calls in the driver, but on STiH407
> family the clock in reality will never actually be disabled.
>
> This is due to a HW bug where once the IP has been configured
> and the SLIM core is running, disabling the clock causes a
> unrecoverable bus lockup.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> index 30c148b..79d793b 100644
> --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> @@ -888,8 +888,7 @@ static int c8sectpfe_probe(struct platform_device *pdev)
> return 0;
>
> err_clk_disable:
> - /* TODO uncomment when upstream has taken a reference on this clk */
> - /*clk_disable_unprepare(fei->c8sectpfeclk);*/
> + clk_disable_unprepare(fei->c8sectpfeclk);
> return ret;
> }
>
> @@ -924,11 +923,8 @@ static int c8sectpfe_remove(struct platform_device *pdev)
> if (readl(fei->io + SYS_OTHER_CLKEN))
> writel(0, fei->io + SYS_OTHER_CLKEN);
>
> - /* TODO uncomment when upstream has taken a reference on this clk */
> - /*
> if (fei->c8sectpfeclk)
> clk_disable_unprepare(fei->c8sectpfeclk);
> - */
>
> return 0;
> }
>
Acked-by: Patrice Chotard <patrice.chotard@st.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] [media] c8sectpfe: Remove clk_disable_unprepare hacks
@ 2016-10-21 12:23 ` Patrice Chotard
0 siblings, 0 replies; 4+ messages in thread
From: Patrice Chotard @ 2016-10-21 12:23 UTC (permalink / raw)
To: linux-arm-kernel
On 10/21/2016 10:55 AM, Peter Griffin wrote:
> Now that CLK_PROC_STFE is defined as a critical clock in
> DT, we can remove the commented clk_disable_unprepare from
> the c8sectpfe driver. This means we now have balanced
> clk*enable/disable calls in the driver, but on STiH407
> family the clock in reality will never actually be disabled.
>
> This is due to a HW bug where once the IP has been configured
> and the SLIM core is running, disabling the clock causes a
> unrecoverable bus lockup.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> index 30c148b..79d793b 100644
> --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> @@ -888,8 +888,7 @@ static int c8sectpfe_probe(struct platform_device *pdev)
> return 0;
>
> err_clk_disable:
> - /* TODO uncomment when upstream has taken a reference on this clk */
> - /*clk_disable_unprepare(fei->c8sectpfeclk);*/
> + clk_disable_unprepare(fei->c8sectpfeclk);
> return ret;
> }
>
> @@ -924,11 +923,8 @@ static int c8sectpfe_remove(struct platform_device *pdev)
> if (readl(fei->io + SYS_OTHER_CLKEN))
> writel(0, fei->io + SYS_OTHER_CLKEN);
>
> - /* TODO uncomment when upstream has taken a reference on this clk */
> - /*
> if (fei->c8sectpfeclk)
> clk_disable_unprepare(fei->c8sectpfeclk);
> - */
>
> return 0;
> }
>
Acked-by: Patrice Chotard <patrice.chotard@st.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-21 12:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-21 8:55 [PATCH] [media] c8sectpfe: Remove clk_disable_unprepare hacks Peter Griffin
2016-10-21 8:55 ` Peter Griffin
2016-10-21 12:23 ` Patrice Chotard
2016-10-21 12:23 ` Patrice Chotard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.