All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "zhichang.yuan" <yuanzhichang@hisilicon.com>,
	catalin.marinas@arm.com, will.deacon@arm.com, robh+dt@kernel.org,
	bhelgaas@google.com, olof@lixom.net, arnd@arndb.de,
	linux-arm-kernel@lists.infradead.org, lorenzo.pieralisi@arm.com,
	linux-kernel@vger.kernel.org, linuxarm@huawei.com,
	devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-serial@vger.kernel.org, minyard@acm.org,
	liviu.dudau@arm.com, zourongrong@gmail.com,
	john.garry@huawei.com, gabriele.paoloni@huawei.com,
	zhichang.yuan02@gmail.com, kantyzc@163.com, xuwei5@hisilicon.com,
	marc.zyngier@arm.com
Subject: Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA
Date: Thu, 10 Nov 2016 18:08:27 +1100	[thread overview]
Message-ID: <1478761707.7430.119.camel@kernel.crashing.org> (raw)
In-Reply-To: <20161109111959.GB17020@leverpostej>

On Wed, 2016-11-09 at 11:20 +0000, Mark Rutland wrote:
> The big change would be to handle !MMIO translations, for which we'd
> need a runtime registry of ISA bus instance to find the relevant
> accessor ops and instance-specific data.

Yes. We do something a bit like that on ppc, we find the PCI bus
for which the IO ports match and I have a hook to register the
special indirect ISA.

It's a bit messy, we could do something nicer generically.

Cheers,
Ben.

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: "zhichang.yuan"
	<yuanzhichang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
	catalin.marinas-5wv7dgnIgG8@public.gmane.org,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org,
	arnd-r2nGTMty4D4@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	minyard-HInyCGIudOg@public.gmane.org,
	liviu.dudau-5wv7dgnIgG8@public.gmane.org,
	zourongrong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	gabriele.paoloni-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	zhichang.yuan02-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	kantyzc-9Onoh4P/yGk@public.gmane.org,
	xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	marc.zyngier-5wv7dgnIgG8@public.gmane.org
Subject: Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA
Date: Thu, 10 Nov 2016 18:08:27 +1100	[thread overview]
Message-ID: <1478761707.7430.119.camel@kernel.crashing.org> (raw)
In-Reply-To: <20161109111959.GB17020@leverpostej>

On Wed, 2016-11-09 at 11:20 +0000, Mark Rutland wrote:
> The big change would be to handle !MMIO translations, for which we'd
> need a runtime registry of ISA bus instance to find the relevant
> accessor ops and instance-specific data.

Yes. We do something a bit like that on ppc, we find the PCI bus
for which the IO ports match and I have a hook to register the
special indirect ISA.

It's a bit messy, we could do something nicer generically.

Cheers,
Ben.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: benh@kernel.crashing.org (Benjamin Herrenschmidt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA
Date: Thu, 10 Nov 2016 18:08:27 +1100	[thread overview]
Message-ID: <1478761707.7430.119.camel@kernel.crashing.org> (raw)
In-Reply-To: <20161109111959.GB17020@leverpostej>

On Wed, 2016-11-09 at 11:20 +0000, Mark Rutland wrote:
> The big change would be to handle !MMIO translations, for which we'd
> need a runtime registry of ISA bus instance to find the relevant
> accessor ops and instance-specific data.

Yes. We do something a bit like that on ppc, we find the PCI bus
for which the IO ports match and I have a hook to register the
special indirect ISA.

It's a bit messy, we could do something nicer generically.

Cheers,
Ben.

  reply	other threads:[~2016-11-10  7:10 UTC|newest]

Thread overview: 286+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08  3:47 [PATCH V5 0/3] ARM64 LPC: legacy ISA I/O support zhichang.yuan
2016-11-08  3:47 ` zhichang.yuan
2016-11-08  3:47 ` zhichang.yuan
2016-11-08  3:47 ` [PATCH V5 1/3] ARM64 LPC: Indirect ISA port IO introduced zhichang.yuan
2016-11-08  3:47   ` zhichang.yuan
2016-11-08  3:47   ` zhichang.yuan
2016-11-08 12:03   ` Mark Rutland
2016-11-08 12:03     ` Mark Rutland
2016-11-08 12:03     ` Mark Rutland
2016-11-08 16:09     ` Arnd Bergmann
2016-11-08 16:09       ` Arnd Bergmann
2016-11-08 16:09       ` Arnd Bergmann
2016-11-08 16:09       ` Arnd Bergmann
2016-11-08 16:15       ` Arnd Bergmann
2016-11-08 16:15         ` Arnd Bergmann
2016-11-08 23:16     ` Benjamin Herrenschmidt
2016-11-08 23:16       ` Benjamin Herrenschmidt
2016-11-08 23:16       ` Benjamin Herrenschmidt
2016-11-10  8:33       ` zhichang.yuan
2016-11-10  8:33         ` zhichang.yuan
2016-11-10  8:33         ` zhichang.yuan
2016-11-10 11:22       ` Mark Rutland
2016-11-10 11:22         ` Mark Rutland
2016-11-10 19:32         ` Benjamin Herrenschmidt
2016-11-10 19:32           ` Benjamin Herrenschmidt
2016-11-10 19:32           ` Benjamin Herrenschmidt
2016-11-10 19:32           ` Benjamin Herrenschmidt
2016-11-11 10:07           ` zhichang.yuan
2016-11-11 10:07             ` zhichang.yuan
2016-11-11 10:07             ` zhichang.yuan
2016-11-18  9:20             ` Arnd Bergmann
2016-11-18  9:20               ` Arnd Bergmann
2016-11-18  9:20               ` Arnd Bergmann
2016-11-18 11:12               ` zhichang.yuan
2016-11-18 11:12                 ` zhichang.yuan
2016-11-18 11:12                 ` zhichang.yuan
2016-11-18 11:38                 ` Arnd Bergmann
2016-11-18 11:38                   ` Arnd Bergmann
2016-11-21 12:58       ` John Garry
2016-11-21 12:58         ` John Garry
2016-11-21 12:58         ` John Garry
2016-11-08 16:12   ` Will Deacon
2016-11-08 16:12     ` Will Deacon
2016-11-08 16:12     ` Will Deacon
2016-11-08 16:33     ` John Garry
2016-11-08 16:33       ` John Garry
2016-11-08 16:33       ` John Garry
2016-11-08 16:33       ` John Garry
2016-11-08 16:49       ` Will Deacon
2016-11-08 16:49         ` Will Deacon
2016-11-08 17:05         ` John Garry
2016-11-08 17:05           ` John Garry
2016-11-08 17:05           ` John Garry
2016-11-08 22:35         ` Arnd Bergmann
2016-11-08 22:35           ` Arnd Bergmann
2016-11-08 22:35           ` Arnd Bergmann
2016-11-09 11:29           ` John Garry
2016-11-09 11:29             ` John Garry
2016-11-09 11:29             ` John Garry
2016-11-09 21:33             ` Arnd Bergmann
2016-11-09 21:33               ` Arnd Bergmann
2016-11-09 21:33               ` Arnd Bergmann
2016-12-22  8:15   ` Ming Lei
2016-12-22  8:15     ` Ming Lei
2016-12-22  8:15     ` Ming Lei
2016-12-22  8:15     ` Ming Lei
2016-12-23  1:43     ` zhichang.yuan
2016-12-23  1:43       ` zhichang.yuan
2016-12-23  1:43       ` zhichang.yuan
2016-12-23  1:43       ` zhichang.yuan
2016-12-23  7:24       ` Ming Lei
2016-12-23  7:24         ` Ming Lei
2016-12-23  7:24         ` Ming Lei
2016-12-23  7:24         ` Ming Lei
2017-01-06 11:43     ` Arnd Bergmann
2017-01-06 11:43       ` Arnd Bergmann
2017-01-06 11:43       ` Arnd Bergmann
2017-01-06 11:43       ` Arnd Bergmann
2017-01-07  1:25       ` 答复: " Yuanzhichang
2016-11-08  3:47 ` [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA zhichang.yuan
2016-11-08  3:47   ` zhichang.yuan
2016-11-08  3:47   ` zhichang.yuan
2016-11-08  5:17   ` kbuild test robot
2016-11-08  5:17     ` kbuild test robot
2016-11-08  5:17     ` kbuild test robot
2016-11-08  5:17     ` kbuild test robot
2016-11-08  5:27   ` kbuild test robot
2016-11-08  5:27     ` kbuild test robot
2016-11-08  5:27     ` kbuild test robot
2016-11-08 11:49   ` Mark Rutland
2016-11-08 11:49     ` Mark Rutland
2016-11-08 16:19     ` Arnd Bergmann
2016-11-08 16:19       ` Arnd Bergmann
2016-11-08 16:19       ` Arnd Bergmann
2016-11-08 17:10       ` Mark Rutland
2016-11-08 17:10         ` Mark Rutland
2016-11-08 17:10         ` Mark Rutland
2016-11-09 13:54       ` One Thousand Gnomes
2016-11-09 13:54         ` One Thousand Gnomes
2016-11-09 14:51         ` Gabriele Paoloni
2016-11-09 14:51           ` Gabriele Paoloni
2016-11-09 14:51           ` Gabriele Paoloni
2016-11-09 14:51           ` Gabriele Paoloni
2016-11-09 21:38         ` Arnd Bergmann
2016-11-09 21:38           ` Arnd Bergmann
2016-11-09 21:38           ` Arnd Bergmann
2016-11-14 11:11           ` One Thousand Gnomes
2016-11-14 11:11             ` One Thousand Gnomes
2016-11-14 11:11             ` One Thousand Gnomes
2016-11-18  9:22             ` Arnd Bergmann
2016-11-18  9:22               ` Arnd Bergmann
2016-11-18  9:22               ` Arnd Bergmann
2016-11-18  9:22               ` Arnd Bergmann
2016-11-08 23:12     ` Benjamin Herrenschmidt
2016-11-08 23:12       ` Benjamin Herrenschmidt
2016-11-08 23:12       ` Benjamin Herrenschmidt
2016-11-08 23:12       ` Benjamin Herrenschmidt
2016-11-09 11:20       ` Mark Rutland
2016-11-09 11:20         ` Mark Rutland
2016-11-10  7:08         ` Benjamin Herrenschmidt [this message]
2016-11-10  7:08           ` Benjamin Herrenschmidt
2016-11-10  7:08           ` Benjamin Herrenschmidt
2016-11-09 11:39   ` liviu.dudau
2016-11-09 11:39     ` liviu.dudau at arm.com
2016-11-09 11:39     ` liviu.dudau-5wv7dgnIgG8
2016-11-09 16:16     ` Gabriele Paoloni
2016-11-09 16:16       ` Gabriele Paoloni
2016-11-09 16:16       ` Gabriele Paoloni
2016-11-09 16:16       ` Gabriele Paoloni
2016-11-09 16:50       ` liviu.dudau
2016-11-09 16:50         ` liviu.dudau at arm.com
2016-11-09 16:50         ` liviu.dudau
2016-11-09 16:50         ` liviu.dudau-5wv7dgnIgG8
2016-11-10  6:24         ` zhichang.yuan
2016-11-10  6:24           ` zhichang.yuan
2016-11-10  6:24           ` zhichang.yuan
2016-11-10  6:24           ` zhichang.yuan
2016-11-10 16:06         ` Gabriele Paoloni
2016-11-10 16:06           ` Gabriele Paoloni
2016-11-10 16:06           ` Gabriele Paoloni
2016-11-10 16:06           ` Gabriele Paoloni
2016-11-11 10:37           ` liviu.dudau
2016-11-11 10:37             ` liviu.dudau at arm.com
2016-11-11 10:37             ` liviu.dudau
2016-11-11 10:37             ` liviu.dudau
2016-11-08  3:47 ` [PATCH V5 3/3] ARM64 LPC: LPC driver implementation on Hip06 zhichang.yuan
2016-11-08  3:47   ` zhichang.yuan
2016-11-08  3:47   ` zhichang.yuan
2016-11-08  6:11   ` kbuild test robot
2016-11-08  6:11     ` kbuild test robot
2016-11-08  6:11     ` kbuild test robot
2016-11-08 16:24   ` Arnd Bergmann
2016-11-08 16:24     ` Arnd Bergmann
2016-11-09 12:10     ` Gabriele Paoloni
2016-11-09 12:10       ` Gabriele Paoloni
2016-11-09 12:10       ` Gabriele Paoloni
2016-11-09 12:10       ` Gabriele Paoloni
2016-11-09 21:34       ` Arnd Bergmann
2016-11-09 21:34         ` Arnd Bergmann
2016-11-09 21:34         ` Arnd Bergmann
2016-11-09 21:34         ` Arnd Bergmann
2016-11-10  6:40         ` zhichang.yuan
2016-11-10  6:40           ` zhichang.yuan
2016-11-10  6:40           ` zhichang.yuan
2016-11-10  9:12           ` Arnd Bergmann
2016-11-10  9:12             ` Arnd Bergmann
2016-11-10  9:12             ` Arnd Bergmann
2016-11-10 12:36             ` zhichang.yuan
2016-11-10 12:36               ` zhichang.yuan
2016-11-10 12:36               ` zhichang.yuan
2016-11-18 11:46               ` Arnd Bergmann
2016-11-18 11:46                 ` Arnd Bergmann
2016-11-18 11:46                 ` Arnd Bergmann
2016-11-18 11:46                 ` Arnd Bergmann
2016-11-10 15:36             ` Gabriele Paoloni
2016-11-10 15:36               ` Gabriele Paoloni
2016-11-10 15:36               ` Gabriele Paoloni
2016-11-10 15:36               ` Gabriele Paoloni
2016-11-10 16:07               ` Arnd Bergmann
2016-11-10 16:07                 ` Arnd Bergmann
2016-11-10 16:07                 ` Arnd Bergmann
2016-11-10 16:07                 ` Arnd Bergmann
2016-11-11 10:09                 ` zhichang.yuan
2016-11-11 10:09                   ` zhichang.yuan
2016-11-11 10:09                   ` zhichang.yuan
2016-11-11 10:09                   ` zhichang.yuan
2016-11-11 10:48                 ` liviu.dudau
2016-11-11 10:48                   ` liviu.dudau at arm.com
2016-11-11 10:48                   ` liviu.dudau
2016-11-11 10:48                   ` liviu.dudau
2016-11-11 13:39                 ` Gabriele Paoloni
2016-11-11 13:39                   ` Gabriele Paoloni
2016-11-11 13:39                   ` Gabriele Paoloni
2016-11-11 13:39                   ` Gabriele Paoloni
2016-11-11 14:45                   ` liviu.dudau
2016-11-11 14:45                     ` liviu.dudau at arm.com
2016-11-11 14:45                     ` liviu.dudau
2016-11-11 14:45                     ` liviu.dudau-5wv7dgnIgG8
2016-11-11 15:53                     ` Gabriele Paoloni
2016-11-11 15:53                       ` Gabriele Paoloni
2016-11-11 15:53                       ` Gabriele Paoloni
2016-11-11 15:53                       ` Gabriele Paoloni
2016-11-11 18:16                       ` liviu.dudau
2016-11-11 18:16                         ` liviu.dudau at arm.com
2016-11-11 18:16                         ` liviu.dudau
2016-11-11 18:16                         ` liviu.dudau
2016-11-14  8:26                         ` Gabriele Paoloni
2016-11-14  8:26                           ` Gabriele Paoloni
2016-11-14  8:26                           ` Gabriele Paoloni
2016-11-14  8:26                           ` Gabriele Paoloni
2016-11-14 11:26                           ` liviu.dudau
2016-11-14 11:26                             ` liviu.dudau at arm.com
2016-11-14 11:26                             ` liviu.dudau
2016-11-14 11:26                             ` liviu.dudau
2016-11-18 10:17                             ` Arnd Bergmann
2016-11-18 10:17                               ` Arnd Bergmann
2016-11-18 10:17                               ` Arnd Bergmann
2016-11-18 10:17                               ` Arnd Bergmann
2016-11-18 12:07                               ` Gabriele Paoloni
2016-11-18 12:07                                 ` Gabriele Paoloni
2016-11-18 12:07                                 ` Gabriele Paoloni
2016-11-18 12:07                                 ` Gabriele Paoloni
2016-11-18 12:24                                 ` Arnd Bergmann
2016-11-18 12:24                                   ` Arnd Bergmann
2016-11-18 12:24                                   ` Arnd Bergmann
2016-11-18 12:24                                   ` Arnd Bergmann
2016-11-18 12:53                                   ` Gabriele Paoloni
2016-11-18 12:53                                     ` Gabriele Paoloni
2016-11-18 12:53                                     ` Gabriele Paoloni
2016-11-18 12:53                                     ` Gabriele Paoloni
2016-11-18 13:42                                     ` Arnd Bergmann
2016-11-18 13:42                                       ` Arnd Bergmann
2016-11-18 13:42                                       ` Arnd Bergmann
2016-11-18 16:18                                       ` Gabriele Paoloni
2016-11-18 16:18                                         ` Gabriele Paoloni
2016-11-18 16:18                                         ` Gabriele Paoloni
2016-11-18 16:18                                         ` Gabriele Paoloni
2016-11-18 16:34                                         ` Arnd Bergmann
2016-11-18 16:34                                           ` Arnd Bergmann
2016-11-18 16:34                                           ` Arnd Bergmann
2016-11-18 16:34                                           ` Arnd Bergmann
2016-11-18 17:03                                           ` Gabriele Paoloni
2016-11-18 17:03                                             ` Gabriele Paoloni
2016-11-18 17:03                                             ` Gabriele Paoloni
2016-11-18 17:03                                             ` Gabriele Paoloni
2016-11-23 14:16                                             ` Arnd Bergmann
2016-11-23 14:16                                               ` Arnd Bergmann
2016-11-23 14:16                                               ` Arnd Bergmann
2016-11-23 14:16                                               ` Arnd Bergmann
2016-11-23 15:22                                               ` Gabriele Paoloni
2016-11-23 15:22                                                 ` Gabriele Paoloni
2016-11-23 15:22                                                 ` Gabriele Paoloni
2016-11-23 15:22                                                 ` Gabriele Paoloni
2016-11-23 17:07                                                 ` Arnd Bergmann
2016-11-23 17:07                                                   ` Arnd Bergmann
2016-11-23 17:07                                                   ` Arnd Bergmann
2016-11-23 17:07                                                   ` Arnd Bergmann
2016-11-23 23:23                                                   ` Arnd Bergmann
2016-11-23 23:23                                                     ` Arnd Bergmann
2016-11-23 23:23                                                     ` Arnd Bergmann
2016-11-24  9:12                                                     ` zhichang.yuan
2016-11-24  9:12                                                       ` zhichang.yuan
2016-11-24  9:12                                                       ` zhichang.yuan
2016-11-24 10:24                                                       ` Arnd Bergmann
2016-11-24 10:24                                                         ` Arnd Bergmann
2016-11-24 10:24                                                         ` Arnd Bergmann
2016-11-24 10:24                                                         ` Arnd Bergmann
2016-11-25  8:46                                                     ` Gabriele Paoloni
2016-11-25  8:46                                                       ` Gabriele Paoloni
2016-11-25  8:46                                                       ` Gabriele Paoloni
2016-11-25  8:46                                                       ` Gabriele Paoloni
2016-11-25 12:03                                                       ` Arnd Bergmann
2016-11-25 12:03                                                         ` Arnd Bergmann
2016-11-25 12:03                                                         ` Arnd Bergmann
2016-11-25 12:03                                                         ` Arnd Bergmann
2016-11-25 16:27                                                         ` Gabriele Paoloni
2016-11-25 16:27                                                           ` Gabriele Paoloni
2016-11-25 16:27                                                           ` Gabriele Paoloni
2016-11-25 16:27                                                           ` Gabriele Paoloni
2016-11-11 16:54                     ` zhichang.yuan
2016-11-11 16:54                       ` zhichang.yuan
2016-11-11 16:54                       ` zhichang.yuan
2016-11-11 16:54                       ` zhichang.yuan
2016-11-14 11:06         ` One Thousand Gnomes
2016-11-14 11:06           ` One Thousand Gnomes
2016-11-14 11:06           ` One Thousand Gnomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478761707.7430.119.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gabriele.paoloni@huawei.com \
    --cc=john.garry@huawei.com \
    --cc=kantyzc@163.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=liviu.dudau@arm.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=minyard@acm.org \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    --cc=xuwei5@hisilicon.com \
    --cc=yuanzhichang@hisilicon.com \
    --cc=zhichang.yuan02@gmail.com \
    --cc=zourongrong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.