[PATCH] busybox: enable fractional sleep arguments

[PATCH] busybox: enable fractional sleep arguments

[Nathan Lynch]

Fractional durations (e.g. 0.5s) for the sleep command are useful and
not terribly uncommon in practice, especially in scripts associated
with test cases (e.g. mdadm, lttng-tools).  Enable FEATURE_FLOAT_SLEEP
by default in order to avoid having to patch every instance of a
script using a fractional sleep.

The busybox binary gains a few hundred bytes in text (armv5e shown):

$ size -x busybox.nosuid.{before,after}
   text	   data	    bss	    dec	    hex	filename
0x89382	  0x71d	 0x2250	 572655	  8bcef	busybox.nosuid.before
0x8954e	  0x721	 0x2250	 573119	  8bebf	busybox.nosuid.after

Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
---
 meta/recipes-core/busybox/busybox/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/busybox/busybox/defconfig b/meta/recipes-core/busybox/busybox/defconfig
index c0459d59612b..cbdb1391fd33 100644
--- a/meta/recipes-core/busybox/busybox/defconfig
+++ b/meta/recipes-core/busybox/busybox/defconfig
@@ -279,7 +279,7 @@ CONFIG_SEQ=y
 # CONFIG_SHA3SUM is not set
 CONFIG_SLEEP=y
 CONFIG_FEATURE_FANCY_SLEEP=y
-# CONFIG_FEATURE_FLOAT_SLEEP is not set
+CONFIG_FEATURE_FLOAT_SLEEP=y
 CONFIG_SORT=y
 CONFIG_FEATURE_SORT_BIG=y
 # CONFIG_SPLIT is not set
-- 
2.7.4

Re: [PATCH] busybox: enable fractional sleep arguments

[Tom Rini]

On Thu, Nov 17, 2016 at 02:49:51PM -0600, Nathan Lynch wrote:
> Fractional durations (e.g. 0.5s) for the sleep command are useful and
> not terribly uncommon in practice, especially in scripts associated
> with test cases (e.g. mdadm, lttng-tools).  Enable FEATURE_FLOAT_SLEEP
> by default in order to avoid having to patch every instance of a
> script using a fractional sleep.
> 
> The busybox binary gains a few hundred bytes in text (armv5e shown):
> 
> $ size -x busybox.nosuid.{before,after}
>    text	   data	    bss	    dec	    hex	filename
> 0x89382	  0x71d	 0x2250	 572655	  8bcef	busybox.nosuid.before
> 0x8954e	  0x721	 0x2250	 573119	  8bebf	busybox.nosuid.after
> 
> Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>

It's also something I've seen customer use as well in their scripts so
this would remove the need to add it to the local layer.

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom