* [PATCH] busybox: enable fractional sleep arguments
@ 2016-11-17 20:49 Nathan Lynch
2016-11-18 20:22 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Lynch @ 2016-11-17 20:49 UTC (permalink / raw)
To: openembedded-core
Fractional durations (e.g. 0.5s) for the sleep command are useful and
not terribly uncommon in practice, especially in scripts associated
with test cases (e.g. mdadm, lttng-tools). Enable FEATURE_FLOAT_SLEEP
by default in order to avoid having to patch every instance of a
script using a fractional sleep.
The busybox binary gains a few hundred bytes in text (armv5e shown):
$ size -x busybox.nosuid.{before,after}
text data bss dec hex filename
0x89382 0x71d 0x2250 572655 8bcef busybox.nosuid.before
0x8954e 0x721 0x2250 573119 8bebf busybox.nosuid.after
Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
---
meta/recipes-core/busybox/busybox/defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/busybox/busybox/defconfig b/meta/recipes-core/busybox/busybox/defconfig
index c0459d59612b..cbdb1391fd33 100644
--- a/meta/recipes-core/busybox/busybox/defconfig
+++ b/meta/recipes-core/busybox/busybox/defconfig
@@ -279,7 +279,7 @@ CONFIG_SEQ=y
# CONFIG_SHA3SUM is not set
CONFIG_SLEEP=y
CONFIG_FEATURE_FANCY_SLEEP=y
-# CONFIG_FEATURE_FLOAT_SLEEP is not set
+CONFIG_FEATURE_FLOAT_SLEEP=y
CONFIG_SORT=y
CONFIG_FEATURE_SORT_BIG=y
# CONFIG_SPLIT is not set
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] busybox: enable fractional sleep arguments
2016-11-17 20:49 [PATCH] busybox: enable fractional sleep arguments Nathan Lynch
@ 2016-11-18 20:22 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2016-11-18 20:22 UTC (permalink / raw)
To: Nathan Lynch; +Cc: openembedded-core
On Thu, Nov 17, 2016 at 02:49:51PM -0600, Nathan Lynch wrote:
> Fractional durations (e.g. 0.5s) for the sleep command are useful and
> not terribly uncommon in practice, especially in scripts associated
> with test cases (e.g. mdadm, lttng-tools). Enable FEATURE_FLOAT_SLEEP
> by default in order to avoid having to patch every instance of a
> script using a fractional sleep.
>
> The busybox binary gains a few hundred bytes in text (armv5e shown):
>
> $ size -x busybox.nosuid.{before,after}
> text data bss dec hex filename
> 0x89382 0x71d 0x2250 572655 8bcef busybox.nosuid.before
> 0x8954e 0x721 0x2250 573119 8bebf busybox.nosuid.after
>
> Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
It's also something I've seen customer use as well in their scripts so
this would remove the need to add it to the local layer.
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-18 20:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-17 20:49 [PATCH] busybox: enable fractional sleep arguments Nathan Lynch
2016-11-18 20:22 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.