* [PATCH] Staging: iio: adc: fix sysfs files modes in ad7192.c
@ 2016-11-23 7:25 Boyan Vladinov
2016-11-23 7:37 ` Greg KH
2016-11-23 11:33 ` Joe Perches
0 siblings, 2 replies; 3+ messages in thread
From: Boyan Vladinov @ 2016-11-23 7:25 UTC (permalink / raw)
To: gregkh, lars, Michael.Hennerich
Cc: linux-iio, devel, linux-kernel, Boyan Vladinov
Fixes sysfs entries user/group modes and coding style warnings
found by checkpatch.pl tool
Signed-off-by: Boyan Vladinov <nayobix@nayobix.org>
---
drivers/staging/iio/adc/ad7192.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index 1fb68c01abd5..3f9f54b654f7 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -341,10 +341,10 @@ ad7192_show_scale_available(struct device *dev,
}
static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
- in_voltage-voltage_scale_available,
- S_IRUGO, ad7192_show_scale_available, NULL, 0);
+ in_voltage - voltage_scale_available,
+ 0444, ad7192_show_scale_available, NULL, 0);
-static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO,
+static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,
ad7192_show_scale_available, NULL, 0);
static ssize_t ad7192_show_ac_excitation(struct device *dev,
@@ -412,11 +412,11 @@ static ssize_t ad7192_set(struct device *dev,
return ret ? ret : len;
}
-static IIO_DEVICE_ATTR(bridge_switch_en, S_IRUGO | S_IWUSR,
+static IIO_DEVICE_ATTR(bridge_switch_en, 0444 | 0200,
ad7192_show_bridge_switch, ad7192_set,
AD7192_REG_GPOCON);
-static IIO_DEVICE_ATTR(ac_excitation_en, S_IRUGO | S_IWUSR,
+static IIO_DEVICE_ATTR(ac_excitation_en, 0444 | 0200,
ad7192_show_ac_excitation, ad7192_set,
AD7192_REG_MODE);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: iio: adc: fix sysfs files modes in ad7192.c
2016-11-23 7:25 [PATCH] Staging: iio: adc: fix sysfs files modes in ad7192.c Boyan Vladinov
@ 2016-11-23 7:37 ` Greg KH
2016-11-23 11:33 ` Joe Perches
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-11-23 7:37 UTC (permalink / raw)
To: Boyan Vladinov; +Cc: lars, Michael.Hennerich, linux-iio, devel, linux-kernel
On Tue, Nov 22, 2016 at 11:25:14PM -0800, Boyan Vladinov wrote:
> Fixes sysfs entries user/group modes and coding style warnings
> found by checkpatch.pl tool
>
> Signed-off-by: Boyan Vladinov <nayobix@nayobix.org>
> ---
> drivers/staging/iio/adc/ad7192.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 1fb68c01abd5..3f9f54b654f7 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -341,10 +341,10 @@ ad7192_show_scale_available(struct device *dev,
> }
>
> static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> - in_voltage-voltage_scale_available,
> - S_IRUGO, ad7192_show_scale_available, NULL, 0);
> + in_voltage - voltage_scale_available,
> + 0444, ad7192_show_scale_available, NULL, 0);
IIO_DEVICE_ATTR_RO() after fixing up some variable names?
>
> -static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO,
> +static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,
> ad7192_show_scale_available, NULL, 0);
IIO_DEVICE_ATTR_RO()?
>
> static ssize_t ad7192_show_ac_excitation(struct device *dev,
> @@ -412,11 +412,11 @@ static ssize_t ad7192_set(struct device *dev,
> return ret ? ret : len;
> }
>
> -static IIO_DEVICE_ATTR(bridge_switch_en, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(bridge_switch_en, 0444 | 0200,
> ad7192_show_bridge_switch, ad7192_set,
> AD7192_REG_GPOCON);
IIO_DEVICE_ATTR_RW()?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: iio: adc: fix sysfs files modes in ad7192.c
2016-11-23 7:25 [PATCH] Staging: iio: adc: fix sysfs files modes in ad7192.c Boyan Vladinov
2016-11-23 7:37 ` Greg KH
@ 2016-11-23 11:33 ` Joe Perches
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2016-11-23 11:33 UTC (permalink / raw)
To: Boyan Vladinov, gregkh, lars, Michael.Hennerich
Cc: linux-iio, devel, linux-kernel
On Tue, 2016-11-22 at 23:25 -0800, Boyan Vladinov wrote:
> Fixes sysfs entries user/group modes and coding style warnings
> found by checkpatch.pl tool
[]
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
[]
> static ssize_t ad7192_show_ac_excitation(struct device *dev,
> @@ -412,11 +412,11 @@ static ssize_t ad7192_set(struct device *dev,
> return ret ? ret : len;
> }
>
> -static IIO_DEVICE_ATTR(bridge_switch_en, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(bridge_switch_en, 0444 | 0200,
If you are going to submit S_<FOO> -> octal conversions,
please collapse the multiple octal values into one value
0444 | 0200 => 0644
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-23 11:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-23 7:25 [PATCH] Staging: iio: adc: fix sysfs files modes in ad7192.c Boyan Vladinov
2016-11-23 7:37 ` Greg KH
2016-11-23 11:33 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.