From: "Manuel Schölling" <manuel.schoelling@gmx.de> To: Adam Borowski <kilobyte@angband.pl> Cc: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, jslaby@suse.cz, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrey_utkin@fastmail.com Subject: Re: [PATCH v5 2/2] console: Add persistent scrollback buffers for all VGA consoles Date: Wed, 23 Nov 2016 18:33:55 +0100 [thread overview] Message-ID: <1479922435.5446.13.camel@gmx.de> (raw) In-Reply-To: <20161121201704.GA29655@angband.pl> On Mo, 2016-11-21 at 21:17 +0100, Adam Borowski wrote: > On Sun, Nov 20, 2016 at 10:58:08PM +0100, Manuel Schölling wrote: > > Add a scrollback buffers for each VGA console. The benefit is that > > the scrollback history is not flushed when switching between consoles > > but is persistent. > > The buffers are allocated on demand when a new console is opened. > > > > This breaks tools like clear_console that rely on flushing the > > scrollback history by switching back and forth between consoles > > which is why this feature is disabled by default. > > Use the escape sequence \e[3J instead for flushing the buffer. > > > > Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de> > > --- > But alas, this commit breaks that very \e[3J. It does only a \e[2J, leaving > the scrollback uncleared. For comparison, both mainline and with just your > preparatory commit, \e[3J works as expected. Thanks again for reporting this issue. I was finally able to reproduce it. Looks like the same problem arises when implementing persistent scrollback buffers for framebuffer consoles. I will have to think about the underlying issue a bit more, but I guess that the consw struct needs another field for a function that flushes the scrollback buffer. Before this was just done by switching the console, which is fine if you just have one buffer. But now each console has its own buffer, so simply calling vc_data's vc_sw->con_switch() won't be sufficient anymore.
WARNING: multiple messages have this Message-ID (diff)
From: "Manuel Schölling" <manuel.schoelling@gmx.de> To: Adam Borowski <kilobyte@angband.pl> Cc: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, jslaby@suse.cz, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrey_utkin@fastmail.com Subject: Re: [PATCH v5 2/2] console: Add persistent scrollback buffers for all VGA consoles Date: Wed, 23 Nov 2016 17:33:55 +0000 [thread overview] Message-ID: <1479922435.5446.13.camel@gmx.de> (raw) In-Reply-To: <20161121201704.GA29655@angband.pl> On Mo, 2016-11-21 at 21:17 +0100, Adam Borowski wrote: > On Sun, Nov 20, 2016 at 10:58:08PM +0100, Manuel Schölling wrote: > > Add a scrollback buffers for each VGA console. The benefit is that > > the scrollback history is not flushed when switching between consoles > > but is persistent. > > The buffers are allocated on demand when a new console is opened. > > > > This breaks tools like clear_console that rely on flushing the > > scrollback history by switching back and forth between consoles > > which is why this feature is disabled by default. > > Use the escape sequence \e[3J instead for flushing the buffer. > > > > Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de> > > --- > But alas, this commit breaks that very \e[3J. It does only a \e[2J, leaving > the scrollback uncleared. For comparison, both mainline and with just your > preparatory commit, \e[3J works as expected. Thanks again for reporting this issue. I was finally able to reproduce it. Looks like the same problem arises when implementing persistent scrollback buffers for framebuffer consoles. I will have to think about the underlying issue a bit more, but I guess that the consw struct needs another field for a function that flushes the scrollback buffer. Before this was just done by switching the console, which is fine if you just have one buffer. But now each console has its own buffer, so simply calling vc_data's vc_sw->con_switch() won't be sufficient anymore.
next prev parent reply other threads:[~2016-11-23 17:34 UTC|newest] Thread overview: 143+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20161118005309.GC26324@dell-m4800.home> 2016-11-20 21:58 ` [PATCH v5 0/2] console: Add persistent scrollback buffers for all VGA console Manuel Schölling 2016-11-20 21:58 ` Manuel Schölling 2016-11-20 21:58 ` [PATCH v5 1/2] console: Move scrollback data into its own struct Manuel Schölling 2016-11-20 21:58 ` Manuel Schölling 2016-11-20 21:58 ` [PATCH v5 2/2] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2016-11-20 21:58 ` Manuel Schölling 2016-11-20 22:23 ` kbuild test robot 2016-11-20 22:23 ` kbuild test robot 2016-11-21 20:17 ` Adam Borowski 2016-11-21 20:17 ` Adam Borowski 2016-11-22 16:56 ` Manuel Schölling 2016-11-22 16:56 ` Manuel Schölling 2016-11-23 17:33 ` Adam Borowski 2016-11-23 17:33 ` Adam Borowski 2016-11-27 16:51 ` [PATCH v7 0/3] " Manuel Schölling 2016-11-27 16:51 ` Manuel Schölling 2016-11-27 16:51 ` [PATCH v7 1/3] console: Move scrollback data into its own struct Manuel Schölling 2016-11-27 16:51 ` Manuel Schölling 2016-11-27 16:51 ` [PATCH v7 2/3] console: Add callback to flush scrollback buffer to consw struct Manuel Schölling 2016-11-27 16:51 ` Manuel Schölling 2016-11-27 16:51 ` [PATCH v7 3/3] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2016-11-27 16:51 ` Manuel Schölling 2016-11-27 21:37 ` [PATCH v7 0/3] " Andrey Utkin 2016-11-27 23:15 ` Adam Borowski 2016-11-27 23:15 ` Adam Borowski 2016-11-27 23:30 ` Jakub Wilk 2016-11-27 23:30 ` Jakub Wilk 2016-11-28 0:02 ` Andrey Utkin 2016-11-28 21:28 ` Manuel Schölling 2016-11-28 21:28 ` Manuel Schölling 2016-11-29 10:01 ` Andrey Utkin 2016-11-29 10:44 ` Adam Borowski 2016-11-29 10:44 ` Adam Borowski 2016-11-29 16:35 ` Manuel Schölling 2016-11-29 16:35 ` Manuel Schölling 2016-12-01 21:03 ` Manuel Schölling 2016-12-01 21:03 ` Manuel Schölling 2016-12-01 21:31 ` Andrey Utkin 2016-12-01 21:31 ` Andrey Utkin 2016-11-27 23:53 ` Adam Borowski 2016-11-27 23:53 ` Adam Borowski 2016-11-28 21:23 ` Manuel Schölling 2016-11-28 21:23 ` Manuel Schölling 2016-11-23 17:33 ` Manuel Schölling [this message] 2016-11-23 17:33 ` [PATCH v5 2/2] " Manuel Schölling 2016-12-04 10:53 [PATCH v7 0/3] " Manuel Schölling 2016-12-04 10:53 ` Manuel Schölling 2016-12-04 10:53 ` [PATCH v7 1/3] console: Move scrollback data into its own struct Manuel Schölling 2016-12-04 10:53 ` Manuel Schölling 2016-12-04 10:53 ` [PATCH v7 2/3] console: Add callback to flush scrollback buffer to consw struct Manuel Schölling 2016-12-04 10:53 ` Manuel Schölling 2016-12-04 10:53 ` [PATCH v7 3/3] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2016-12-04 10:53 ` Manuel Schölling 2016-12-06 10:02 ` [PATCH v7 0/3] " Greg KH 2016-12-06 10:02 ` Greg KH 2016-12-06 16:32 ` Manuel Schölling 2016-12-06 16:32 ` Manuel Schölling 2016-12-21 16:37 ` [PATCH RESEND " Manuel Schölling 2016-12-21 16:37 ` Manuel Schölling 2016-12-21 16:37 ` [PATCH RESEND v7 1/3] console: Move scrollback data into its own struct Manuel Schölling 2016-12-21 16:37 ` Manuel Schölling 2016-12-21 16:37 ` [PATCH RESEND v7 2/3] console: Add callback to flush scrollback buffer to consw struct Manuel Schölling 2016-12-21 16:37 ` Manuel Schölling 2016-12-21 16:37 ` [PATCH RESEND v7 3/3] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2016-12-21 16:37 ` Manuel Schölling 2017-01-04 13:54 ` [PATCH RESEND v7 0/3] " Andrey Utkin 2017-01-04 13:54 ` Andrey Utkin 2017-01-05 11:33 ` [PATCH v8 " Manuel Schölling 2017-01-05 11:33 ` Manuel Schölling 2017-01-05 11:33 ` [PATCH v8 1/3] console: Move scrollback data into its own struct Manuel Schölling 2017-01-05 11:33 ` Manuel Schölling 2017-01-05 11:33 ` [PATCH v8 2/3] console: Add callback to flush scrollback buffer to consw struct Manuel Schölling 2017-01-05 11:33 ` Manuel Schölling 2017-01-05 11:33 ` [PATCH v8 3/3] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2017-01-05 11:33 ` Manuel Schölling [not found] ` <CGME20170110162224epcas1p2095912fa6b73a1457fa86396149e78e9@epcas1p2.samsung.com> 2017-01-10 16:22 ` Bartlomiej Zolnierkiewicz 2017-01-10 16:22 ` Bartlomiej Zolnierkiewicz [not found] ` <CGME20170110164435epcas1p314efb9c6ea3ffb971fce06f3bfaec736@epcas1p3.samsung.com> 2017-01-10 16:44 ` Bartlomiej Zolnierkiewicz 2017-01-10 16:44 ` Bartlomiej Zolnierkiewicz 2017-01-10 17:31 ` Manuel Schölling 2017-01-10 17:31 ` Manuel Schölling 2017-01-10 21:28 ` [PATCH v9 0/4] " Manuel Schölling 2017-01-10 21:28 ` Manuel Schölling 2017-01-10 21:28 ` [PATCH v9 1/4] console: Move scrollback data into its own struct Manuel Schölling 2017-01-10 21:28 ` Manuel Schölling 2017-01-10 21:28 ` [PATCH v9 2/4] console: Add callback to flush scrollback buffer to consw struct Manuel Schölling 2017-01-10 21:28 ` Manuel Schölling 2017-01-10 21:28 ` [PATCH v9 3/4] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2017-01-10 21:28 ` Manuel Schölling 2017-01-10 21:28 ` [PATCH v9 4/4] console: Make persistent scrollback a boot parameter Manuel Schölling 2017-01-10 21:28 ` Manuel Schölling 2017-01-10 22:58 ` Adam Borowski 2017-01-10 22:58 ` Adam Borowski 2017-01-11 21:41 ` Manuel Schölling 2017-01-11 21:41 ` Manuel Schölling 2017-01-13 20:00 ` Manuel Schölling 2017-01-13 20:00 ` Manuel Schölling 2017-01-14 7:26 ` Greg KH 2017-01-14 7:26 ` Greg KH 2017-01-11 13:32 ` kbuild test robot 2017-01-11 13:32 ` kbuild test robot 2017-01-13 20:07 ` [PATCH v10 0/4] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2017-01-13 20:07 ` Manuel Schölling 2017-01-25 10:55 ` Greg KH 2017-01-25 10:55 ` Greg KH 2017-01-13 20:07 ` [PATCH v10 1/4] console: Move scrollback data into its own struct Manuel Schölling 2017-01-13 20:07 ` Manuel Schölling 2017-01-13 20:07 ` [PATCH v10 2/4] console: Add callback to flush scrollback buffer to consw struct Manuel Schölling 2017-01-13 20:07 ` Manuel Schölling 2017-01-13 20:07 ` [PATCH v10 3/4] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2017-01-13 20:07 ` Manuel Schölling 2017-01-19 13:23 ` Greg KH 2017-01-19 13:23 ` Greg KH 2017-01-19 16:12 ` Manuel Schölling 2017-01-19 16:12 ` Manuel Schölling 2017-01-19 16:33 ` Greg KH 2017-01-19 16:33 ` Greg KH 2017-01-19 23:04 ` Adam Borowski 2017-01-19 23:04 ` Adam Borowski 2017-01-20 13:16 ` Adam Borowski 2017-01-20 13:16 ` Adam Borowski 2017-01-20 13:31 ` Greg KH 2017-01-20 13:31 ` Greg KH 2017-01-20 14:27 ` Adam Borowski 2017-01-20 14:27 ` Adam Borowski 2017-01-19 17:20 ` Adam Borowski 2017-01-19 17:20 ` Adam Borowski 2017-01-13 20:07 ` [PATCH v10 4/4] console: Make persistent scrollback a boot parameter Manuel Schölling 2017-01-13 20:07 ` Manuel Schölling 2017-02-02 20:07 ` [PATCH v9 " Paul Gortmaker 2017-02-02 20:07 ` Paul Gortmaker 2017-02-03 16:04 ` Manuel Schölling 2017-02-03 16:04 ` Manuel Schölling 2017-02-03 16:45 ` Adam Borowski 2017-02-03 16:45 ` Adam Borowski 2017-01-02 14:27 ` [PATCH RESEND v7 0/3] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2017-01-02 14:27 ` Manuel Schölling 2017-01-02 14:27 ` [PATCH RESEND v7 1/3] console: Move scrollback data into its own struct Manuel Schölling 2017-01-02 14:27 ` Manuel Schölling 2017-01-02 14:27 ` [PATCH RESEND v7 2/3] console: Add callback to flush scrollback buffer to consw struct Manuel Schölling 2017-01-02 14:27 ` Manuel Schölling 2017-01-02 14:27 ` [PATCH RESEND v7 3/3] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2017-01-02 14:27 ` Manuel Schölling
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1479922435.5446.13.camel@gmx.de \ --to=manuel.schoelling@gmx.de \ --cc=andrey_utkin@fastmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=jslaby@suse.cz \ --cc=kilobyte@angband.pl \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=plagnioj@jcrosoft.com \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.