From: Greg KH <gregkh@linuxfoundation.org> To: "Manuel Schölling" <manuel.schoelling@gmx.de> Cc: Adam Borowski <kilobyte@angband.pl>, jslaby@suse.com, lkml14@scotdoyle.com, rdunlap@infradead.org, shorne@gmail.com, andrey_utkin@fastmail.com, akpm@linux-foundation.org, paul.burton@imgtec.com, daniel.vetter@ffwll.ch, tj@kernel.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter Date: Sat, 14 Jan 2017 08:26:13 +0100 [thread overview] Message-ID: <20170114072613.GA3856@kroah.com> (raw) In-Reply-To: <1484337634.1720.4.camel@gmx.de> On Fri, Jan 13, 2017 at 09:00:34PM +0100, Manuel Schölling wrote: > On Tue, 2017-01-10 at 23:58 +0100, Adam Borowski wrote: > > On Tue, Jan 10, 2017 at 10:28:38PM +0100, Manuel Schölling wrote: > > > The impact of the persistent scrollback feature on the code size is > > > rather small, so the config option is removed. The feature stays > > > disabled by default and can be enabled by using the boot command > > > line > > > parameter 'vgacon.scrollback_persistent=1' or by setting > > > VGACON_SOFT_SCROLLBACK_PERSISTENT_ENABLE_BY_DEFAULT=y. > > > > > > Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de> > > > Suggested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > > +module_param_named(scrollback_persistent, scrollback_persistent, > > > bool, 0000); > > > +MODULE_PARM_DESC(scrollback_persistent, "Enable persistent > > > scrollback for all vga consoles"); > > > > A command-line knob settable by the end-user is something more > > persistent > > than a config option. As you're going to extend this code beyond > > vgacon in > > the near future, perhaps it'd be better to have a shared setting for > > all > > console drivers? > According to the guys at #kernelnewbies on IRC everybody hates new > command line options. That was me, you can use my name here :) > I'd rather stick to the module parameter for now and maybe introduce a > new cmd line option later, once this feature has been implemented in > several console drivers. Yes, that should be fine. thanks, greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org> To: "Manuel Schölling" <manuel.schoelling@gmx.de> Cc: Adam Borowski <kilobyte@angband.pl>, jslaby@suse.com, lkml14@scotdoyle.com, rdunlap@infradead.org, shorne@gmail.com, andrey_utkin@fastmail.com, akpm@linux-foundation.org, paul.burton@imgtec.com, daniel.vetter@ffwll.ch, tj@kernel.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter Date: Sat, 14 Jan 2017 07:26:13 +0000 [thread overview] Message-ID: <20170114072613.GA3856@kroah.com> (raw) In-Reply-To: <1484337634.1720.4.camel@gmx.de> On Fri, Jan 13, 2017 at 09:00:34PM +0100, Manuel Schölling wrote: > On Tue, 2017-01-10 at 23:58 +0100, Adam Borowski wrote: > > On Tue, Jan 10, 2017 at 10:28:38PM +0100, Manuel Schölling wrote: > > > The impact of the persistent scrollback feature on the code size is > > > rather small, so the config option is removed. The feature stays > > > disabled by default and can be enabled by using the boot command > > > line > > > parameter 'vgacon.scrollback_persistent=1' or by setting > > > VGACON_SOFT_SCROLLBACK_PERSISTENT_ENABLE_BY_DEFAULT=y. > > > > > > Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de> > > > Suggested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > > +module_param_named(scrollback_persistent, scrollback_persistent, > > > bool, 0000); > > > +MODULE_PARM_DESC(scrollback_persistent, "Enable persistent > > > scrollback for all vga consoles"); > > > > A command-line knob settable by the end-user is something more > > persistent > > than a config option. As you're going to extend this code beyond > > vgacon in > > the near future, perhaps it'd be better to have a shared setting for > > all > > console drivers? > According to the guys at #kernelnewbies on IRC everybody hates new > command line options. That was me, you can use my name here :) > I'd rather stick to the module parameter for now and maybe introduce a > new cmd line option later, once this feature has been implemented in > several console drivers. Yes, that should be fine. thanks, greg k-h
next prev parent reply other threads:[~2017-01-14 7:26 UTC|newest] Thread overview: 143+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-12-04 10:53 [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2016-12-04 10:53 ` Manuel Schölling 2016-12-04 10:53 ` [PATCH v7 1/3] console: Move scrollback data into its own struct Manuel Schölling 2016-12-04 10:53 ` Manuel Schölling 2016-12-04 10:53 ` [PATCH v7 2/3] console: Add callback to flush scrollback buffer to consw struct Manuel Schölling 2016-12-04 10:53 ` Manuel Schölling 2016-12-04 10:53 ` [PATCH v7 3/3] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2016-12-04 10:53 ` Manuel Schölling 2016-12-06 10:02 ` [PATCH v7 0/3] " Greg KH 2016-12-06 10:02 ` Greg KH 2016-12-06 16:32 ` Manuel Schölling 2016-12-06 16:32 ` Manuel Schölling 2016-12-21 16:37 ` [PATCH RESEND " Manuel Schölling 2016-12-21 16:37 ` Manuel Schölling 2016-12-21 16:37 ` [PATCH RESEND v7 1/3] console: Move scrollback data into its own struct Manuel Schölling 2016-12-21 16:37 ` Manuel Schölling 2016-12-21 16:37 ` [PATCH RESEND v7 2/3] console: Add callback to flush scrollback buffer to consw struct Manuel Schölling 2016-12-21 16:37 ` Manuel Schölling 2016-12-21 16:37 ` [PATCH RESEND v7 3/3] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2016-12-21 16:37 ` Manuel Schölling 2017-01-04 13:54 ` [PATCH RESEND v7 0/3] " Andrey Utkin 2017-01-04 13:54 ` Andrey Utkin 2017-01-05 11:33 ` [PATCH v8 " Manuel Schölling 2017-01-05 11:33 ` Manuel Schölling 2017-01-05 11:33 ` [PATCH v8 1/3] console: Move scrollback data into its own struct Manuel Schölling 2017-01-05 11:33 ` Manuel Schölling 2017-01-05 11:33 ` [PATCH v8 2/3] console: Add callback to flush scrollback buffer to consw struct Manuel Schölling 2017-01-05 11:33 ` Manuel Schölling 2017-01-05 11:33 ` [PATCH v8 3/3] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2017-01-05 11:33 ` Manuel Schölling [not found] ` <CGME20170110162224epcas1p2095912fa6b73a1457fa86396149e78e9@epcas1p2.samsung.com> 2017-01-10 16:22 ` Bartlomiej Zolnierkiewicz 2017-01-10 16:22 ` Bartlomiej Zolnierkiewicz [not found] ` <CGME20170110164435epcas1p314efb9c6ea3ffb971fce06f3bfaec736@epcas1p3.samsung.com> 2017-01-10 16:44 ` Bartlomiej Zolnierkiewicz 2017-01-10 16:44 ` Bartlomiej Zolnierkiewicz 2017-01-10 17:31 ` Manuel Schölling 2017-01-10 17:31 ` Manuel Schölling 2017-01-10 21:28 ` [PATCH v9 0/4] " Manuel Schölling 2017-01-10 21:28 ` Manuel Schölling 2017-01-10 21:28 ` [PATCH v9 1/4] console: Move scrollback data into its own struct Manuel Schölling 2017-01-10 21:28 ` Manuel Schölling 2017-01-10 21:28 ` [PATCH v9 2/4] console: Add callback to flush scrollback buffer to consw struct Manuel Schölling 2017-01-10 21:28 ` Manuel Schölling 2017-01-10 21:28 ` [PATCH v9 3/4] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2017-01-10 21:28 ` Manuel Schölling 2017-01-10 21:28 ` [PATCH v9 4/4] console: Make persistent scrollback a boot parameter Manuel Schölling 2017-01-10 21:28 ` Manuel Schölling 2017-01-10 22:58 ` Adam Borowski 2017-01-10 22:58 ` Adam Borowski 2017-01-11 21:41 ` Manuel Schölling 2017-01-11 21:41 ` Manuel Schölling 2017-01-13 20:00 ` Manuel Schölling 2017-01-13 20:00 ` Manuel Schölling 2017-01-14 7:26 ` Greg KH [this message] 2017-01-14 7:26 ` Greg KH 2017-01-11 13:32 ` kbuild test robot 2017-01-11 13:32 ` kbuild test robot 2017-01-13 20:07 ` [PATCH v10 0/4] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2017-01-13 20:07 ` Manuel Schölling 2017-01-25 10:55 ` Greg KH 2017-01-25 10:55 ` Greg KH 2017-01-13 20:07 ` [PATCH v10 1/4] console: Move scrollback data into its own struct Manuel Schölling 2017-01-13 20:07 ` Manuel Schölling 2017-01-13 20:07 ` [PATCH v10 2/4] console: Add callback to flush scrollback buffer to consw struct Manuel Schölling 2017-01-13 20:07 ` Manuel Schölling 2017-01-13 20:07 ` [PATCH v10 3/4] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2017-01-13 20:07 ` Manuel Schölling 2017-01-19 13:23 ` Greg KH 2017-01-19 13:23 ` Greg KH 2017-01-19 16:12 ` Manuel Schölling 2017-01-19 16:12 ` Manuel Schölling 2017-01-19 16:33 ` Greg KH 2017-01-19 16:33 ` Greg KH 2017-01-19 23:04 ` Adam Borowski 2017-01-19 23:04 ` Adam Borowski 2017-01-20 13:16 ` Adam Borowski 2017-01-20 13:16 ` Adam Borowski 2017-01-20 13:31 ` Greg KH 2017-01-20 13:31 ` Greg KH 2017-01-20 14:27 ` Adam Borowski 2017-01-20 14:27 ` Adam Borowski 2017-01-19 17:20 ` Adam Borowski 2017-01-19 17:20 ` Adam Borowski 2017-01-13 20:07 ` [PATCH v10 4/4] console: Make persistent scrollback a boot parameter Manuel Schölling 2017-01-13 20:07 ` Manuel Schölling 2017-02-02 20:07 ` [PATCH v9 " Paul Gortmaker 2017-02-02 20:07 ` Paul Gortmaker 2017-02-03 16:04 ` Manuel Schölling 2017-02-03 16:04 ` Manuel Schölling 2017-02-03 16:45 ` Adam Borowski 2017-02-03 16:45 ` Adam Borowski 2017-01-02 14:27 ` [PATCH RESEND v7 0/3] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2017-01-02 14:27 ` Manuel Schölling 2017-01-02 14:27 ` [PATCH RESEND v7 1/3] console: Move scrollback data into its own struct Manuel Schölling 2017-01-02 14:27 ` Manuel Schölling 2017-01-02 14:27 ` [PATCH RESEND v7 2/3] console: Add callback to flush scrollback buffer to consw struct Manuel Schölling 2017-01-02 14:27 ` Manuel Schölling 2017-01-02 14:27 ` [PATCH RESEND v7 3/3] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2017-01-02 14:27 ` Manuel Schölling [not found] <20161118005309.GC26324@dell-m4800.home> 2016-11-20 21:58 ` [PATCH v5 0/2] console: Add persistent scrollback buffers for all VGA console Manuel Schölling 2016-11-20 21:58 ` Manuel Schölling 2016-11-20 21:58 ` [PATCH v5 1/2] console: Move scrollback data into its own struct Manuel Schölling 2016-11-20 21:58 ` Manuel Schölling 2016-11-20 21:58 ` [PATCH v5 2/2] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2016-11-20 21:58 ` Manuel Schölling 2016-11-20 22:23 ` kbuild test robot 2016-11-20 22:23 ` kbuild test robot 2016-11-21 20:17 ` Adam Borowski 2016-11-21 20:17 ` Adam Borowski 2016-11-22 16:56 ` Manuel Schölling 2016-11-22 16:56 ` Manuel Schölling 2016-11-23 17:33 ` Adam Borowski 2016-11-23 17:33 ` Adam Borowski 2016-11-27 16:51 ` [PATCH v7 0/3] " Manuel Schölling 2016-11-27 16:51 ` Manuel Schölling 2016-11-27 16:51 ` [PATCH v7 1/3] console: Move scrollback data into its own struct Manuel Schölling 2016-11-27 16:51 ` Manuel Schölling 2016-11-27 16:51 ` [PATCH v7 2/3] console: Add callback to flush scrollback buffer to consw struct Manuel Schölling 2016-11-27 16:51 ` Manuel Schölling 2016-11-27 16:51 ` [PATCH v7 3/3] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling 2016-11-27 16:51 ` Manuel Schölling 2016-11-27 21:37 ` [PATCH v7 0/3] " Andrey Utkin 2016-11-27 23:15 ` Adam Borowski 2016-11-27 23:15 ` Adam Borowski 2016-11-27 23:30 ` Jakub Wilk 2016-11-27 23:30 ` Jakub Wilk 2016-11-28 0:02 ` Andrey Utkin 2016-11-28 21:28 ` Manuel Schölling 2016-11-28 21:28 ` Manuel Schölling 2016-11-29 10:01 ` Andrey Utkin 2016-11-29 10:44 ` Adam Borowski 2016-11-29 10:44 ` Adam Borowski 2016-11-29 16:35 ` Manuel Schölling 2016-11-29 16:35 ` Manuel Schölling 2016-12-01 21:03 ` Manuel Schölling 2016-12-01 21:03 ` Manuel Schölling 2016-12-01 21:31 ` Andrey Utkin 2016-12-01 21:31 ` Andrey Utkin 2016-11-27 23:53 ` Adam Borowski 2016-11-27 23:53 ` Adam Borowski 2016-11-28 21:23 ` Manuel Schölling 2016-11-28 21:23 ` Manuel Schölling 2016-11-23 17:33 ` [PATCH v5 2/2] " Manuel Schölling 2016-11-23 17:33 ` Manuel Schölling
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170114072613.GA3856@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=akpm@linux-foundation.org \ --cc=andrey_utkin@fastmail.com \ --cc=daniel.vetter@ffwll.ch \ --cc=hdegoede@redhat.com \ --cc=jslaby@suse.com \ --cc=kilobyte@angband.pl \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lkml14@scotdoyle.com \ --cc=manuel.schoelling@gmx.de \ --cc=paul.burton@imgtec.com \ --cc=rdunlap@infradead.org \ --cc=shorne@gmail.com \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.