From: Eric Dumazet <eric.dumazet@gmail.com>
To: Saeed Mahameed <saeedm@dev.mellanox.co.il>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Tariq Toukan <tariqt@mellanox.com>
Subject: Re: Regression: [PATCH] mlx4: give precise rx/tx bytes/packets counters
Date: Wed, 30 Nov 2016 09:35:21 -0800 [thread overview]
Message-ID: <1480527321.18162.196.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <CALzJLG8pcuNo4uD3+dVms1gHT9=WfZAM1DDp_J10NgBZ7YZnEA@mail.gmail.com>
On Wed, 2016-11-30 at 18:46 +0200, Saeed Mahameed wrote:
> we had/still have the proper stats they are the ones that
> mlx4_en_fold_software_stats is trying to cache into (they always
> exist),
> but the ones that you are trying to read from (the mlx4 rings) are gone !
>
> This bug is totally new and as i warned, this is another symptom of
> the real root cause (can't sleep while reading stats).
>
> Eric what do you suggest ? Keep pre-allocated MAX_RINGS stats and
> always iterate over all of them to query stats ?
> what if you have one ring/none/1K ? how would you know how many to query ?
I am suggesting I will fix the bug I introduced.
Do not panic.
next prev parent reply other threads:[~2016-11-30 17:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 15:46 [PATCH] mlx4: give precise rx/tx bytes/packets counters Eric Dumazet
2016-11-25 16:03 ` David Laight
2016-11-25 16:16 ` Eric Dumazet
2016-11-25 16:30 ` Aw: " Lino Sanfilippo
2016-11-25 19:19 ` Eric Dumazet
2016-11-28 22:02 ` Lino Sanfilippo
2016-11-29 0:19 ` Eric Dumazet
2016-11-30 15:28 ` David Laight
2016-11-30 15:47 ` Eric Dumazet
2016-11-26 22:47 ` Saeed Mahameed
2016-11-27 2:16 ` Eric Dumazet
2016-11-28 20:40 ` David Miller
2016-11-28 21:55 ` Saeed Mahameed
2016-11-28 22:57 ` Eric Dumazet
2016-11-29 18:37 ` David Miller
2016-11-30 14:08 ` Regression: " Jesper Dangaard Brouer
2016-11-30 15:58 ` Eric Dumazet
2016-11-30 16:46 ` Saeed Mahameed
2016-11-30 17:35 ` Eric Dumazet [this message]
2016-11-30 20:42 ` Saeed Mahameed
2016-11-30 21:00 ` Eric Dumazet
2016-12-01 12:37 ` Jesper Dangaard Brouer
2016-12-01 13:02 ` [PATCH net-next] mlx4: fix use-after-free in mlx4_en_fold_software_stats() Eric Dumazet
2016-12-01 15:23 ` Saeed Mahameed
2016-12-02 18:36 ` David Miller
2016-12-01 15:38 ` Regression: [PATCH] mlx4: give precise rx/tx bytes/packets counters Saeed Mahameed
2016-12-01 15:55 ` Eric Dumazet
2016-12-01 16:08 ` Eric Dumazet
2016-12-01 17:36 ` Eric Dumazet
2016-12-04 13:23 ` Saeed Mahameed
2016-12-01 16:33 ` Saeed Mahameed
2016-12-01 17:08 ` Eric Dumazet
2016-12-04 13:21 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480527321.18162.196.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=saeedm@dev.mellanox.co.il \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.