From: Eric Dumazet <eric.dumazet@gmail.com>
To: Saeed Mahameed <saeedm@dev.mellanox.co.il>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Tariq Toukan <tariqt@mellanox.com>
Subject: Re: Regression: [PATCH] mlx4: give precise rx/tx bytes/packets counters
Date: Thu, 01 Dec 2016 09:36:04 -0800 [thread overview]
Message-ID: <1480613764.18162.324.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <1480608517.18162.313.camel@edumazet-glaptop3.roam.corp.google.com>
On Thu, 2016-12-01 at 08:08 -0800, Eric Dumazet wrote:
> On Thu, 2016-12-01 at 07:55 -0800, Eric Dumazet wrote:
>
> > So removing the spinlock is doable, but needs to add a new parameter
> > to mlx4_en_fold_software_stats() and call netdev_stats_to_stats64()
> > before mlx4_en_fold_software_stats(dev)
>
> Untested patch would be :
>
> drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 2 -
> drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 10 +----
> drivers/net/ethernet/mellanox/mlx4/en_port.c | 24 +++++++++-----
> drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 3 +
> 4 files changed, 23 insertions(+), 16 deletions(-)
The patch is wrong, since priv->port_up could change to false while we
are running and using the about to be deleted tx/rx rings.
So the only safe thing to do is to remove the _bh suffix.
Not worth trying to avoid taking a spinlock in this code.
next prev parent reply other threads:[~2016-12-01 17:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 15:46 [PATCH] mlx4: give precise rx/tx bytes/packets counters Eric Dumazet
2016-11-25 16:03 ` David Laight
2016-11-25 16:16 ` Eric Dumazet
2016-11-25 16:30 ` Aw: " Lino Sanfilippo
2016-11-25 19:19 ` Eric Dumazet
2016-11-28 22:02 ` Lino Sanfilippo
2016-11-29 0:19 ` Eric Dumazet
2016-11-30 15:28 ` David Laight
2016-11-30 15:47 ` Eric Dumazet
2016-11-26 22:47 ` Saeed Mahameed
2016-11-27 2:16 ` Eric Dumazet
2016-11-28 20:40 ` David Miller
2016-11-28 21:55 ` Saeed Mahameed
2016-11-28 22:57 ` Eric Dumazet
2016-11-29 18:37 ` David Miller
2016-11-30 14:08 ` Regression: " Jesper Dangaard Brouer
2016-11-30 15:58 ` Eric Dumazet
2016-11-30 16:46 ` Saeed Mahameed
2016-11-30 17:35 ` Eric Dumazet
2016-11-30 20:42 ` Saeed Mahameed
2016-11-30 21:00 ` Eric Dumazet
2016-12-01 12:37 ` Jesper Dangaard Brouer
2016-12-01 13:02 ` [PATCH net-next] mlx4: fix use-after-free in mlx4_en_fold_software_stats() Eric Dumazet
2016-12-01 15:23 ` Saeed Mahameed
2016-12-02 18:36 ` David Miller
2016-12-01 15:38 ` Regression: [PATCH] mlx4: give precise rx/tx bytes/packets counters Saeed Mahameed
2016-12-01 15:55 ` Eric Dumazet
2016-12-01 16:08 ` Eric Dumazet
2016-12-01 17:36 ` Eric Dumazet [this message]
2016-12-04 13:23 ` Saeed Mahameed
2016-12-01 16:33 ` Saeed Mahameed
2016-12-01 17:08 ` Eric Dumazet
2016-12-04 13:21 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480613764.18162.324.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=saeedm@dev.mellanox.co.il \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.