All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xunlei Pang <xlpang@redhat.com>
To: kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, Xunlei Pang <xlpang@redhat.com>,
	Robert LeBlanc <robert@leblancnet.us>,
	Baoquan He <bhe@redhat.com>
Subject: [PATCH] x86/crash: Update the stale comment in reserve_crashkernel()
Date: Thu, 15 Dec 2016 11:30:21 +0800	[thread overview]
Message-ID: <1481772621-17923-1-git-send-email-xlpang@redhat.com> (raw)

CRASH_KERNEL_ADDR_MAX was missing for a long time, update it
with more detailed explanation.

Cc: Robert LeBlanc <robert@leblancnet.us>
Cc: Baoquan He <bhe@redhat.com>
Signed-off-by: Xunlei Pang <xlpang@redhat.com>
---
 arch/x86/kernel/setup.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 9c337b0..79ee507 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -575,7 +575,10 @@ static void __init reserve_crashkernel(void)
 	/* 0 means: find the address automatically */
 	if (crash_base <= 0) {
 		/*
-		 *  kexec want bzImage is below CRASH_KERNEL_ADDR_MAX
+		 * Set CRASH_ADDR_LOW_MAX upper bound for crash range
+		 * as old kexec-tools loads bzImage below that, unless
+		 * "size,high" or "size@offset"(nonzero offset, see the
+		 * else leg below) is specified.
 		 */
 		crash_base = memblock_find_in_range(CRASH_ALIGN,
 						    high ? CRASH_ADDR_HIGH_MAX
-- 
1.8.3.1

WARNING: multiple messages have this Message-ID (diff)
From: Xunlei Pang <xlpang@redhat.com>
To: kexec@lists.infradead.org
Cc: Robert LeBlanc <robert@leblancnet.us>,
	Xunlei Pang <xlpang@redhat.com>,
	linux-kernel@vger.kernel.org, Baoquan He <bhe@redhat.com>
Subject: [PATCH] x86/crash: Update the stale comment in reserve_crashkernel()
Date: Thu, 15 Dec 2016 11:30:21 +0800	[thread overview]
Message-ID: <1481772621-17923-1-git-send-email-xlpang@redhat.com> (raw)

CRASH_KERNEL_ADDR_MAX was missing for a long time, update it
with more detailed explanation.

Cc: Robert LeBlanc <robert@leblancnet.us>
Cc: Baoquan He <bhe@redhat.com>
Signed-off-by: Xunlei Pang <xlpang@redhat.com>
---
 arch/x86/kernel/setup.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 9c337b0..79ee507 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -575,7 +575,10 @@ static void __init reserve_crashkernel(void)
 	/* 0 means: find the address automatically */
 	if (crash_base <= 0) {
 		/*
-		 *  kexec want bzImage is below CRASH_KERNEL_ADDR_MAX
+		 * Set CRASH_ADDR_LOW_MAX upper bound for crash range
+		 * as old kexec-tools loads bzImage below that, unless
+		 * "size,high" or "size@offset"(nonzero offset, see the
+		 * else leg below) is specified.
 		 */
 		crash_base = memblock_find_in_range(CRASH_ALIGN,
 						    high ? CRASH_ADDR_HIGH_MAX
-- 
1.8.3.1


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

             reply	other threads:[~2016-12-15  3:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-15  3:30 Xunlei Pang [this message]
2016-12-15  3:30 ` [PATCH] x86/crash: Update the stale comment in reserve_crashkernel() Xunlei Pang
2016-12-22  3:22 ` Baoquan He
2016-12-22  3:22   ` Baoquan He
2016-12-23  8:37   ` Xunlei Pang
2016-12-23  8:37     ` Xunlei Pang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481772621-17923-1-git-send-email-xlpang@redhat.com \
    --to=xlpang@redhat.com \
    --cc=bhe@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert@leblancnet.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.