* [PATCH] x86/crash: Update the stale comment in reserve_crashkernel()
@ 2016-12-15 3:30 ` Xunlei Pang
0 siblings, 0 replies; 6+ messages in thread
From: Xunlei Pang @ 2016-12-15 3:30 UTC (permalink / raw)
To: kexec; +Cc: linux-kernel, Xunlei Pang, Robert LeBlanc, Baoquan He
CRASH_KERNEL_ADDR_MAX was missing for a long time, update it
with more detailed explanation.
Cc: Robert LeBlanc <robert@leblancnet.us>
Cc: Baoquan He <bhe@redhat.com>
Signed-off-by: Xunlei Pang <xlpang@redhat.com>
---
arch/x86/kernel/setup.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 9c337b0..79ee507 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -575,7 +575,10 @@ static void __init reserve_crashkernel(void)
/* 0 means: find the address automatically */
if (crash_base <= 0) {
/*
- * kexec want bzImage is below CRASH_KERNEL_ADDR_MAX
+ * Set CRASH_ADDR_LOW_MAX upper bound for crash range
+ * as old kexec-tools loads bzImage below that, unless
+ * "size,high" or "size@offset"(nonzero offset, see the
+ * else leg below) is specified.
*/
crash_base = memblock_find_in_range(CRASH_ALIGN,
high ? CRASH_ADDR_HIGH_MAX
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] x86/crash: Update the stale comment in reserve_crashkernel()
@ 2016-12-15 3:30 ` Xunlei Pang
0 siblings, 0 replies; 6+ messages in thread
From: Xunlei Pang @ 2016-12-15 3:30 UTC (permalink / raw)
To: kexec; +Cc: Robert LeBlanc, Xunlei Pang, linux-kernel, Baoquan He
CRASH_KERNEL_ADDR_MAX was missing for a long time, update it
with more detailed explanation.
Cc: Robert LeBlanc <robert@leblancnet.us>
Cc: Baoquan He <bhe@redhat.com>
Signed-off-by: Xunlei Pang <xlpang@redhat.com>
---
arch/x86/kernel/setup.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 9c337b0..79ee507 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -575,7 +575,10 @@ static void __init reserve_crashkernel(void)
/* 0 means: find the address automatically */
if (crash_base <= 0) {
/*
- * kexec want bzImage is below CRASH_KERNEL_ADDR_MAX
+ * Set CRASH_ADDR_LOW_MAX upper bound for crash range
+ * as old kexec-tools loads bzImage below that, unless
+ * "size,high" or "size@offset"(nonzero offset, see the
+ * else leg below) is specified.
*/
crash_base = memblock_find_in_range(CRASH_ALIGN,
high ? CRASH_ADDR_HIGH_MAX
--
1.8.3.1
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] x86/crash: Update the stale comment in reserve_crashkernel()
2016-12-15 3:30 ` Xunlei Pang
@ 2016-12-22 3:22 ` Baoquan He
-1 siblings, 0 replies; 6+ messages in thread
From: Baoquan He @ 2016-12-22 3:22 UTC (permalink / raw)
To: Xunlei Pang; +Cc: kexec, Robert LeBlanc, linux-kernel
On 12/15/16 at 11:30am, Xunlei Pang wrote:
> CRASH_KERNEL_ADDR_MAX was missing for a long time, update it
> with more detailed explanation.
>
> Cc: Robert LeBlanc <robert@leblancnet.us>
> Cc: Baoquan He <bhe@redhat.com>
> Signed-off-by: Xunlei Pang <xlpang@redhat.com>
> ---
> arch/x86/kernel/setup.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 9c337b0..79ee507 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -575,7 +575,10 @@ static void __init reserve_crashkernel(void)
> /* 0 means: find the address automatically */
> if (crash_base <= 0) {
> /*
> - * kexec want bzImage is below CRASH_KERNEL_ADDR_MAX
> + * Set CRASH_ADDR_LOW_MAX upper bound for crash range
> + * as old kexec-tools loads bzImage below that, unless
> + * "size,high" or "size@offset"(nonzero offset, see the
> + * else leg below) is specified.
Yes, this is a good catch. It might be better to add comment only about
this if branch. If you want to say more about the upper bounds, better
discuss with Robert LeBlanc to see if it can be detailed in kdump.txt.
Also please CC to x86 maintainers, or akpm. They can help merge this.
Thanks
Baoquan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] x86/crash: Update the stale comment in reserve_crashkernel()
@ 2016-12-22 3:22 ` Baoquan He
0 siblings, 0 replies; 6+ messages in thread
From: Baoquan He @ 2016-12-22 3:22 UTC (permalink / raw)
To: Xunlei Pang; +Cc: Robert LeBlanc, kexec, linux-kernel
On 12/15/16 at 11:30am, Xunlei Pang wrote:
> CRASH_KERNEL_ADDR_MAX was missing for a long time, update it
> with more detailed explanation.
>
> Cc: Robert LeBlanc <robert@leblancnet.us>
> Cc: Baoquan He <bhe@redhat.com>
> Signed-off-by: Xunlei Pang <xlpang@redhat.com>
> ---
> arch/x86/kernel/setup.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 9c337b0..79ee507 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -575,7 +575,10 @@ static void __init reserve_crashkernel(void)
> /* 0 means: find the address automatically */
> if (crash_base <= 0) {
> /*
> - * kexec want bzImage is below CRASH_KERNEL_ADDR_MAX
> + * Set CRASH_ADDR_LOW_MAX upper bound for crash range
> + * as old kexec-tools loads bzImage below that, unless
> + * "size,high" or "size@offset"(nonzero offset, see the
> + * else leg below) is specified.
Yes, this is a good catch. It might be better to add comment only about
this if branch. If you want to say more about the upper bounds, better
discuss with Robert LeBlanc to see if it can be detailed in kdump.txt.
Also please CC to x86 maintainers, or akpm. They can help merge this.
Thanks
Baoquan
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] x86/crash: Update the stale comment in reserve_crashkernel()
2016-12-22 3:22 ` Baoquan He
@ 2016-12-23 8:37 ` Xunlei Pang
-1 siblings, 0 replies; 6+ messages in thread
From: Xunlei Pang @ 2016-12-23 8:37 UTC (permalink / raw)
To: Baoquan He, Xunlei Pang; +Cc: Robert LeBlanc, kexec, linux-kernel
On 12/22/2016 at 11:22 AM, Baoquan He wrote:
> On 12/15/16 at 11:30am, Xunlei Pang wrote:
>> CRASH_KERNEL_ADDR_MAX was missing for a long time, update it
>> with more detailed explanation.
>>
>> Cc: Robert LeBlanc <robert@leblancnet.us>
>> Cc: Baoquan He <bhe@redhat.com>
>> Signed-off-by: Xunlei Pang <xlpang@redhat.com>
>> ---
>> arch/x86/kernel/setup.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
>> index 9c337b0..79ee507 100644
>> --- a/arch/x86/kernel/setup.c
>> +++ b/arch/x86/kernel/setup.c
>> @@ -575,7 +575,10 @@ static void __init reserve_crashkernel(void)
>> /* 0 means: find the address automatically */
>> if (crash_base <= 0) {
>> /*
>> - * kexec want bzImage is below CRASH_KERNEL_ADDR_MAX
>> + * Set CRASH_ADDR_LOW_MAX upper bound for crash range
>> + * as old kexec-tools loads bzImage below that, unless
>> + * "size,high" or "size@offset"(nonzero offset, see the
>> + * else leg below) is specified.
> Yes, this is a good catch. It might be better to add comment only about
> this if branch. If you want to say more about the upper bounds, better
OK, how about the following change?
/*
* Set CRASH_ADDR_LOW_MAX upper bound for crash memory.
* as old kexec-tools loads bzImage below that, unless
* "crashkernel=size[KMG],high" is specified.
*/
> discuss with Robert LeBlanc to see if it can be detailed in kdump.txt.
Yes, this is independent of Robert's documentation patch.
>
> Also please CC to x86 maintainers, or akpm. They can help merge this.
OK, thanks!
Regards,
Xunlei
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] x86/crash: Update the stale comment in reserve_crashkernel()
@ 2016-12-23 8:37 ` Xunlei Pang
0 siblings, 0 replies; 6+ messages in thread
From: Xunlei Pang @ 2016-12-23 8:37 UTC (permalink / raw)
To: Baoquan He, Xunlei Pang; +Cc: Robert LeBlanc, kexec, linux-kernel
On 12/22/2016 at 11:22 AM, Baoquan He wrote:
> On 12/15/16 at 11:30am, Xunlei Pang wrote:
>> CRASH_KERNEL_ADDR_MAX was missing for a long time, update it
>> with more detailed explanation.
>>
>> Cc: Robert LeBlanc <robert@leblancnet.us>
>> Cc: Baoquan He <bhe@redhat.com>
>> Signed-off-by: Xunlei Pang <xlpang@redhat.com>
>> ---
>> arch/x86/kernel/setup.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
>> index 9c337b0..79ee507 100644
>> --- a/arch/x86/kernel/setup.c
>> +++ b/arch/x86/kernel/setup.c
>> @@ -575,7 +575,10 @@ static void __init reserve_crashkernel(void)
>> /* 0 means: find the address automatically */
>> if (crash_base <= 0) {
>> /*
>> - * kexec want bzImage is below CRASH_KERNEL_ADDR_MAX
>> + * Set CRASH_ADDR_LOW_MAX upper bound for crash range
>> + * as old kexec-tools loads bzImage below that, unless
>> + * "size,high" or "size@offset"(nonzero offset, see the
>> + * else leg below) is specified.
> Yes, this is a good catch. It might be better to add comment only about
> this if branch. If you want to say more about the upper bounds, better
OK, how about the following change?
/*
* Set CRASH_ADDR_LOW_MAX upper bound for crash memory.
* as old kexec-tools loads bzImage below that, unless
* "crashkernel=size[KMG],high" is specified.
*/
> discuss with Robert LeBlanc to see if it can be detailed in kdump.txt.
Yes, this is independent of Robert's documentation patch.
>
> Also please CC to x86 maintainers, or akpm. They can help merge this.
OK, thanks!
Regards,
Xunlei
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-12-23 8:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-15 3:30 [PATCH] x86/crash: Update the stale comment in reserve_crashkernel() Xunlei Pang
2016-12-15 3:30 ` Xunlei Pang
2016-12-22 3:22 ` Baoquan He
2016-12-22 3:22 ` Baoquan He
2016-12-23 8:37 ` Xunlei Pang
2016-12-23 8:37 ` Xunlei Pang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.