All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@aj.id.au>
To: Cyril Bur <cyrilbur@gmail.com>, openbmc@lists.ozlabs.org
Cc: millerjo@linux.vnet.ibm.com
Subject: Re: [PATCH v2 1/5] ARM: dts: aspeed: Reserve BMC ram for host to BMC communication
Date: Fri, 23 Dec 2016 11:31:46 +1030	[thread overview]
Message-ID: <1482454906.3419.24.camel@aj.id.au> (raw)
In-Reply-To: <20161222060610.29695-2-cyrilbur@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1745 bytes --]

Hi Cyril,

On Thu, 2016-12-22 at 17:06 +1100, Cyril Bur wrote:
> > Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 12 ++++++++++++
>  arch/arm/boot/dts/aspeed-g4.dtsi              |  6 ++++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> index 13e9f18fbed8..b60044800ea1 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> @@ -29,6 +29,18 @@
> >  			no-map;
> >  			reg = <0x5f000000 0x01000000>; /* 16MB */
> >  		};
> +
> > > +		flash_memory: region@54000000 {
> > +			compatible = "aspeed,ast2400-lpc-ctrl";
> > +			no-map;
> > +			reg = <0x54000000 0x04000000>; /* 64M */
> > +		};
> > +	};
> +
> > +	flash_buffer@1e789000 {
> > +		compatible = "aspeed,ast2400-lpc-ctrl";
> > +		memory-region = <&flash_memory>;
> > +		reg = <0x1e789000 0x8>;
>  	};

Save this for addition in 2/5?

>  
>          leds {
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index 7c78eb1c01ff..1ed2a9ba7ab8 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -870,6 +870,12 @@
> >  				interrupts = <8>;
> >  			};
>  
> > > +			mbox: mbox@1e789200 {
> > +				compatible = "aspeed,ast2400-mbox";
> > +				reg = <0x1e789200 0x5c>;
> > +				interrupts = <46>;
> +			};

Save this for addition in 3/5?

Or maybe just squash them all together?

Andrew

> +
> > >  			wdt1: wdt@1e785000 {
> >  				compatible = "aspeed,ast2400-wdt";
> >  				reg = <0x1e785000 0x1c>;

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2016-12-23  1:01 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-22  6:06 [PATCH v2 0/5] LPC/MBOX work Cyril Bur
2016-12-22  6:06 ` [PATCH v2 1/5] ARM: dts: aspeed: Reserve BMC ram for host to BMC communication Cyril Bur
2016-12-23  1:01   ` Andrew Jeffery [this message]
2016-12-23  7:50     ` Cyril Bur
2016-12-22  6:06 ` [PATCH v2 2/5] ARM: dts: aspeed: Put the lpc_ctrl under lpc_host node for regmap Cyril Bur
2016-12-22  6:06 ` [PATCH v2 3/5] ARM: dts: aspeed: Move mbox under lpc_host node Cyril Bur
2016-12-22  6:06 ` [PATCH v2 4/5] drivers/mailbox: Add aspeed ast2400/ast2500 mbox driver Cyril Bur
2016-12-23  2:42   ` Andrew Jeffery
2016-12-23  7:56     ` Cyril Bur
2017-01-03  1:24       ` Andrew Jeffery
2017-01-08 21:44         ` Benjamin Herrenschmidt
2017-01-08 23:54           ` Andrew Jeffery
2017-01-08 21:45         ` Benjamin Herrenschmidt
2017-01-09 22:09           ` Cyril Bur
2017-01-09 22:55             ` Andrew Jeffery
2017-01-09 23:18               ` Cyril Bur
2017-01-10  0:07               ` Cyril Bur
2017-01-10  0:10                 ` Andrew Jeffery
2017-01-10  4:28               ` Benjamin Herrenschmidt
2017-01-10  4:36                 ` Cyril Bur
2017-01-10  4:40                   ` Benjamin Herrenschmidt
2017-01-08 21:39   ` Benjamin Herrenschmidt
2016-12-22  6:06 ` [PATCH v2 5/5] drivers/misc: Add aspeed ast2400/ast2500 lpc controlling driver Cyril Bur
2016-12-22 23:54   ` Cyril Bur
2016-12-23  2:43     ` Andrew Jeffery
2016-12-23  2:55   ` Andrew Jeffery
2016-12-23  8:04     ` Cyril Bur
2017-01-03  1:33       ` Andrew Jeffery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1482454906.3419.24.camel@aj.id.au \
    --to=andrew@aj.id.au \
    --cc=cyrilbur@gmail.com \
    --cc=millerjo@linux.vnet.ibm.com \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.