Re: [PATCH v2 1/5] ARM: dts: aspeed: Reserve BMC ram for host to BMC communication

[Cyril Bur <cyrilbur@gmail.com>]

On Fri, 2016-12-23 at 11:31 +1030, Andrew Jeffery wrote:
> Hi Cyril,
> 
> On Thu, 2016-12-22 at 17:06 +1100, Cyril Bur wrote:
> > > Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
> > 
> > ---
> >  arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 12 ++++++++++++
> >  arch/arm/boot/dts/aspeed-g4.dtsi              |  6 ++++++
> >  2 files changed, 18 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> > index 13e9f18fbed8..b60044800ea1 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> > @@ -29,6 +29,18 @@
> > >  			no-map;
> > >  			reg = <0x5f000000 0x01000000>; /* 16MB */
> > >  		};
> > 
> > +
> > > > +		flash_memory: region@54000000 {
> > > 
> > > +			compatible = "aspeed,ast2400-lpc-ctrl";
> > > +			no-map;
> > > +			reg = <0x54000000 0x04000000>; /* 64M */
> > > +		};
> > > +	};
> > 
> > +
> > > +	flash_buffer@1e789000 {
> > > +		compatible = "aspeed,ast2400-lpc-ctrl";
> > > +		memory-region = <&flash_memory>;
> > > +		reg = <0x1e789000 0x8>;
> > 
> >  	};
> 
> Save this for addition in 2/5?
> 
> >  
> >          leds {
> > diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> > index 7c78eb1c01ff..1ed2a9ba7ab8 100644
> > --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> > @@ -870,6 +870,12 @@
> > >  				interrupts = <8>;
> > >  			};
> > 
> >  
> > > > +			mbox: mbox@1e789200 {
> > > 
> > > +				compatible = "aspeed,ast2400-mbox";
> > > +				reg = <0x1e789200 0x5c>;
> > > +				interrupts = <46>;
> > 
> > +			};
> 
> Save this for addition in 3/5?
> 
> Or maybe just squash them all together?
> 

Yeah I'm not sure these three commits make sense - it might just be
easier to have 1 dts changes commit.

Thanks,

Cyril

> Andrew
> 
> > +
> > > >  			wdt1: wdt@1e785000 {
> > > 
> > >  				compatible = "aspeed,ast2400-wdt";
> > >  				reg = <0x1e785000 0x1c>;