From: Cyril Bur <cyrilbur@gmail.com>
To: Andrew Jeffery <andrew@aj.id.au>,
benh@au1.ibm.com, openbmc@lists.ozlabs.org
Cc: millerjo@linux.vnet.ibm.com
Subject: Re: [PATCH v2 4/5] drivers/mailbox: Add aspeed ast2400/ast2500 mbox driver
Date: Tue, 10 Jan 2017 10:18:23 +1100 [thread overview]
Message-ID: <1484003903.6236.7.camel@gmail.com> (raw)
In-Reply-To: <1484002504.12800.1.camel@aj.id.au>
On Tue, 2017-01-10 at 09:25 +1030, Andrew Jeffery wrote:
> On Tue, 2017-01-10 at 09:09 +1100, Cyril Bur wrote:
> > On Sun, 2017-01-08 at 15:45 -0600, Benjamin Herrenschmidt wrote:
> > > On Tue, 2017-01-03 at 11:54 +1030, Andrew Jeffery wrote:
> > > > > > I think we should rename the IOCTL as what we do below doesn't
> > > > > > necessarily raise an interrupt.
> > > > > >
> > > > >
> > > > >
> > > > > Agreed, taking unput :). ASPEED_MBOX_IOCTL_WRITE_BYTE ?
> > > >
> > > > That suggestion works for me.
> >
> > Sorry about the blank one, I'll try typing something this time.
> >
> > > If we are going to do that, maybe we should make this a write()
> > > at a specific lpos...
> > >
> >
> > Andrew, Joel what do you think of this, a write of count 1 at a
> > specific pos. I like this since it removes ioctls all together and
> > isn't any harder for userspace.
>
> I'm in favour of removing the ioctl. So the logic would be:
>
Cool done.
> 1. If lpos is zero, assume a MBOX_NUM_DATA_REGS-sized write as we do
> currently
Just to clarify - if lpos is zero anything smaller than or equal to
MBOX_NUM_DATA_REGS is good.
> 2. If lpos is non-zero, assume a single byte write
>
Sounds good.
> On that, should we be testing the assumptions about buffer sizes?
> Currently we don't (we use the MBOX_NUM_DATA_REGS rather than count).
>
Yeah. Simple checks for your condition 1 and 2.
> Andrew
next prev parent reply other threads:[~2017-01-09 23:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 6:06 [PATCH v2 0/5] LPC/MBOX work Cyril Bur
2016-12-22 6:06 ` [PATCH v2 1/5] ARM: dts: aspeed: Reserve BMC ram for host to BMC communication Cyril Bur
2016-12-23 1:01 ` Andrew Jeffery
2016-12-23 7:50 ` Cyril Bur
2016-12-22 6:06 ` [PATCH v2 2/5] ARM: dts: aspeed: Put the lpc_ctrl under lpc_host node for regmap Cyril Bur
2016-12-22 6:06 ` [PATCH v2 3/5] ARM: dts: aspeed: Move mbox under lpc_host node Cyril Bur
2016-12-22 6:06 ` [PATCH v2 4/5] drivers/mailbox: Add aspeed ast2400/ast2500 mbox driver Cyril Bur
2016-12-23 2:42 ` Andrew Jeffery
2016-12-23 7:56 ` Cyril Bur
2017-01-03 1:24 ` Andrew Jeffery
2017-01-08 21:44 ` Benjamin Herrenschmidt
2017-01-08 23:54 ` Andrew Jeffery
2017-01-08 21:45 ` Benjamin Herrenschmidt
2017-01-09 22:09 ` Cyril Bur
2017-01-09 22:55 ` Andrew Jeffery
2017-01-09 23:18 ` Cyril Bur [this message]
2017-01-10 0:07 ` Cyril Bur
2017-01-10 0:10 ` Andrew Jeffery
2017-01-10 4:28 ` Benjamin Herrenschmidt
2017-01-10 4:36 ` Cyril Bur
2017-01-10 4:40 ` Benjamin Herrenschmidt
2017-01-08 21:39 ` Benjamin Herrenschmidt
2016-12-22 6:06 ` [PATCH v2 5/5] drivers/misc: Add aspeed ast2400/ast2500 lpc controlling driver Cyril Bur
2016-12-22 23:54 ` Cyril Bur
2016-12-23 2:43 ` Andrew Jeffery
2016-12-23 2:55 ` Andrew Jeffery
2016-12-23 8:04 ` Cyril Bur
2017-01-03 1:33 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484003903.6236.7.camel@gmail.com \
--to=cyrilbur@gmail.com \
--cc=andrew@aj.id.au \
--cc=benh@au1.ibm.com \
--cc=millerjo@linux.vnet.ibm.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.