All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@redhat.com>
To: eric.auger@redhat.com, eric.auger.pro@gmail.com,
	christoffer.dall@linaro.org, marc.zyngier@arm.com,
	robin.murphy@arm.com, alex.williamson@redhat.com,
	will.deacon@arm.com, joro@8bytes.org, tglx@linutronix.de,
	jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org
Cc: kvm@vger.kernel.org, drjones@redhat.com,
	linux-kernel@vger.kernel.org, pranav.sawargaonkar@gmail.com,
	iommu@lists.linux-foundation.org, punit.agrawal@arm.com,
	diana.craciun@nxp.com, gpkulkarni@gmail.com,
	shankerd@codeaurora.org, bharat.bhushan@nxp.com,
	geethasowjanya.akula@gmail.com
Subject: [PATCH v5 09/17] iommu/amd: Declare MSI and HT regions as reserved IOVA regions
Date: Wed,  4 Jan 2017 13:32:18 +0000	[thread overview]
Message-ID: <1483536746-2725-10-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1483536746-2725-1-git-send-email-eric.auger@redhat.com>

This patch registers the MSI and HT regions as non mappable
reserved regions. They will be exposed in the iommu-group sysfs.

For direct-mapped regions let's also use iommu_alloc_resv_region().

Signed-off-by: Eric Auger <eric.auger@redhat.com>

---

v5: creation
---
 drivers/iommu/amd_iommu.c | 37 ++++++++++++++++++++++++++-----------
 1 file changed, 26 insertions(+), 11 deletions(-)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index c6c3f1e..24c752d 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -3164,6 +3164,7 @@ static bool amd_iommu_capable(enum iommu_cap cap)
 static void amd_iommu_get_resv_regions(struct device *dev,
 				       struct list_head *head)
 {
+	struct iommu_resv_region *region;
 	struct unity_map_entry *entry;
 	int devid;
 
@@ -3172,28 +3173,42 @@ static void amd_iommu_get_resv_regions(struct device *dev,
 		return;
 
 	list_for_each_entry(entry, &amd_iommu_unity_map, list) {
-		struct iommu_resv_region *region;
+		size_t length;
+		int prot = 0;
 
 		if (devid < entry->devid_start || devid > entry->devid_end)
 			continue;
 
-		region = kzalloc(sizeof(*region), GFP_KERNEL);
+		length = entry->address_end - entry->address_start;
+		if (entry->prot & IOMMU_PROT_IR)
+			prot |= IOMMU_READ;
+		if (entry->prot & IOMMU_PROT_IW)
+			prot |= IOMMU_WRITE;
+
+		region = iommu_alloc_resv_region(entry->address_start,
+						 length, prot,
+						 IOMMU_RESV_DIRECT);
 		if (!region) {
 			pr_err("Out of memory allocating dm-regions for %s\n",
 				dev_name(dev));
 			return;
 		}
-
-		region->start = entry->address_start;
-		region->length = entry->address_end - entry->address_start;
-		region->type = IOMMU_RESV_DIRECT;
-		if (entry->prot & IOMMU_PROT_IR)
-			region->prot |= IOMMU_READ;
-		if (entry->prot & IOMMU_PROT_IW)
-			region->prot |= IOMMU_WRITE;
-
 		list_add_tail(&region->list, head);
 	}
+
+	region = iommu_alloc_resv_region(MSI_RANGE_START,
+					 MSI_RANGE_END - MSI_RANGE_START + 1,
+					 0, IOMMU_RESV_NOMAP);
+	if (!region)
+		return;
+	list_add_tail(&region->list, head);
+
+	region = iommu_alloc_resv_region(HT_RANGE_START,
+					 HT_RANGE_END - HT_RANGE_START + 1,
+					 0, IOMMU_RESV_NOMAP);
+	if (!region)
+		return;
+	list_add_tail(&region->list, head);
 }
 
 static void amd_iommu_put_resv_regions(struct device *dev,
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Eric Auger <eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	eric.auger.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	marc.zyngier-5wv7dgnIgG8@public.gmane.org,
	robin.murphy-5wv7dgnIgG8@public.gmane.org,
	alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org,
	tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
	jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: drjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	punit.agrawal-5wv7dgnIgG8@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	geethasowjanya.akula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	pranav.sawargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	shankerd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	gpkulkarni-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: [PATCH v5 09/17] iommu/amd: Declare MSI and HT regions as reserved IOVA regions
Date: Wed,  4 Jan 2017 13:32:18 +0000	[thread overview]
Message-ID: <1483536746-2725-10-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1483536746-2725-1-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

This patch registers the MSI and HT regions as non mappable
reserved regions. They will be exposed in the iommu-group sysfs.

For direct-mapped regions let's also use iommu_alloc_resv_region().

Signed-off-by: Eric Auger <eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

---

v5: creation
---
 drivers/iommu/amd_iommu.c | 37 ++++++++++++++++++++++++++-----------
 1 file changed, 26 insertions(+), 11 deletions(-)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index c6c3f1e..24c752d 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -3164,6 +3164,7 @@ static bool amd_iommu_capable(enum iommu_cap cap)
 static void amd_iommu_get_resv_regions(struct device *dev,
 				       struct list_head *head)
 {
+	struct iommu_resv_region *region;
 	struct unity_map_entry *entry;
 	int devid;
 
@@ -3172,28 +3173,42 @@ static void amd_iommu_get_resv_regions(struct device *dev,
 		return;
 
 	list_for_each_entry(entry, &amd_iommu_unity_map, list) {
-		struct iommu_resv_region *region;
+		size_t length;
+		int prot = 0;
 
 		if (devid < entry->devid_start || devid > entry->devid_end)
 			continue;
 
-		region = kzalloc(sizeof(*region), GFP_KERNEL);
+		length = entry->address_end - entry->address_start;
+		if (entry->prot & IOMMU_PROT_IR)
+			prot |= IOMMU_READ;
+		if (entry->prot & IOMMU_PROT_IW)
+			prot |= IOMMU_WRITE;
+
+		region = iommu_alloc_resv_region(entry->address_start,
+						 length, prot,
+						 IOMMU_RESV_DIRECT);
 		if (!region) {
 			pr_err("Out of memory allocating dm-regions for %s\n",
 				dev_name(dev));
 			return;
 		}
-
-		region->start = entry->address_start;
-		region->length = entry->address_end - entry->address_start;
-		region->type = IOMMU_RESV_DIRECT;
-		if (entry->prot & IOMMU_PROT_IR)
-			region->prot |= IOMMU_READ;
-		if (entry->prot & IOMMU_PROT_IW)
-			region->prot |= IOMMU_WRITE;
-
 		list_add_tail(&region->list, head);
 	}
+
+	region = iommu_alloc_resv_region(MSI_RANGE_START,
+					 MSI_RANGE_END - MSI_RANGE_START + 1,
+					 0, IOMMU_RESV_NOMAP);
+	if (!region)
+		return;
+	list_add_tail(&region->list, head);
+
+	region = iommu_alloc_resv_region(HT_RANGE_START,
+					 HT_RANGE_END - HT_RANGE_START + 1,
+					 0, IOMMU_RESV_NOMAP);
+	if (!region)
+		return;
+	list_add_tail(&region->list, head);
 }
 
 static void amd_iommu_put_resv_regions(struct device *dev,
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: eric.auger@redhat.com (Eric Auger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 09/17] iommu/amd: Declare MSI and HT regions as reserved IOVA regions
Date: Wed,  4 Jan 2017 13:32:18 +0000	[thread overview]
Message-ID: <1483536746-2725-10-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1483536746-2725-1-git-send-email-eric.auger@redhat.com>

This patch registers the MSI and HT regions as non mappable
reserved regions. They will be exposed in the iommu-group sysfs.

For direct-mapped regions let's also use iommu_alloc_resv_region().

Signed-off-by: Eric Auger <eric.auger@redhat.com>

---

v5: creation
---
 drivers/iommu/amd_iommu.c | 37 ++++++++++++++++++++++++++-----------
 1 file changed, 26 insertions(+), 11 deletions(-)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index c6c3f1e..24c752d 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -3164,6 +3164,7 @@ static bool amd_iommu_capable(enum iommu_cap cap)
 static void amd_iommu_get_resv_regions(struct device *dev,
 				       struct list_head *head)
 {
+	struct iommu_resv_region *region;
 	struct unity_map_entry *entry;
 	int devid;
 
@@ -3172,28 +3173,42 @@ static void amd_iommu_get_resv_regions(struct device *dev,
 		return;
 
 	list_for_each_entry(entry, &amd_iommu_unity_map, list) {
-		struct iommu_resv_region *region;
+		size_t length;
+		int prot = 0;
 
 		if (devid < entry->devid_start || devid > entry->devid_end)
 			continue;
 
-		region = kzalloc(sizeof(*region), GFP_KERNEL);
+		length = entry->address_end - entry->address_start;
+		if (entry->prot & IOMMU_PROT_IR)
+			prot |= IOMMU_READ;
+		if (entry->prot & IOMMU_PROT_IW)
+			prot |= IOMMU_WRITE;
+
+		region = iommu_alloc_resv_region(entry->address_start,
+						 length, prot,
+						 IOMMU_RESV_DIRECT);
 		if (!region) {
 			pr_err("Out of memory allocating dm-regions for %s\n",
 				dev_name(dev));
 			return;
 		}
-
-		region->start = entry->address_start;
-		region->length = entry->address_end - entry->address_start;
-		region->type = IOMMU_RESV_DIRECT;
-		if (entry->prot & IOMMU_PROT_IR)
-			region->prot |= IOMMU_READ;
-		if (entry->prot & IOMMU_PROT_IW)
-			region->prot |= IOMMU_WRITE;
-
 		list_add_tail(&region->list, head);
 	}
+
+	region = iommu_alloc_resv_region(MSI_RANGE_START,
+					 MSI_RANGE_END - MSI_RANGE_START + 1,
+					 0, IOMMU_RESV_NOMAP);
+	if (!region)
+		return;
+	list_add_tail(&region->list, head);
+
+	region = iommu_alloc_resv_region(HT_RANGE_START,
+					 HT_RANGE_END - HT_RANGE_START + 1,
+					 0, IOMMU_RESV_NOMAP);
+	if (!region)
+		return;
+	list_add_tail(&region->list, head);
 }
 
 static void amd_iommu_put_resv_regions(struct device *dev,
-- 
1.9.1

  parent reply	other threads:[~2017-01-04 13:44 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-04 13:32 [PATCH v5 00/17] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions Eric Auger
2017-01-04 13:32 ` Eric Auger
2017-01-04 13:32 ` Eric Auger
2017-01-04 13:32 ` [PATCH v5 01/17] iommu/dma: Allow MSI-only cookies Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32 ` [PATCH v5 02/17] iommu: Rename iommu_dm_regions into iommu_resv_regions Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32 ` [PATCH v5 03/17] iommu: Add a new type field in iommu_resv_region Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32 ` [PATCH v5 04/17] iommu: iommu_alloc_resv_region Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32 ` [PATCH v5 05/17] iommu: Only map direct mapped regions Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32 ` [PATCH v5 06/17] iommu: iommu_get_group_resv_regions Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32 ` [PATCH v5 07/17] iommu: Implement reserved_regions iommu-group sysfs file Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32 ` [PATCH v5 08/17] iommu/vt-d: Implement reserved region get/put callbacks Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32 ` Eric Auger [this message]
2017-01-04 13:32   ` [PATCH v5 09/17] iommu/amd: Declare MSI and HT regions as reserved IOVA regions Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32 ` [PATCH v5 10/17] iommu/arm-smmu: Implement reserved region get/put callbacks Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32 ` [PATCH v5 11/17] iommu/arm-smmu-v3: " Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32 ` [PATCH v5 12/17] irqdomain: Add IRQ_DOMAIN_FLAG_MSI_REMAP value Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32 ` [PATCH v5 13/17] irqdomain: irq_domain_check_msi_remap Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:46   ` Marc Zyngier
2017-01-04 13:46     ` Marc Zyngier
2017-01-04 13:46     ` Marc Zyngier
2017-01-04 14:11     ` Auger Eric
2017-01-04 14:11       ` Auger Eric
2017-01-04 14:11       ` Auger Eric
2017-01-04 15:27       ` Marc Zyngier
2017-01-04 15:27         ` Marc Zyngier
2017-01-04 15:27         ` Marc Zyngier
2017-01-04 15:58         ` Auger Eric
2017-01-04 15:58           ` Auger Eric
2017-01-04 15:58           ` Auger Eric
2017-01-05 10:45         ` Auger Eric
2017-01-05 10:45           ` Auger Eric
2017-01-05 10:45           ` Auger Eric
2017-01-05 11:25           ` Marc Zyngier
2017-01-05 11:25             ` Marc Zyngier
2017-01-05 11:25             ` Marc Zyngier
2017-01-05 11:29             ` Auger Eric
2017-01-05 11:29               ` Auger Eric
2017-01-05 11:29               ` Auger Eric
2017-01-05 11:57               ` Marc Zyngier
2017-01-05 11:57                 ` Marc Zyngier
2017-01-05 12:08                 ` Auger Eric
2017-01-05 12:08                   ` Auger Eric
2017-01-05 12:08                   ` Auger Eric
2017-01-06  4:27                   ` Bharat Bhushan
2017-01-06  4:27                     ` Bharat Bhushan
2017-01-06  4:27                     ` Bharat Bhushan
2017-01-06  8:35                     ` Auger Eric
2017-01-06  8:35                       ` Auger Eric
2017-01-06  8:35                       ` Auger Eric
2017-01-06  9:42                     ` Marc Zyngier
2017-01-06  9:42                       ` Marc Zyngier
2017-01-06  9:42                       ` Marc Zyngier
2017-01-05  6:28   ` kbuild test robot
2017-01-05  6:28     ` kbuild test robot
2017-01-05  6:28     ` kbuild test robot
2017-01-04 13:32 ` [PATCH v5 14/17] irqchip/gicv3-its: Sets IRQ_DOMAIN_FLAG_MSI_REMAP Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32 ` [PATCH v5 15/17] vfio/type1: Allow transparent MSI IOVA allocation Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32 ` [PATCH v5 16/17] vfio/type1: Check MSI remapping at irq domain level Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32 ` [PATCH v5 17/17] iommu/arm-smmu: Do not advertise IOMMU_CAP_INTR_REMAP anymore Eric Auger
2017-01-04 13:32   ` Eric Auger
2017-01-04 13:32   ` Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483536746-2725-10-git-send-email-eric.auger@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=bharat.bhushan@nxp.com \
    --cc=christoffer.dall@linaro.org \
    --cc=diana.craciun@nxp.com \
    --cc=drjones@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=geethasowjanya.akula@gmail.com \
    --cc=gpkulkarni@gmail.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jason@lakedaemon.net \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=pranav.sawargaonkar@gmail.com \
    --cc=punit.agrawal@arm.com \
    --cc=robin.murphy@arm.com \
    --cc=shankerd@codeaurora.org \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.