From: Sean Wang <sean.wang@mediatek.com>
To: Andi Shyti <andi.shyti@samsung.com>
Cc: <mchehab@osg.samsung.com>, <hdegoede@redhat.com>,
<hkallweit1@gmail.com>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <matthias.bgg@gmail.com>,
<hverkuil@xs4all.nl>, <sean@mess.org>,
<ivo.g.dimitrov.75@gmail.com>, <linux-media@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <keyhaede@gmail.com>
Subject: Re: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC
Date: Fri, 6 Jan 2017 15:41:30 +0800 [thread overview]
Message-ID: <1483688490.16976.26.camel@mtkswgap22> (raw)
In-Reply-To: <20170106034346.7njhyhtsc4yado5c@gangnam.samsung>
Hi Andi,
Thank for your reminder. I will refine the code based on your work.
to have elegant code and easy error handling.
Sean
On Fri, 2017-01-06 at 12:43 +0900, Andi Shyti wrote:
> Hi Sean,
>
> > + ir->rc = rc_allocate_device();
>
> Yes, you should use devm_rc_allocate_device(...)
>
> Besides, standing to this patch which is not in yet:
>
> https://lkml.org/lkml/2016/12/18/39
>
> rc_allocate_device should provide the driver type during
> allocation, so it should be:
>
> ir->rc = rc_allocate_device(RC_DRIVER_IR_RAW);
>
> and this line can be removed:
>
> > + ir->rc->driver_type = RC_DRIVER_IR_RAW;
>
> I don't know when Mauro will take the patch above.
>
> Andi
WARNING: multiple messages have this Message-ID (diff)
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Andi Shyti <andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org,
hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
hkallweit1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org,
sean-hENCXIMQXOg@public.gmane.org,
ivo.g.dimitrov.75-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
keyhaede-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC
Date: Fri, 6 Jan 2017 15:41:30 +0800 [thread overview]
Message-ID: <1483688490.16976.26.camel@mtkswgap22> (raw)
In-Reply-To: <20170106034346.7njhyhtsc4yado5c-8vUhnHFVuGn35fTxX1Dczw@public.gmane.org>
Hi Andi,
Thank for your reminder. I will refine the code based on your work.
to have elegant code and easy error handling.
Sean
On Fri, 2017-01-06 at 12:43 +0900, Andi Shyti wrote:
> Hi Sean,
>
> > + ir->rc = rc_allocate_device();
>
> Yes, you should use devm_rc_allocate_device(...)
>
> Besides, standing to this patch which is not in yet:
>
> https://lkml.org/lkml/2016/12/18/39
>
> rc_allocate_device should provide the driver type during
> allocation, so it should be:
>
> ir->rc = rc_allocate_device(RC_DRIVER_IR_RAW);
>
> and this line can be removed:
>
> > + ir->rc->driver_type = RC_DRIVER_IR_RAW;
>
> I don't know when Mauro will take the patch above.
>
> Andi
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: sean.wang@mediatek.com (Sean Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC
Date: Fri, 6 Jan 2017 15:41:30 +0800 [thread overview]
Message-ID: <1483688490.16976.26.camel@mtkswgap22> (raw)
In-Reply-To: <20170106034346.7njhyhtsc4yado5c@gangnam.samsung>
Hi Andi,
Thank for your reminder. I will refine the code based on your work.
to have elegant code and easy error handling.
Sean
On Fri, 2017-01-06 at 12:43 +0900, Andi Shyti wrote:
> Hi Sean,
>
> > + ir->rc = rc_allocate_device();
>
> Yes, you should use devm_rc_allocate_device(...)
>
> Besides, standing to this patch which is not in yet:
>
> https://lkml.org/lkml/2016/12/18/39
>
> rc_allocate_device should provide the driver type during
> allocation, so it should be:
>
> ir->rc = rc_allocate_device(RC_DRIVER_IR_RAW);
>
> and this line can be removed:
>
> > + ir->rc->driver_type = RC_DRIVER_IR_RAW;
>
> I don't know when Mauro will take the patch above.
>
> Andi
next prev parent reply other threads:[~2017-01-06 7:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 16:06 [PATCH 0/2] media: rc: add support for IR receiver on MT7623 SoC sean.wang
2017-01-05 16:06 ` sean.wang at mediatek.com
2017-01-05 16:06 ` sean.wang
2017-01-05 16:06 ` [PATCH 1/2] Documentation: devicetree: Add document bindings for mtk-cir sean.wang
2017-01-05 16:06 ` sean.wang at mediatek.com
2017-01-05 16:06 ` sean.wang
2017-01-09 18:32 ` Rob Herring
2017-01-09 18:32 ` Rob Herring
2017-01-09 18:32 ` Rob Herring
2017-01-10 2:35 ` Sean Wang
2017-01-10 2:35 ` Sean Wang
2017-01-10 2:35 ` Sean Wang
2017-01-11 21:27 ` Rob Herring
2017-01-11 21:27 ` Rob Herring
2017-01-11 21:27 ` Rob Herring
2017-01-05 16:06 ` [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC sean.wang
2017-01-05 16:06 ` sean.wang at mediatek.com
2017-01-05 16:06 ` sean.wang
2017-01-05 17:12 ` Sean Young
2017-01-05 17:12 ` Sean Young
2017-01-05 17:12 ` Sean Young
2017-01-06 7:31 ` Sean Wang
2017-01-06 7:31 ` Sean Wang
2017-01-06 7:31 ` Sean Wang
2017-01-08 21:16 ` Sean Young
2017-01-08 21:16 ` Sean Young
2017-01-09 3:13 ` Sean Wang
2017-01-09 3:13 ` Sean Wang
2017-01-09 3:13 ` Sean Wang
2017-01-09 12:39 ` Sean Young
2017-01-09 12:39 ` Sean Young
2017-01-09 12:39 ` Sean Young
2017-01-06 3:43 ` Andi Shyti
2017-01-06 3:43 ` Andi Shyti
2017-01-06 3:43 ` Andi Shyti
2017-01-06 7:41 ` Sean Wang [this message]
2017-01-06 7:41 ` Sean Wang
2017-01-06 7:41 ` Sean Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483688490.16976.26.camel@mtkswgap22 \
--to=sean.wang@mediatek.com \
--cc=andi.shyti@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=hkallweit1@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=keyhaede@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@osg.samsung.com \
--cc=robh+dt@kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.